[Lens][ESQL] Fix ES|QL Query Results Section and Add Flyout Scrolling #228957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariairiartef
added
bug
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
Contributor
Author
|
@gvnmagni, @andreadelrio do you think making the entire flyout content scrollable is a feasible solution? This approach would be simpler and less complex compared to making the ES|QL Query Results section scrollable. My concern, however, is that this change would affect all flyouts, even in cases where we only have one section open at a time. We need to evaluate if this change is appropriate or if we should implement a more specific fix for the ES|QL Query Results section. Checked offline with @gvnmagni and he is fine with this. |
andrimal
approved these changes
Jul 23, 2025
Contributor
andrimal
left a comment
andrimal
left a comment
There was a problem hiding this comment.
Tested locally in all browsers and the issues are fixed 🚀
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16475003951 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 23, 2025
…elastic#228957) Fixes elastic#227924 ## Summary ### ES|QL Query Results Not Displaying in Safari Fixed the EUI accordion expansion behavior that prevented the ES|QL query results from displaying in Safari browsers. https://github.com/user-attachments/assets/9f2fc7f8-1b6e-47d5-a273-277de804b65c ### ES|QL Query Results Section Not Scrollable Implemented configuration to allow content to scroll within the flyout. > [!NOTE] > Instead of making each section scrollable, as there is already too much content, an alternative could be to make all the content scrollable so we are not limited by each section, especially in this case where we can have more than one section open (e.g. _ES|QL Query Results_ and _Visualization parameters_). https://github.com/user-attachments/assets/bec1b467-255f-4e13-bb53-27d9d6856346 > [!WARNING] > This solution also affects the rest of the flyout section configurations. ### Before https://github.com/user-attachments/assets/9d7e04ac-e683-4778-9cff-1cb18ebe234b ### After https://github.com/user-attachments/assets/31b426d3-3b86-4db2-8db0-28eca643465d ## Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 2a4034d)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 23, 2025
…elastic#228957) Fixes elastic#227924 ## Summary ### ES|QL Query Results Not Displaying in Safari Fixed the EUI accordion expansion behavior that prevented the ES|QL query results from displaying in Safari browsers. https://github.com/user-attachments/assets/9f2fc7f8-1b6e-47d5-a273-277de804b65c ### ES|QL Query Results Section Not Scrollable Implemented configuration to allow content to scroll within the flyout. > [!NOTE] > Instead of making each section scrollable, as there is already too much content, an alternative could be to make all the content scrollable so we are not limited by each section, especially in this case where we can have more than one section open (e.g. _ES|QL Query Results_ and _Visualization parameters_). https://github.com/user-attachments/assets/bec1b467-255f-4e13-bb53-27d9d6856346 > [!WARNING] > This solution also affects the rest of the flyout section configurations. ### Before https://github.com/user-attachments/assets/9d7e04ac-e683-4778-9cff-1cb18ebe234b ### After https://github.com/user-attachments/assets/31b426d3-3b86-4db2-8db0-28eca643465d ## Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 2a4034d)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 23, 2025
…olling (#228957) (#229181) # Backport This will backport the following commits from `main` to `9.1`: - [[Lens][ESQL] Fix ES|QL Query Results Section and Add Flyout Scrolling (#228957)](#228957) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maria Iriarte","email":"106958839+mariairiartef@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-23T15:28:42Z","message":"[Lens][ESQL] Fix ES|QL Query Results Section and Add Flyout Scrolling (#228957)\n\nFixes https://github.com/elastic/kibana/issues/227924\n\n## Summary\n\n### ES|QL Query Results Not Displaying in Safari\n\nFixed the EUI accordion expansion behavior that prevented the ES|QL\nquery results from displaying in Safari browsers.\n\n\nhttps://github.com/user-attachments/assets/9f2fc7f8-1b6e-47d5-a273-277de804b65c\n\n### ES|QL Query Results Section Not Scrollable\n\nImplemented configuration to allow content to scroll within the flyout.\n\n> [!NOTE]\n> Instead of making each section scrollable, as there is already too\nmuch content, an alternative could be to make all the content scrollable\nso we are not limited by each section, especially in this case where we\ncan have more than one section open (e.g. _ES|QL Query Results_ and\n_Visualization parameters_).\n\n\nhttps://github.com/user-attachments/assets/bec1b467-255f-4e13-bb53-27d9d6856346\n\n> [!WARNING]\n> This solution also affects the rest of the flyout section\nconfigurations.\n\n### Before\n\n\nhttps://github.com/user-attachments/assets/9d7e04ac-e683-4778-9cff-1cb18ebe234b\n\n### After\n\n\nhttps://github.com/user-attachments/assets/31b426d3-3b86-4db2-8db0-28eca643465d\n\n## Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2a4034d6929e10ff09a632c61853fdf839774c2a","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Visualizations","release_note:skip","Feature:Lens","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Lens][ESQL] Fix ES|QL Query Results Section and Add Flyout Scrolling","number":228957,"url":"https://github.com/elastic/kibana/pull/228957","mergeCommit":{"message":"[Lens][ESQL] Fix ES|QL Query Results Section and Add Flyout Scrolling (#228957)\n\nFixes https://github.com/elastic/kibana/issues/227924\n\n## Summary\n\n### ES|QL Query Results Not Displaying in Safari\n\nFixed the EUI accordion expansion behavior that prevented the ES|QL\nquery results from displaying in Safari browsers.\n\n\nhttps://github.com/user-attachments/assets/9f2fc7f8-1b6e-47d5-a273-277de804b65c\n\n### ES|QL Query Results Section Not Scrollable\n\nImplemented configuration to allow content to scroll within the flyout.\n\n> [!NOTE]\n> Instead of making each section scrollable, as there is already too\nmuch content, an alternative could be to make all the content scrollable\nso we are not limited by each section, especially in this case where we\ncan have more than one section open (e.g. _ES|QL Query Results_ and\n_Visualization parameters_).\n\n\nhttps://github.com/user-attachments/assets/bec1b467-255f-4e13-bb53-27d9d6856346\n\n> [!WARNING]\n> This solution also affects the rest of the flyout section\nconfigurations.\n\n### Before\n\n\nhttps://github.com/user-attachments/assets/9d7e04ac-e683-4778-9cff-1cb18ebe234b\n\n### After\n\n\nhttps://github.com/user-attachments/assets/31b426d3-3b86-4db2-8db0-28eca643465d\n\n## Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2a4034d6929e10ff09a632c61853fdf839774c2a"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228957","number":228957,"mergeCommit":{"message":"[Lens][ESQL] Fix ES|QL Query Results Section and Add Flyout Scrolling (#228957)\n\nFixes https://github.com/elastic/kibana/issues/227924\n\n## Summary\n\n### ES|QL Query Results Not Displaying in Safari\n\nFixed the EUI accordion expansion behavior that prevented the ES|QL\nquery results from displaying in Safari browsers.\n\n\nhttps://github.com/user-attachments/assets/9f2fc7f8-1b6e-47d5-a273-277de804b65c\n\n### ES|QL Query Results Section Not Scrollable\n\nImplemented configuration to allow content to scroll within the flyout.\n\n> [!NOTE]\n> Instead of making each section scrollable, as there is already too\nmuch content, an alternative could be to make all the content scrollable\nso we are not limited by each section, especially in this case where we\ncan have more than one section open (e.g. _ES|QL Query Results_ and\n_Visualization parameters_).\n\n\nhttps://github.com/user-attachments/assets/bec1b467-255f-4e13-bb53-27d9d6856346\n\n> [!WARNING]\n> This solution also affects the rest of the flyout section\nconfigurations.\n\n### Before\n\n\nhttps://github.com/user-attachments/assets/9d7e04ac-e683-4778-9cff-1cb18ebe234b\n\n### After\n\n\nhttps://github.com/user-attachments/assets/31b426d3-3b86-4db2-8db0-28eca643465d\n\n## Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2a4034d6929e10ff09a632c61853fdf839774c2a"}}]}] BACKPORT--> Co-authored-by: Maria Iriarte <106958839+mariairiartef@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Jul 23, 2025
…rolling (#228957) (#229180) # Backport This will backport the following commits from `main` to `8.19`: - [[Lens][ESQL] Fix ES|QL Query Results Section and Add Flyout Scrolling (#228957)](#228957) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maria Iriarte","email":"106958839+mariairiartef@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-23T15:28:42Z","message":"[Lens][ESQL] Fix ES|QL Query Results Section and Add Flyout Scrolling (#228957)\n\nFixes https://github.com/elastic/kibana/issues/227924\n\n## Summary\n\n### ES|QL Query Results Not Displaying in Safari\n\nFixed the EUI accordion expansion behavior that prevented the ES|QL\nquery results from displaying in Safari browsers.\n\n\nhttps://github.com/user-attachments/assets/9f2fc7f8-1b6e-47d5-a273-277de804b65c\n\n### ES|QL Query Results Section Not Scrollable\n\nImplemented configuration to allow content to scroll within the flyout.\n\n> [!NOTE]\n> Instead of making each section scrollable, as there is already too\nmuch content, an alternative could be to make all the content scrollable\nso we are not limited by each section, especially in this case where we\ncan have more than one section open (e.g. _ES|QL Query Results_ and\n_Visualization parameters_).\n\n\nhttps://github.com/user-attachments/assets/bec1b467-255f-4e13-bb53-27d9d6856346\n\n> [!WARNING]\n> This solution also affects the rest of the flyout section\nconfigurations.\n\n### Before\n\n\nhttps://github.com/user-attachments/assets/9d7e04ac-e683-4778-9cff-1cb18ebe234b\n\n### After\n\n\nhttps://github.com/user-attachments/assets/31b426d3-3b86-4db2-8db0-28eca643465d\n\n## Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2a4034d6929e10ff09a632c61853fdf839774c2a","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Visualizations","release_note:skip","Feature:Lens","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Lens][ESQL] Fix ES|QL Query Results Section and Add Flyout Scrolling","number":228957,"url":"https://github.com/elastic/kibana/pull/228957","mergeCommit":{"message":"[Lens][ESQL] Fix ES|QL Query Results Section and Add Flyout Scrolling (#228957)\n\nFixes https://github.com/elastic/kibana/issues/227924\n\n## Summary\n\n### ES|QL Query Results Not Displaying in Safari\n\nFixed the EUI accordion expansion behavior that prevented the ES|QL\nquery results from displaying in Safari browsers.\n\n\nhttps://github.com/user-attachments/assets/9f2fc7f8-1b6e-47d5-a273-277de804b65c\n\n### ES|QL Query Results Section Not Scrollable\n\nImplemented configuration to allow content to scroll within the flyout.\n\n> [!NOTE]\n> Instead of making each section scrollable, as there is already too\nmuch content, an alternative could be to make all the content scrollable\nso we are not limited by each section, especially in this case where we\ncan have more than one section open (e.g. _ES|QL Query Results_ and\n_Visualization parameters_).\n\n\nhttps://github.com/user-attachments/assets/bec1b467-255f-4e13-bb53-27d9d6856346\n\n> [!WARNING]\n> This solution also affects the rest of the flyout section\nconfigurations.\n\n### Before\n\n\nhttps://github.com/user-attachments/assets/9d7e04ac-e683-4778-9cff-1cb18ebe234b\n\n### After\n\n\nhttps://github.com/user-attachments/assets/31b426d3-3b86-4db2-8db0-28eca643465d\n\n## Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2a4034d6929e10ff09a632c61853fdf839774c2a"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228957","number":228957,"mergeCommit":{"message":"[Lens][ESQL] Fix ES|QL Query Results Section and Add Flyout Scrolling (#228957)\n\nFixes https://github.com/elastic/kibana/issues/227924\n\n## Summary\n\n### ES|QL Query Results Not Displaying in Safari\n\nFixed the EUI accordion expansion behavior that prevented the ES|QL\nquery results from displaying in Safari browsers.\n\n\nhttps://github.com/user-attachments/assets/9f2fc7f8-1b6e-47d5-a273-277de804b65c\n\n### ES|QL Query Results Section Not Scrollable\n\nImplemented configuration to allow content to scroll within the flyout.\n\n> [!NOTE]\n> Instead of making each section scrollable, as there is already too\nmuch content, an alternative could be to make all the content scrollable\nso we are not limited by each section, especially in this case where we\ncan have more than one section open (e.g. _ES|QL Query Results_ and\n_Visualization parameters_).\n\n\nhttps://github.com/user-attachments/assets/bec1b467-255f-4e13-bb53-27d9d6856346\n\n> [!WARNING]\n> This solution also affects the rest of the flyout section\nconfigurations.\n\n### Before\n\n\nhttps://github.com/user-attachments/assets/9d7e04ac-e683-4778-9cff-1cb18ebe234b\n\n### After\n\n\nhttps://github.com/user-attachments/assets/31b426d3-3b86-4db2-8db0-28eca643465d\n\n## Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2a4034d6929e10ff09a632c61853fdf839774c2a"}}]}] BACKPORT--> Co-authored-by: Maria Iriarte <106958839+mariairiartef@users.noreply.github.com>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
…elastic#228957) Fixes elastic#227924 ## Summary ### ES|QL Query Results Not Displaying in Safari Fixed the EUI accordion expansion behavior that prevented the ES|QL query results from displaying in Safari browsers. https://github.com/user-attachments/assets/9f2fc7f8-1b6e-47d5-a273-277de804b65c ### ES|QL Query Results Section Not Scrollable Implemented configuration to allow content to scroll within the flyout. > [!NOTE] > Instead of making each section scrollable, as there is already too much content, an alternative could be to make all the content scrollable so we are not limited by each section, especially in this case where we can have more than one section open (e.g. _ES|QL Query Results_ and _Visualization parameters_). https://github.com/user-attachments/assets/bec1b467-255f-4e13-bb53-27d9d6856346 > [!WARNING] > This solution also affects the rest of the flyout section configurations. ### Before https://github.com/user-attachments/assets/9d7e04ac-e683-4778-9cff-1cb18ebe234b ### After https://github.com/user-attachments/assets/31b426d3-3b86-4db2-8db0-28eca643465d ## Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
This was referenced Jul 30, 2025
Closed
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Jul 31, 2025
…elastic#228957) Fixes elastic#227924 ## Summary ### ES|QL Query Results Not Displaying in Safari Fixed the EUI accordion expansion behavior that prevented the ES|QL query results from displaying in Safari browsers. https://github.com/user-attachments/assets/9f2fc7f8-1b6e-47d5-a273-277de804b65c ### ES|QL Query Results Section Not Scrollable Implemented configuration to allow content to scroll within the flyout. > [!NOTE] > Instead of making each section scrollable, as there is already too much content, an alternative could be to make all the content scrollable so we are not limited by each section, especially in this case where we can have more than one section open (e.g. _ES|QL Query Results_ and _Visualization parameters_). https://github.com/user-attachments/assets/bec1b467-255f-4e13-bb53-27d9d6856346 > [!WARNING] > This solution also affects the rest of the flyout section configurations. ### Before https://github.com/user-attachments/assets/9d7e04ac-e683-4778-9cff-1cb18ebe234b ### After https://github.com/user-attachments/assets/31b426d3-3b86-4db2-8db0-28eca643465d ## Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
dej611
added a commit
that referenced
this pull request
Jul 31, 2025
#229967) ## Summary Fixes #229941 This PR scopes a specific regression introduced by a fix in #228957 to ES|QL editing only where `Advanced Options` are not available. Chrome: <img width="1174" height="889" alt="Screenshot 2025-07-30 at 16 07 04" src="https://github.com/user-attachments/assets/a6870dcb-3097-4be4-b70e-a3a932a89f7a" /> <img width="1913" height="892" alt="Screenshot 2025-07-30 at 16 06 52" src="https://github.com/user-attachments/assets/0adeb1c2-5924-4e31-949b-c6e8f0776964" /> Showing Safari as well for the Query result panel: <img width="973" height="725" alt="Screenshot 2025-07-30 at 16 08 23" src="https://github.com/user-attachments/assets/38c407c5-c6f8-46e5-8c90-661b8f26366f" /> <img width="1499" height="754" alt="Screenshot 2025-07-30 at 16 08 09" src="https://github.com/user-attachments/assets/601bd62a-94ef-417c-8e90-77f971c35e42" />
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 31, 2025
elastic#229967) ## Summary Fixes elastic#229941 This PR scopes a specific regression introduced by a fix in elastic#228957 to ES|QL editing only where `Advanced Options` are not available. Chrome: <img width="1174" height="889" alt="Screenshot 2025-07-30 at 16 07 04" src="https://github.com/user-attachments/assets/a6870dcb-3097-4be4-b70e-a3a932a89f7a" /> <img width="1913" height="892" alt="Screenshot 2025-07-30 at 16 06 52" src="https://github.com/user-attachments/assets/0adeb1c2-5924-4e31-949b-c6e8f0776964" /> Showing Safari as well for the Query result panel: <img width="973" height="725" alt="Screenshot 2025-07-30 at 16 08 23" src="https://github.com/user-attachments/assets/38c407c5-c6f8-46e5-8c90-661b8f26366f" /> <img width="1499" height="754" alt="Screenshot 2025-07-30 at 16 08 09" src="https://github.com/user-attachments/assets/601bd62a-94ef-417c-8e90-77f971c35e42" /> (cherry picked from commit 4f3380c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 31, 2025
elastic#229967) ## Summary Fixes elastic#229941 This PR scopes a specific regression introduced by a fix in elastic#228957 to ES|QL editing only where `Advanced Options` are not available. Chrome: <img width="1174" height="889" alt="Screenshot 2025-07-30 at 16 07 04" src="https://github.com/user-attachments/assets/a6870dcb-3097-4be4-b70e-a3a932a89f7a" /> <img width="1913" height="892" alt="Screenshot 2025-07-30 at 16 06 52" src="https://github.com/user-attachments/assets/0adeb1c2-5924-4e31-949b-c6e8f0776964" /> Showing Safari as well for the Query result panel: <img width="973" height="725" alt="Screenshot 2025-07-30 at 16 08 23" src="https://github.com/user-attachments/assets/38c407c5-c6f8-46e5-8c90-661b8f26366f" /> <img width="1499" height="754" alt="Screenshot 2025-07-30 at 16 08 09" src="https://github.com/user-attachments/assets/601bd62a-94ef-417c-8e90-77f971c35e42" /> (cherry picked from commit 4f3380c)
kibanamachine
added a commit
that referenced
this pull request
Jul 31, 2025
…editing (#229967) (#230040) # Backport This will backport the following commits from `main` to `9.1`: - [[Lens] Fix extra padding below Advanced Options when in inline editing (#229967)](#229967) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-31T08:42:23Z","message":"[Lens] Fix extra padding below Advanced Options when in inline editing (#229967)\n\n## Summary\n\nFixes #229941 \n\nThis PR scopes a specific regression introduced by a fix in\nhttps://github.com//pull/228957 to ES|QL editing only\nwhere `Advanced Options` are not available.\n\nChrome:\n\n<img width=\"1174\" height=\"889\" alt=\"Screenshot 2025-07-30 at 16 07 04\"\nsrc=\"https://github.com/user-attachments/assets/a6870dcb-3097-4be4-b70e-a3a932a89f7a\"\n/>\n<img width=\"1913\" height=\"892\" alt=\"Screenshot 2025-07-30 at 16 06 52\"\nsrc=\"https://github.com/user-attachments/assets/0adeb1c2-5924-4e31-949b-c6e8f0776964\"\n/>\n\nShowing Safari as well for the Query result panel:\n<img width=\"973\" height=\"725\" alt=\"Screenshot 2025-07-30 at 16 08 23\"\nsrc=\"https://github.com/user-attachments/assets/38c407c5-c6f8-46e5-8c90-661b8f26366f\"\n/>\n<img width=\"1499\" height=\"754\" alt=\"Screenshot 2025-07-30 at 16 08 09\"\nsrc=\"https://github.com/user-attachments/assets/601bd62a-94ef-417c-8e90-77f971c35e42\"\n/>","sha":"4f3380cfaaf65e8f1b3a75dd1bf34ab23778965f","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:version","v9.2.0","v9.1.1","v8.19.1"],"title":"[Lens] Fix extra padding below Advanced Options when in inline editing","number":229967,"url":"https://github.com/elastic/kibana/pull/229967","mergeCommit":{"message":"[Lens] Fix extra padding below Advanced Options when in inline editing (#229967)\n\n## Summary\n\nFixes #229941 \n\nThis PR scopes a specific regression introduced by a fix in\nhttps://github.com//pull/228957 to ES|QL editing only\nwhere `Advanced Options` are not available.\n\nChrome:\n\n<img width=\"1174\" height=\"889\" alt=\"Screenshot 2025-07-30 at 16 07 04\"\nsrc=\"https://github.com/user-attachments/assets/a6870dcb-3097-4be4-b70e-a3a932a89f7a\"\n/>\n<img width=\"1913\" height=\"892\" alt=\"Screenshot 2025-07-30 at 16 06 52\"\nsrc=\"https://github.com/user-attachments/assets/0adeb1c2-5924-4e31-949b-c6e8f0776964\"\n/>\n\nShowing Safari as well for the Query result panel:\n<img width=\"973\" height=\"725\" alt=\"Screenshot 2025-07-30 at 16 08 23\"\nsrc=\"https://github.com/user-attachments/assets/38c407c5-c6f8-46e5-8c90-661b8f26366f\"\n/>\n<img width=\"1499\" height=\"754\" alt=\"Screenshot 2025-07-30 at 16 08 09\"\nsrc=\"https://github.com/user-attachments/assets/601bd62a-94ef-417c-8e90-77f971c35e42\"\n/>","sha":"4f3380cfaaf65e8f1b3a75dd1bf34ab23778965f"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229967","number":229967,"mergeCommit":{"message":"[Lens] Fix extra padding below Advanced Options when in inline editing (#229967)\n\n## Summary\n\nFixes #229941 \n\nThis PR scopes a specific regression introduced by a fix in\nhttps://github.com//pull/228957 to ES|QL editing only\nwhere `Advanced Options` are not available.\n\nChrome:\n\n<img width=\"1174\" height=\"889\" alt=\"Screenshot 2025-07-30 at 16 07 04\"\nsrc=\"https://github.com/user-attachments/assets/a6870dcb-3097-4be4-b70e-a3a932a89f7a\"\n/>\n<img width=\"1913\" height=\"892\" alt=\"Screenshot 2025-07-30 at 16 06 52\"\nsrc=\"https://github.com/user-attachments/assets/0adeb1c2-5924-4e31-949b-c6e8f0776964\"\n/>\n\nShowing Safari as well for the Query result panel:\n<img width=\"973\" height=\"725\" alt=\"Screenshot 2025-07-30 at 16 08 23\"\nsrc=\"https://github.com/user-attachments/assets/38c407c5-c6f8-46e5-8c90-661b8f26366f\"\n/>\n<img width=\"1499\" height=\"754\" alt=\"Screenshot 2025-07-30 at 16 08 09\"\nsrc=\"https://github.com/user-attachments/assets/601bd62a-94ef-417c-8e90-77f971c35e42\"\n/>","sha":"4f3380cfaaf65e8f1b3a75dd1bf34ab23778965f"}},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Jul 31, 2025
… editing (#229967) (#230039) # Backport This will backport the following commits from `main` to `8.19`: - [[Lens] Fix extra padding below Advanced Options when in inline editing (#229967)](#229967) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-31T08:42:23Z","message":"[Lens] Fix extra padding below Advanced Options when in inline editing (#229967)\n\n## Summary\n\nFixes #229941 \n\nThis PR scopes a specific regression introduced by a fix in\nhttps://github.com//pull/228957 to ES|QL editing only\nwhere `Advanced Options` are not available.\n\nChrome:\n\n<img width=\"1174\" height=\"889\" alt=\"Screenshot 2025-07-30 at 16 07 04\"\nsrc=\"https://github.com/user-attachments/assets/a6870dcb-3097-4be4-b70e-a3a932a89f7a\"\n/>\n<img width=\"1913\" height=\"892\" alt=\"Screenshot 2025-07-30 at 16 06 52\"\nsrc=\"https://github.com/user-attachments/assets/0adeb1c2-5924-4e31-949b-c6e8f0776964\"\n/>\n\nShowing Safari as well for the Query result panel:\n<img width=\"973\" height=\"725\" alt=\"Screenshot 2025-07-30 at 16 08 23\"\nsrc=\"https://github.com/user-attachments/assets/38c407c5-c6f8-46e5-8c90-661b8f26366f\"\n/>\n<img width=\"1499\" height=\"754\" alt=\"Screenshot 2025-07-30 at 16 08 09\"\nsrc=\"https://github.com/user-attachments/assets/601bd62a-94ef-417c-8e90-77f971c35e42\"\n/>","sha":"4f3380cfaaf65e8f1b3a75dd1bf34ab23778965f","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:version","v9.2.0","v9.1.1","v8.19.1"],"title":"[Lens] Fix extra padding below Advanced Options when in inline editing","number":229967,"url":"https://github.com/elastic/kibana/pull/229967","mergeCommit":{"message":"[Lens] Fix extra padding below Advanced Options when in inline editing (#229967)\n\n## Summary\n\nFixes #229941 \n\nThis PR scopes a specific regression introduced by a fix in\nhttps://github.com//pull/228957 to ES|QL editing only\nwhere `Advanced Options` are not available.\n\nChrome:\n\n<img width=\"1174\" height=\"889\" alt=\"Screenshot 2025-07-30 at 16 07 04\"\nsrc=\"https://github.com/user-attachments/assets/a6870dcb-3097-4be4-b70e-a3a932a89f7a\"\n/>\n<img width=\"1913\" height=\"892\" alt=\"Screenshot 2025-07-30 at 16 06 52\"\nsrc=\"https://github.com/user-attachments/assets/0adeb1c2-5924-4e31-949b-c6e8f0776964\"\n/>\n\nShowing Safari as well for the Query result panel:\n<img width=\"973\" height=\"725\" alt=\"Screenshot 2025-07-30 at 16 08 23\"\nsrc=\"https://github.com/user-attachments/assets/38c407c5-c6f8-46e5-8c90-661b8f26366f\"\n/>\n<img width=\"1499\" height=\"754\" alt=\"Screenshot 2025-07-30 at 16 08 09\"\nsrc=\"https://github.com/user-attachments/assets/601bd62a-94ef-417c-8e90-77f971c35e42\"\n/>","sha":"4f3380cfaaf65e8f1b3a75dd1bf34ab23778965f"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229967","number":229967,"mergeCommit":{"message":"[Lens] Fix extra padding below Advanced Options when in inline editing (#229967)\n\n## Summary\n\nFixes #229941 \n\nThis PR scopes a specific regression introduced by a fix in\nhttps://github.com//pull/228957 to ES|QL editing only\nwhere `Advanced Options` are not available.\n\nChrome:\n\n<img width=\"1174\" height=\"889\" alt=\"Screenshot 2025-07-30 at 16 07 04\"\nsrc=\"https://github.com/user-attachments/assets/a6870dcb-3097-4be4-b70e-a3a932a89f7a\"\n/>\n<img width=\"1913\" height=\"892\" alt=\"Screenshot 2025-07-30 at 16 06 52\"\nsrc=\"https://github.com/user-attachments/assets/0adeb1c2-5924-4e31-949b-c6e8f0776964\"\n/>\n\nShowing Safari as well for the Query result panel:\n<img width=\"973\" height=\"725\" alt=\"Screenshot 2025-07-30 at 16 08 23\"\nsrc=\"https://github.com/user-attachments/assets/38c407c5-c6f8-46e5-8c90-661b8f26366f\"\n/>\n<img width=\"1499\" height=\"754\" alt=\"Screenshot 2025-07-30 at 16 08 09\"\nsrc=\"https://github.com/user-attachments/assets/601bd62a-94ef-417c-8e90-77f971c35e42\"\n/>","sha":"4f3380cfaaf65e8f1b3a75dd1bf34ab23778965f"}},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
elastic#229967) ## Summary Fixes elastic#229941 This PR scopes a specific regression introduced by a fix in elastic#228957 to ES|QL editing only where `Advanced Options` are not available. Chrome: <img width="1174" height="889" alt="Screenshot 2025-07-30 at 16 07 04" src="https://github.com/user-attachments/assets/a6870dcb-3097-4be4-b70e-a3a932a89f7a" /> <img width="1913" height="892" alt="Screenshot 2025-07-30 at 16 06 52" src="https://github.com/user-attachments/assets/0adeb1c2-5924-4e31-949b-c6e8f0776964" /> Showing Safari as well for the Query result panel: <img width="973" height="725" alt="Screenshot 2025-07-30 at 16 08 23" src="https://github.com/user-attachments/assets/38c407c5-c6f8-46e5-8c90-661b8f26366f" /> <img width="1499" height="754" alt="Screenshot 2025-07-30 at 16 08 09" src="https://github.com/user-attachments/assets/601bd62a-94ef-417c-8e90-77f971c35e42" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227924
Summary
ES|QL Query Results Not Displaying in Safari
Fixed the EUI accordion expansion behavior that prevented the ES|QL query results from displaying in Safari browsers.
Screen.Recording.2025-07-22.at.14.08.17.mov
ES|QL Query Results Section Not Scrollable
Implemented configuration to allow content to scroll within the flyout.
Note
Instead of making each section scrollable, as there is already too much content, an alternative could be to make all the content scrollable so we are not limited by each section, especially in this case where we can have more than one section open (e.g. ES|QL Query Results and Visualization parameters).
Screen.Recording.2025-07-22.at.14.11.08.mov
Warning
This solution also affects the rest of the flyout section configurations.
Before
Screen.Recording.2025-07-22.at.14.14.10.mov
After
Screen.Recording.2025-07-22.at.14.15.46.mov
Checklist
release_note:*label is applied per the guidelinesbackport:*labels.