-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[ML] Rewrite Log rate analysis flyout to load asynchronously #229951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
olapawlus
merged 12 commits into
elastic:main
from
olapawlus:logRateAnalysisFlyoutRewrite
Aug 1, 2025
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b306180
[ML] Rewrite Log rate analysis flyout to load asynchronously
olapawlus a6099ad
refactor
olapawlus 16d2ef3
renaming the file
olapawlus ac5711a
flyout configuration to hide x button
olapawlus d4bcfe9
changes after cr
olapawlus 2477579
refactor after cr
olapawlus 2bc9849
Merge branch 'main' into logRateAnalysisFlyoutRewrite
olapawlus c3a205b
uuid bug
mbondyra 9ecbb53
some corrections
mbondyra bbcf07e
Merge pull request #1 from mbondyra/pr/229951
olapawlus f4adee2
Merge branch 'main' into logRateAnalysisFlyoutRewrite
olapawlus 4b65082
Merge branch 'main' into logRateAnalysisFlyoutRewrite
olapawlus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
...gins/shared/aiops/public/embeddables/log_rate_analysis/log_rate_analysis_config_input.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import type { AiopsPluginStartDeps } from '../../types'; | ||
| import { LogRateAnalysisEmbeddableInitializer } from './log_rate_analysis_embeddable_initializer'; | ||
| import type { LogRateAnalysisComponentApi, LogRateAnalysisEmbeddableState } from './types'; | ||
|
|
||
| export function EmbeddableLogRateAnalysisUserInput({ | ||
| pluginStart, | ||
| logRateAnalysisControlsApi, | ||
| onCancel, | ||
| onConfirm, | ||
| initialState, | ||
| isNewPanel, | ||
| }: { | ||
| pluginStart: AiopsPluginStartDeps; | ||
| logRateAnalysisControlsApi: LogRateAnalysisComponentApi; | ||
| onCancel: () => void; | ||
| onConfirm: (newUpdate: LogRateAnalysisEmbeddableState) => void; | ||
| initialState?: LogRateAnalysisEmbeddableState; | ||
| isNewPanel?: boolean; | ||
| }) { | ||
| const handlePreview = async (nextUpdate: LogRateAnalysisEmbeddableState) => { | ||
| if (logRateAnalysisControlsApi) { | ||
| logRateAnalysisControlsApi.updateUserInput(nextUpdate); | ||
| } | ||
| }; | ||
|
|
||
| return ( | ||
| <LogRateAnalysisEmbeddableInitializer | ||
olapawlus marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| dataViews={pluginStart.data.dataViews} | ||
| IndexPatternSelect={pluginStart.unifiedSearch.ui.IndexPatternSelect} | ||
| initialInput={initialState} | ||
| onCreate={onConfirm} | ||
| onCancel={onCancel} | ||
| onPreview={handlePreview} | ||
| isNewPanel={Boolean(isNewPanel)} | ||
| /> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 changes: 0 additions & 94 deletions
94
...red/aiops/public/embeddables/log_rate_analysis/resolve_log_rate_analysis_config_input.tsx
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.