[ML] Rewrite Log rate analysis flyout to load asynchronously#229951
Merged
olapawlus merged 12 commits intoelastic:mainfrom Aug 1, 2025
Merged
[ML] Rewrite Log rate analysis flyout to load asynchronously#229951olapawlus merged 12 commits intoelastic:mainfrom
olapawlus merged 12 commits intoelastic:mainfrom
Conversation
olapawlus
added
Team:Presentation
olapawlus
commented
Jul 30, 2025
...s/shared/aiops/public/embeddables/log_rate_analysis/embeddable_log_rate_analysis_factory.tsx
Show resolved
Hide resolved
olapawlus
commented
Jul 30, 2025
...shared/aiops/public/embeddables/log_rate_analysis/resolve_log_rate_analysis_config_input.tsx
Outdated
Show resolved
Hide resolved
olapawlus
force-pushed
the
logRateAnalysisFlyoutRewrite
branch
from
f5dca04 to
a6099ad
Compare
olapawlus
commented
Jul 30, 2025
...plugins/shared/aiops/public/embeddables/log_rate_analysis/log_rate_analysis_config_input.tsx
Show resolved
Hide resolved
mbondyra
reviewed
Jul 30, 2025
x-pack/platform/plugins/shared/aiops/public/ui_actions/create_log_rate_analysis_actions.tsx
Outdated
Show resolved
Hide resolved
mbondyra
reviewed
Jul 30, 2025
...plugins/shared/aiops/public/embeddables/log_rate_analysis/log_rate_analysis_config_input.tsx
Outdated
Show resolved
Hide resolved
mbondyra
reviewed
Jul 30, 2025
...shared/aiops/public/embeddables/log_rate_analysis/resolve_log_rate_analysis_config_input.tsx
Show resolved
Hide resolved
mbondyra
reviewed
Jul 30, 2025
...plugins/shared/aiops/public/embeddables/log_rate_analysis/log_rate_analysis_config_input.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
mbondyra
approved these changes
Jul 31, 2025
Contributor
mbondyra
left a comment
mbondyra
left a comment
There was a problem hiding this comment.
Tested all the cases I could think off. Code LGTM 👌🏼 great job!
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
cc @olapawlus |
szaffarano
pushed a commit
to szaffarano/kibana
that referenced
this pull request
Aug 5, 2025
…#229951) Part of elastic#227446 This PR improves the UX of opening Log rate analysis embeddable flyouts by showing the flyout immediately with a loading indicator, then loading the async content in the background. Key Changes ✅ Removed the old Promise-based flyout initialization that simulated event handling. ✅ Replaced it with the standardized openLazyFlyout() from @kbn/presentation-util. ✅ Lazy-loaded content now fetches after the flyout opens, improving perceived performance. ✅ Cleaned up onEdit and createAction handlers for simpler, more consistent logic. Why To make the flyout feel faster and smoother by avoiding delays from waiting for async content. --------- Co-authored-by: mbondyra <marta.bondyra@elastic.co>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
…#229951) Part of elastic#227446 This PR improves the UX of opening Log rate analysis embeddable flyouts by showing the flyout immediately with a loading indicator, then loading the async content in the background. Key Changes ✅ Removed the old Promise-based flyout initialization that simulated event handling. ✅ Replaced it with the standardized openLazyFlyout() from @kbn/presentation-util. ✅ Lazy-loaded content now fetches after the flyout opens, improving perceived performance. ✅ Cleaned up onEdit and createAction handlers for simpler, more consistent logic. Why To make the flyout feel faster and smoother by avoiding delays from waiting for async content. --------- Co-authored-by: mbondyra <marta.bondyra@elastic.co>
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
…#229951) Part of elastic#227446 This PR improves the UX of opening Log rate analysis embeddable flyouts by showing the flyout immediately with a loading indicator, then loading the async content in the background. Key Changes ✅ Removed the old Promise-based flyout initialization that simulated event handling. ✅ Replaced it with the standardized openLazyFlyout() from @kbn/presentation-util. ✅ Lazy-loaded content now fetches after the flyout opens, improving perceived performance. ✅ Cleaned up onEdit and createAction handlers for simpler, more consistent logic. Why To make the flyout feel faster and smoother by avoiding delays from waiting for async content. --------- Co-authored-by: mbondyra <marta.bondyra@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #227446
This PR improves the UX of opening Log rate analysis embeddable flyouts by showing the flyout immediately with a loading indicator, then loading the async content in the background.
Key Changes
✅ Removed the old Promise-based flyout initialization that simulated event handling.
✅ Replaced it with the standardized openLazyFlyout() from @kbn/presentation-util.
✅ Lazy-loaded content now fetches after the flyout opens, improving perceived performance.
✅ Cleaned up onEdit and createAction handlers for simpler, more consistent logic.
Why
To make the flyout feel faster and smoother by avoiding delays from waiting for async content.