[OneChat] Conversation Response Errors #229866

zacharyparikh · 2025-07-29T17:45:41Z

Summary

Add conversation round errors

Error details panel
Round retry button

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
Review the backport guidelines and apply applicable backport:* labels.

- Error details panel - Round retry button

zacharyparikh · 2025-07-29T17:46:21Z

@elasticmachine merge upstream

x-pack/platform/plugins/shared/onechat/public/application/hooks/use_send_message_mutation.ts

jedrazb · 2025-07-30T08:07:29Z

...ared/onechat/public/application/components/conversations/conversation_rounds/round_error.tsx

-export const RoundError: React.FC<RoundErrorProps> = ({ error }) => {
+const getStackTrace = (error: unknown) => {
+  if (error instanceof Error && typeof error.stack === 'string') {
+    return error.stack;


Aren't stack traces of bundled js basically useless? I couldn't reproduce but the most common chat error I'm getting is hitting context length window (?) with long tool calls

I see sth like this in toast:

Error: event: error data: {"error":{"code":"bad_request","message":"Received a bad request status code for request from inference entity id [.rainbow-sprinkles-elastic] status [400].

Hope the message will be included in the error details. Can we verify this somehow? (I couldn't reproduce this easily)

I tried adding throw createInternalError('oh no internal error'); in the /chat callConverse function and the message didn't get propagated

Okay yeah you're right. Error.prototype.stack is not the place we should be looking. Let me look a bit closer at the error types to see what we should be using instead here.

I think maybe the errors that are thrown on the server are not flowing through properly to the client. When I catch an error in the frontend observable it no longer has the OnechatError type. I'm looking into it now, but it seems like maybe the HTTP layer is catching and then repackaging the error as a generic Internal Server Error.

hmm I had to deal with that in #229254 and this formatter logic helped and i see you are using this. all onechat errors are instances of ServerSentEventError and the default err.message property is not populated and yeah something felt very off when working with onechat errors on client side. I'm fine to look into this as a followup

jedrazb · 2025-07-30T08:23:22Z

...platform/plugins/shared/onechat/public/application/components/conversations/conversation.tsx

+  const [message, setMessage] = useState<string>('');
+  const { sendMessage, isResponseLoading, error, pendingMessage, retry } = useSendMessageMutation();


it feels slightly off to me that message lives in component and pendingMessage lives in a hook?

I feel like those things are closely tied together, should this be a single hook perhaps?

That would be a nicer interface if other team wants to use onechat's building blocks. I have useChat in mind as an example

Yes, I agree. I plan on re-organizing this state in a follow up PR. I'll probably create a MessagesProvider which will provide the state for the current and pending messages, and a ConversationProvider which will provide the state for the current conversation.

question (maybe nitpick): does it make sense to separate those out into two providers or a single provider that represents the state of the current conversation including the messages?

Yes, you might be right. My thinking was to have separate contexts so that if there was a component that is only concerned with sending messages / messages state, they would only need to subscribe to the Messages context and not the entire Conversation context. Because when any state changes in a context, all of it's subscribers must re-render even if not subscribed to the state that changed. I think we can get around this by providing custom hooks that memoize the state though. I'll do more discovery on how we should structure soon. May also be that we only really need a MessagesProvider and that the conversation stuff doesn't really need it's own context.

jedrazb

LGTM! followup to reorganize chat hooks and improve passing error messages/bodies to client

joemcelroy · 2025-07-31T10:32:48Z

x-pack/platform/plugins/shared/onechat/public/application/hooks/use_conversation.ts

      })
    );
  };
+  const removeNewConversationQuery = () => {


it seems to keep the first conversation message in, showing a repeat

This was oddly enough caused by not having the analytics eventType registered properly. Caused a silent error to be thrown in the useMutation onError callback which caused onSettled to not be called at all. I'm registering the event type properly now.

One caveat to note here: if there is an error occurs in the first message of a conversation, it will throw away the whole conversation. This will be fixed in the follow up state management issue. I don't believe this is a regression, the production code should also behave this way.

joemcelroy · 2025-07-31T12:11:40Z

...hared/onechat/public/application/components/conversations/conversation_rounds/round_icon.tsx

+  if (isLoading) {
+    return (
+      <div css={loadingStyles}>
+        <EuiLoadingElastic size="l" aria-label={loadingLabel} />


nitpick: can use FormattedMessage here since the label is only used once?

How does that work? I thought FormattedMessage was only for things displayed to the DOM? Doesn't aria-label only accept a string and not a React Node?

aaah i didn't spot its also used in the aria-label and now makes sense why you have it as a variable. my bad. Yes your approach is fine :)

Although now that you mention it, I should i18n-ize the EuiAvatar names, right?

Yes good spot - we should be as used as a title tag.

zacharyparikh · 2025-07-31T23:10:31Z

@elasticmachine merge upstream

zacharyparikh · 2025-08-01T14:52:01Z

@elasticmachine merge upstream

elasticmachine · 2025-08-01T18:39:29Z

💚 Build Succeeded

Buildkite Build
Commit: 7dc62e1

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`onechat`	410	415	+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`onechat`	597.3KB	600.5KB	+3.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`onechat`	11.6KB	12.7KB	+1.1KB

History

💔 Build #325611 failed 74aacac
💔 Build #325366 failed 986323f
💚 Build #324739 succeeded dc68a9e
💛 Build #324479 was flaky 9cf31ab

## Summary Add conversation round errors - Error details panel - Round retry button <img width="1674" height="1476" alt="image" src="https://github.com/user-attachments/assets/802a619d-aa25-4f7a-bf70-39e6a8cda2ca" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Add conversation round errors

58d2553

- Error details panel - Round retry button

zacharyparikh requested review from jedrazb and joemcelroy July 29, 2025 17:45

zacharyparikh requested a review from a team as a code owner July 29, 2025 17:45

zacharyparikh added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Jul 29, 2025

Merge branch 'main' into conversation/response/error

9cf31ab

jedrazb reviewed Jul 30, 2025

View reviewed changes

Add converse error event type constant

dc68a9e

jedrazb approved these changes Jul 31, 2025

View reviewed changes

joemcelroy reviewed Jul 31, 2025

View reviewed changes

joemcelroy approved these changes Jul 31, 2025

View reviewed changes

zacharyparikh added 3 commits July 31, 2025 15:41

Add RoundIcon aria labels

130aa60

Disable submit when message is being sent

9038444

Register analytics event type

99db4ca

Merge branch 'main' into conversation/response/error

986323f

elasticmachine and others added 3 commits August 1, 2025 16:52

Merge branch 'main' into conversation/response/error

74aacac

Use correct useKibana import

735e38b

Increase onechat bundle size limit

7dc62e1

zacharyparikh requested a review from a team as a code owner August 1, 2025 16:51

jbudz approved these changes Aug 1, 2025

View reviewed changes

zacharyparikh merged commit adf8916 into elastic:main Aug 1, 2025
12 checks passed

kibanamachine added the v9.2.0 label Aug 1, 2025

wildemat mentioned this pull request Aug 7, 2025

pr 230826 #231022

Closed

10 tasks

		const [message, setMessage] = useState<string>('');
		const { sendMessage, isResponseLoading, error, pendingMessage, retry } = useSendMessageMutation();

[OneChat] Conversation Response Errors #229866

[OneChat] Conversation Response Errors #229866

Uh oh!

Conversation

zacharyparikh commented Jul 29, 2025

Summary

Checklist

Uh oh!

zacharyparikh commented Jul 29, 2025

Uh oh!

Uh oh!

Uh oh!

jedrazb Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jedrazb Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jedrazb left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zacharyparikh commented Jul 31, 2025

Uh oh!

zacharyparikh commented Aug 1, 2025

Uh oh!

elasticmachine commented Aug 1, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jedrazb Jul 30, 2025 •

edited

Loading

jedrazb Jul 30, 2025 •

edited

Loading