[onechat] Improve user-facing error messages in toasts #229254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/ci |
jedrazb
added
release_note:skip
Contributor
Author
|
/ci |
pgayvallet
approved these changes
Jul 24, 2025
Contributor
pgayvallet
left a comment
pgayvallet
left a comment
There was a problem hiding this comment.
LGTM once moved to the right package
x-pack/platform/packages/shared/onechat/onechat-common/base/errors.ts
Outdated
Show resolved
Hide resolved
8 tasks
added 2 commits
July 24, 2025 11:55
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Any counts in public APIs
Async chunks
History
|
Contributor
Author
|
@elasticmachine merge upstream |
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
## Summary - Add onechat-common method to extract actual error msg from the onechat error object - That impl was inspration https://github.com/elastic/kibana/blob/main/src/core/packages/fatal-errors/browser-internal/src/get_error_info.ts#L15 (but it's private + contains some cases we don't care about) - All onechat errors are instances of [ServerSentEventError](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-sse-utils/src/errors.ts#L18) and the default `err.message` property is not populated - Update toasts Verified locally that now `Bad Request` text is actually changed with the error body.message --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
8 tasks
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Jul 31, 2025
## Summary - Add onechat-common method to extract actual error msg from the onechat error object - That impl was inspration https://github.com/elastic/kibana/blob/main/src/core/packages/fatal-errors/browser-internal/src/get_error_info.ts#L15 (but it's private + contains some cases we don't care about) - All onechat errors are instances of [ServerSentEventError](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-sse-utils/src/errors.ts#L18) and the default `err.message` property is not populated - Update toasts Verified locally that now `Bad Request` text is actually changed with the error body.message --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
## Summary - Add onechat-common method to extract actual error msg from the onechat error object - That impl was inspration https://github.com/elastic/kibana/blob/main/src/core/packages/fatal-errors/browser-internal/src/get_error_info.ts#L15 (but it's private + contains some cases we don't care about) - All onechat errors are instances of [ServerSentEventError](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-sse-utils/src/errors.ts#L18) and the default `err.message` property is not populated - Update toasts Verified locally that now `Bad Request` text is actually changed with the error body.message --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
err.messageproperty is not populatedVerified locally that now
Bad Requesttext is actually changed with the error body.message