[Lens] Add embeddable transforms

packages/kbn-check-mappings-update-cli/current_fields.json

@@ -787,6 +787,7 @@
     "description",
     "state",
     "title",
+    "version",
     "visualizationType"
   ],
   "lens-ui-telemetry": [

packages/kbn-check-mappings-update-cli/current_mappings.json

@@ -2610,6 +2610,9 @@
       "title": {
         "type": "text"
       },
+      "version": {
+        "type": "integer"
+      },
       "visualizationType": {
         "type": "keyword"
       }

src/core/server/integration_tests/ci_checks/saved_objects/check_registered_types.test.ts

@@ -138,7 +138,7 @@ describe('checking migration metadata changes on all registered SO types', () =>
         "inventory-view": "e125c6e6e49729055421e7b3a0544f24330d8dc6",
         "kql-telemetry": "92d6357aa3ce28727492f86a54783f802dc38893",
         "legacy-url-alias": "9b8cca3fbb2da46fd12823d3cd38fdf1c9f24bc8",
-        "lens": "6fa6bdc5de12859815de6e50488fa2a7b038278a",
+        "lens": "17438090d0184ea2d834692aec084f7ad4ded710",
         "lens-ui-telemetry": "d6c4e330d170eefc6214dbf77a53de913fa3eebc",
         "links": "53ae5a770d69eee34d842617be761cd059ab4b51",
         "maintenance-window": "f3f19d1828e91418d13703ce6009e9c76a1686f9",
@@ -843,8 +843,9 @@ describe('checking migration metadata changes on all registered SO types', () =>
         "legacy-url-alias|8.2.0: 4c58be29493363cb48eb37fa5612fb3fb0eed77e",
         "================================================================",
         "lens|global: 0267d37678684c5f234bd74f0f6ae2a5f6180eb4",
-        "lens|mappings: ccf7f3aea93efcf8d26faffa63e4bf6f0748ea80",
+        "lens|mappings: a7f9fb8ae5efb47f6ee930168cb1cdd221cd9d91",
         "lens|schemas: da39a3ee5e6b4b0d3255bfef95601890afd80709",
+        "lens|10.1.0: 8f6fbdde199327bbfaba97d1d79ae3c9b9914b18",
         "lens|8.9.0: f6592efb2500e39d1d31b1effdfad7d7ad1eca32",
         "lens|8.6.0: 54c152a2584673672445346cf69d72bda587cc52",
         "lens|8.5.0: 54c152a2584673672445346cf69d72bda587cc52",
@@ -1304,7 +1305,7 @@ describe('checking migration metadata changes on all registered SO types', () =>
         "inventory-view": "10.2.0",
         "kql-telemetry": "10.0.0",
         "legacy-url-alias": "10.0.0",
-        "lens": "10.0.0",
+        "lens": "10.1.0",
         "lens-ui-telemetry": "10.0.0",
         "links": "10.0.0",
         "maintenance-window": "10.2.0",
@@ -1451,7 +1452,7 @@ describe('checking migration metadata changes on all registered SO types', () =>
         "inventory-view": "10.2.0",
         "kql-telemetry": "0.0.0",
         "legacy-url-alias": "8.2.0",
-        "lens": "8.9.0",
+        "lens": "10.1.0",
         "lens-ui-telemetry": "0.0.0",
         "links": "0.0.0",
         "maintenance-window": "10.2.0",

src/platform/packages/shared/kbn-config-schema/src/types/object_type.ts

@@ -227,8 +227,6 @@ export class ObjectType<P extends Props = any> extends Type<ObjectResultType<P>>
 
   /**
    * Return the schema for this object's underlying properties
-   *
-   * @internal should only be used internal for type reflection
    */
   public getPropSchemas(): P {
     return this.props;

src/platform/packages/shared/kbn-content-management-utils/index.ts

@@ -11,4 +11,3 @@ export type * from './src/types';
 export * from './src/schema';
 export * from './src/saved_object_content_storage';
 export * from './src/utils';
-export * from './src/msearch';

src/platform/packages/shared/kbn-content-management-utils/kibana.jsonc

@@ -1,5 +1,5 @@
 {
-  "type": "shared-server",
+  "type": "shared-common",
   "id": "@kbn/content-management-utils",
   "owner": [
     "@elastic/kibana-data-discovery"

src/platform/packages/shared/kbn-content-management-utils/src/saved_object_content_storage.test.ts

@@ -8,19 +8,26 @@
  */
 
 import { SOContentStorage } from './saved_object_content_storage';
-import { CMCrudTypes } from './types';
+import { ContentManagementCrudTypes } from './types';
 import { loggerMock, MockedLogger } from '@kbn/logging-mocks';
 
 import { schema } from '@kbn/config-schema';
 import type {
   ContentManagementServicesDefinition as ServicesDefinition,
   Version,
 } from '@kbn/object-versioning';
-import { getContentManagmentServicesTransforms } from '@kbn/object-versioning';
+import { getContentManagementServicesTransforms } from '@kbn/object-versioning';
 import { savedObjectSchema, objectTypeToGetResultSchema, createResultSchema } from './schema';
 
 import { coreMock } from '@kbn/core/server/mocks';
-import type { SavedObject } from '@kbn/core/server';
+import type { RequestHandlerContext, SavedObject } from '@kbn/core/server';
+import { mockRouter } from '@kbn/core-http-router-server-mocks';
+
+interface MockAttributes {
+  title: string;
+  description: string | null;
+}
+type MockCrudTypes = ContentManagementCrudTypes<'content-id', MockAttributes, {}, {}, {}>;
 
 const testAttributesSchema = schema.object(
   {
@@ -74,9 +81,9 @@ export const cmServicesDefinition: { [version: Version]: ServicesDefinition } =
   1: serviceDefinition,
 };
 
-const transforms = getContentManagmentServicesTransforms(cmServicesDefinition, 1);
+const transforms = getContentManagementServicesTransforms(cmServicesDefinition, 1);
 
-class TestSOContentStorage extends SOContentStorage<CMCrudTypes> {
+class TestSOContentStorage extends SOContentStorage<MockCrudTypes> {
   constructor({
     throwOnResultValidationError,
     logger,
@@ -94,12 +101,12 @@ class TestSOContentStorage extends SOContentStorage<CMCrudTypes> {
 
 const setup = ({ storage }: { storage?: TestSOContentStorage } = {}) => {
   storage = storage ?? new TestSOContentStorage();
+  const mockRequest = mockRouter.createFakeKibanaRequest({});
   const requestHandlerCoreContext = coreMock.createRequestHandlerContext();
-
-  const requestHandlerContext = {
+  const requestHandlerContext = jest.mocked<RequestHandlerContext>({
     core: Promise.resolve(requestHandlerCoreContext),
     resolve: jest.fn(),
-  };
+  });
 
   return {
     get: (mockSavedObject: SavedObject) => {
@@ -110,6 +117,7 @@ const setup = ({ storage }: { storage?: TestSOContentStorage } = {}) => {
 
       return storage!.get(
         {
+          request: mockRequest,
           requestHandlerContext,
           version: {
             request: 1,
@@ -122,11 +130,12 @@ const setup = ({ storage }: { storage?: TestSOContentStorage } = {}) => {
         mockSavedObject.id
       );
     },
-    create: (mockSavedObject: SavedObject<{}>) => {
+    create: (mockSavedObject: SavedObject<MockAttributes>) => {
       requestHandlerCoreContext.savedObjects.client.create.mockResolvedValue(mockSavedObject);
 
       return storage!.create(
         {
+          request: mockRequest,
           requestHandlerContext,
           version: {
             request: 1,
@@ -140,11 +149,12 @@ const setup = ({ storage }: { storage?: TestSOContentStorage } = {}) => {
         {}
       );
     },
-    update: (mockSavedObject: SavedObject<{}>) => {
+    update: (mockSavedObject: SavedObject<MockAttributes>) => {
       requestHandlerCoreContext.savedObjects.client.update.mockResolvedValue(mockSavedObject);
 
       return storage!.update(
         {
+          request: mockRequest,
           requestHandlerContext,
           version: {
             request: 1,
@@ -159,7 +169,7 @@ const setup = ({ storage }: { storage?: TestSOContentStorage } = {}) => {
         {}
       );
     },
-    search: (mockSavedObject: SavedObject<{}>) => {
+    search: (mockSavedObject: SavedObject<MockAttributes>) => {
       requestHandlerCoreContext.savedObjects.client.find.mockResolvedValue({
         saved_objects: [{ ...mockSavedObject, score: 100 }],
         total: 1,
@@ -169,6 +179,7 @@ const setup = ({ storage }: { storage?: TestSOContentStorage } = {}) => {
 
       return storage!.search(
         {
+          request: mockRequest,
           requestHandlerContext,
           version: {
             request: 1,
@@ -182,9 +193,10 @@ const setup = ({ storage }: { storage?: TestSOContentStorage } = {}) => {
         {}
       );
     },
-    mSearch: async (mockSavedObject: SavedObject<{}>) => {
+    mSearch: async (mockSavedObject: SavedObject<MockAttributes>) => {
       return storage!.mSearch!.toItemResult(
         {
+          request: mockRequest,
           requestHandlerContext,
           version: {
             request: 1,