[Lens] Add embeddable transforms#229545
Closed
nickofthyme wants to merge 72 commits intoelastic:mainfrom
Closed
Conversation
- make accessible from /common - fix reference.name schema misalignment - add `createdBy` and `updatedBy` to the SO schema - use generics on common schema functions to pass type correctly - add schema for search result
- The `getContentClientFactory` required request but never uses it. - Add `request` to `StorageContext` to pass to CM storage handlers
- This never checked if `mSearch` was available when creating the ctx. - Check for `mSearch` before adding to ctx, log server warning if missing - Add `logger` to `mSearch` factory
- We should allow transforms to run on unversioned items - These version are not targets, they are only pulled up to the first version. - allow using `kbn/object-versioning` in common.
- Vis type alias client only needs basic methods (i.e. `get` and `update`). - Create a slim `BasicVisualizationClient` - The basic client can use `cm` or `http`.
- isolates the Lens SO to CM
- update constants and use route schema - update handling of API formats in and out of CM client
- This add CM transforms to convert existing lens items to v1 - Adds version number to lens SO attributes. - Duplicates and tweaks runtime migrations for legend and color mappings.
- Refactor lens client to use new CRUD api instead of CM - Create basic lens client using CM to use new API types - Convert lens type alias client to use new basic client - Update calls to lens client dependency to `http` - Update lens doc service to use new lens client - Update lens attribute service to use updated doc service
nickofthyme
added
Team:Visualizations
- an existing SO import should not fail if no version is supplied - save old lens SO as is and handle migration when retrieved and updates.
…ns-transforms-phase-1
… src/core/server/integration_tests/ci_checks'
- Create may still be called with the old state such as saving an old lens by-value dashboard panel.
- the original attributes may have changed, or transformed. The request will always return the correct updated attributes.
…ns-transforms-phase-1
… src/core/server/integration_tests/ci_checks'
…ns-transforms-phase-1
… src/core/server/integration_tests/ci_checks'
- we don't need schemas in common only their types - using schema in common pulls in joi to the bundle - keep constants in common and import in server, public
This reverts commit fe582c0.
…ns-transforms-phase-1
Contributor
Author
|
Closed in favor of #235277 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Branched off of #229534 See nickofthyme#7 for simplified code diff.
Lens transforms Phase 2 - Lens by-value transforms for dashboard and standalone embeddables.
Adds new Lens embeddable transform. This initially only transforms current Lens Serialized state attributes with old configurations to the latest Serialized state attributes. Applying all existing runtime migrations and pins version to latest Lens item.
Additionally, this implements the embeddable transforms on the embeddable renderer to handle standalone usages of the Lens embeddable, an extension of the work done in #227141.
Closes #229543
Checklist
release_note:breakinglabel should be applied in these situations.