Skip to content

[ska] relocate a11y tests #229371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmlemeshko merged 12 commits into from
Jul 28, 2025
Merged

[ska] relocate a11y tests #229371

dmlemeshko merged 12 commits into from
Jul 28, 2025

Conversation

@dmlemeshko
Copy link
Contributor

@dmlemeshko dmlemeshko commented Jul 24, 2025 •
edited by kibanamachine
Loading

Summary

Part of https://github.com/elastic/kibana-team/issues/1503

This PR is mostly about moving FTR a11y tests from x-pack/test

Before

x-pack/test/accessibility

After:

x-pack/platform/test/accessibility

x-pack/solutions/search/test/accessibility
  |-apps/enterprise_search.ts

x-pack/solutions/security/test/accessibility
  |-apps/security_solution.ts

@dmlemeshko dmlemeshko self-assigned this Jul 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025 •
edited
Loading

🔍 Preview links for changed docs

@dmlemeshko dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.2.0 v9.1.1 v8.19.1 labels Jul 25, 2025
@dmlemeshko dmlemeshko marked this pull request as ready for review July 25, 2025 13:01
@dmlemeshko dmlemeshko requested review from a team as code owners July 25, 2025 13:01
azasypkin
azasypkin approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppEx Security related changes LGTM.

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 28, 2025

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @dmlemeshko

@dmlemeshko dmlemeshko enabled auto-merge (squash) July 28, 2025 09:04
maximpn
maximpn approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving FTR tests LGTM

@dmlemeshko dmlemeshko merged commit 92c5cca into elastic:main Jul 28, 2025
13 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 28, 2025

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16565289603

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 28, 2025

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts
❌ 9.1 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 229371

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Jul 29, 2025
Merged
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Jul 30, 2025
@dmlemeshko
[ska] relocate a11y tests (elastic#229371)
0e9ab42 
## Summary

Part of elastic/kibana-team#1503

This PR is mostly about moving  FTR a11y tests from x-pack/test

Before
```
x-pack/test/accessibility
```

After:
```
x-pack/platform/test/accessibility

x-pack/solutions/search/test/accessibility
  |-apps/enterprise_search.ts

x-pack/solutions/security/test/accessibility
  |-apps/security_solution.ts
```

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 92c5cca)

# Conflicts:
#	.github/CODEOWNERS
@dmlemeshko dmlemeshko mentioned this pull request Jul 30, 2025
Merged
@dmlemeshko
Copy link
Contributor Author

dmlemeshko commented Jul 30, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 30, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 30, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @dmlemeshko

dmlemeshko added a commit that referenced this pull request Jul 30, 2025
@dmlemeshko
[9.1] [ska] relocate a11y tests (#229371) (#229920)
f36c8b2 
# Backport

This will backport the following commits from `main` to `9.1`:
- [[ska] relocate a11y tests
(#229371)](#229371)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-07-28T09:24:13Z","message":"[ska]
relocate a11y tests (#229371)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving FTR a11y tests from
x-pack/test\n\nBefore\n```\nx-pack/test/accessibility\n```\n\nAfter:
\n```\nx-pack/platform/test/accessibility\n\nx-pack/solutions/search/test/accessibility\n
|-apps/enterprise_search.ts\n\nx-pack/solutions/security/test/accessibility\n
|-apps/security_solution.ts\n```\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"92c5cca6fd77e9883802c9eaa1f29206a4f2b9a2","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.2.0","v9.1.1","v8.19.1"],"title":"[ska]
relocate a11y
tests","number":229371,"url":"https://github.com/elastic/kibana/pull/229371","mergeCommit":{"message":"[ska]
relocate a11y tests (#229371)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving FTR a11y tests from
x-pack/test\n\nBefore\n```\nx-pack/test/accessibility\n```\n\nAfter:
\n```\nx-pack/platform/test/accessibility\n\nx-pack/solutions/search/test/accessibility\n
|-apps/enterprise_search.ts\n\nx-pack/solutions/security/test/accessibility\n
|-apps/security_solution.ts\n```\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"92c5cca6fd77e9883802c9eaa1f29206a4f2b9a2"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229371","number":229371,"mergeCommit":{"message":"[ska]
relocate a11y tests (#229371)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving FTR a11y tests from
x-pack/test\n\nBefore\n```\nx-pack/test/accessibility\n```\n\nAfter:
\n```\nx-pack/platform/test/accessibility\n\nx-pack/solutions/search/test/accessibility\n
|-apps/enterprise_search.ts\n\nx-pack/solutions/security/test/accessibility\n
|-apps/security_solution.ts\n```\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"92c5cca6fd77e9883802c9eaa1f29206a4f2b9a2"}},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 30, 2025
This was referenced Jul 30, 2025
Merged
Merged
Merged
delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
@dmlemeshko @kibanamachine @delanni
[ska] relocate a11y tests (elastic#229371)
7b4abc0 
## Summary

Part of elastic/kibana-team#1503

This PR is mostly about moving  FTR a11y tests from x-pack/test

Before
```
x-pack/test/accessibility
```

After: 
```
x-pack/platform/test/accessibility

x-pack/solutions/search/test/accessibility
  |-apps/enterprise_search.ts

x-pack/solutions/security/test/accessibility
  |-apps/security_solution.ts
```

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Aug 7, 2025
@dmlemeshko
[ska] relocate a11y tests (elastic#229371)
175b72f 
## Summary

Part of elastic/kibana-team#1503

This PR is mostly about moving  FTR a11y tests from x-pack/test

Before
```
x-pack/test/accessibility
```

After:
```
x-pack/platform/test/accessibility

x-pack/solutions/search/test/accessibility
  |-apps/enterprise_search.ts

x-pack/solutions/security/test/accessibility
  |-apps/security_solution.ts
```

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 92c5cca)

# Conflicts:
#	.github/CODEOWNERS
#	docs/extend/development-tests.md
#	docs/extend/interpreting-ci-failures.md
#	x-pack/platform/plugins/private/transform/README.md
#	x-pack/test/tsconfig.json
@dmlemeshko dmlemeshko mentioned this pull request Aug 7, 2025
Merged
@dmlemeshko
Copy link
Contributor Author

dmlemeshko commented Aug 7, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Aug 7, 2025
Merged
dmlemeshko added a commit that referenced this pull request Aug 7, 2025
@dmlemeshko @kibanamachine
[8.19] [ska] relocate a11y tests (#229371) (#230996)
845503f 
# Backport

This will backport the following commits from `main` to `8.19`:
- [[ska] relocate a11y tests
(#229371)](#229371)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-07-28T09:24:13Z","message":"[ska]
relocate a11y tests (#229371)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving FTR a11y tests from
x-pack/test\n\nBefore\n```\nx-pack/test/accessibility\n```\n\nAfter:
\n```\nx-pack/platform/test/accessibility\n\nx-pack/solutions/search/test/accessibility\n
|-apps/enterprise_search.ts\n\nx-pack/solutions/security/test/accessibility\n
|-apps/security_solution.ts\n```\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"92c5cca6fd77e9883802c9eaa1f29206a4f2b9a2","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.2.0","v9.1.1","v8.19.1"],"title":"[ska]
relocate a11y
tests","number":229371,"url":"https://github.com/elastic/kibana/pull/229371","mergeCommit":{"message":"[ska]
relocate a11y tests (#229371)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving FTR a11y tests from
x-pack/test\n\nBefore\n```\nx-pack/test/accessibility\n```\n\nAfter:
\n```\nx-pack/platform/test/accessibility\n\nx-pack/solutions/search/test/accessibility\n
|-apps/enterprise_search.ts\n\nx-pack/solutions/security/test/accessibility\n
|-apps/security_solution.ts\n```\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"92c5cca6fd77e9883802c9eaa1f29206a4f2b9a2"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229371","number":229371,"mergeCommit":{"message":"[ska]
relocate a11y tests (#229371)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving FTR a11y tests from
x-pack/test\n\nBefore\n```\nx-pack/test/accessibility\n```\n\nAfter:
\n```\nx-pack/platform/test/accessibility\n\nx-pack/solutions/search/test/accessibility\n
|-apps/enterprise_search.ts\n\nx-pack/solutions/security/test/accessibility\n
|-apps/security_solution.ts\n```\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"92c5cca6fd77e9883802c9eaa1f29206a4f2b9a2"}},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/229920","number":229920,"state":"MERGED","mergeCommit":{"sha":"f36c8b20dc7fbc6eb991c5b1678f529e0af6fd13","message":"[9.1]
[ska] relocate a11y tests (#229371) (#229920)\n\n# Backport\n\nThis will
backport the following commits from `main` to `9.1`:\n- [[ska] relocate
a11y
tests\n(#229371)](https://github.com/elastic/kibana/pull/229371)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n"}},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@consulthys consulthys consulthys approved these changes

@jughosta jughosta jughosta approved these changes

@adcoelho adcoelho adcoelho approved these changes

@azasypkin azasypkin azasypkin approved these changes

@pheyos pheyos pheyos approved these changes

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey approved these changes

@jbudz jbudz jbudz approved these changes

@maximpn maximpn maximpn approved these changes

@mbondyra mbondyra mbondyra approved these changes

@bhavyarm bhavyarm bhavyarm approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

@rbrtj rbrtj rbrtj approved these changes

Assignees

@dmlemeshko dmlemeshko

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.19.1 v9.1.1 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.