Skip to content

[TSVB] Serialise the actual vis on clone #227882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markov00 merged 5 commits into from
Jul 18, 2025
Merged

[TSVB] Serialise the actual vis on clone #227882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
11b4c30
serialise the actual vis
markov00 Jul 14, 2025
f58b64e
add functional test
markov00 Jul 14, 2025
5e92f97
[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…
kibanamachine Jul 14, 2025
cab8f5f
reset dashboard
markov00 Jul 15, 2025
8e38c59
Merge branch 'main' into 2025_07_14-fix_clone_TSVB_panel
markov00 Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/platform/plugins/shared/visualizations/public/embeddable/visualize_embeddable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export const getVisualizeEmbeddableFactory: (deps: {
linkedToLibraryArg: boolean
) => {
return serializeState({
serializedVis: serializedVis$.value,
serializedVis: vis$.getValue().serialize(),
titles: titleManager.getLatestState(),
id: savedObjectId,
linkedToLibrary: linkedToLibraryArg,
Expand Down
42 changes: 35 additions & 7 deletions src/platform/test/functional/apps/visualize/group3/_add_to_dashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,15 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const listingTable = getService('listingTable');

const { common, dashboard, visualize, timePicker, timeToVisualize } = getPageObjects([
'common',
'dashboard',
'visualize',
'timePicker',
'timeToVisualize',
]);
const { common, dashboard, visualize, timePicker, timeToVisualize, visualBuilder } =
getPageObjects([
'common',
'dashboard',
'visualize',
'timePicker',
'timeToVisualize',
'visualBuilder',
]);

describe('Add to Dashboard', function describeIndexTests() {
before(async () => {
Expand All @@ -33,6 +35,32 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
after(async () => {
await common.unsetTime();
});

it('add a TSVB to a new dashboard by ref and clone the panel', async () => {
await visualize.gotoVisualizationLandingPage();
await visualize.navigateToNewVisualization();
await visualize.clickVisualBuilder();
await visualBuilder.checkVisualBuilderIsPresent();
await visualBuilder.clickMetric();
await visualBuilder.checkMetricTabIsPresent();
await visualBuilder.clickPanelOptions('metric');
await visualBuilder.setIndexPatternValue('long-window-logstash-*', true);
const value = await visualBuilder.getMetricValue();
expect(value).to.eql('35');
await testSubjects.click('visualizeSaveButton');
await timeToVisualize.saveFromModal('TSVB count', {
addToDashboard: 'new',
saveToLibrary: true,
});
await dashboard.waitForRenderComplete();
await dashboardExpect.tsvbMetricValuesExist(['35']);
await dashboardPanelActions.openContextMenuByTitle('TSVB count');
await testSubjects.click('embeddablePanelAction-clonePanel');
await dashboard.waitForRenderComplete();
await dashboardExpect.tsvbMetricValuesExist(['35', '35']);
await timeToVisualize.resetNewDashboard();
});

it('adding a new metric to a new dashboard by value', async function () {
await visualize.navigateToNewAggBasedVisualization();
await visualize.clickMetric();
Expand Down