[TSVB] Serialise the actual vis on clone#227882
Merged
markov00 merged 5 commits intoelastic:mainfrom Jul 18, 2025
Merged
Conversation
markov00
added
bug
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
markov00
requested review from
ThomThomson and
nreese
and removed request for
nreese
Contributor
|
I was testing locally and although the clone part is working as expected, when I change the cloned chart dataview and then I refresh, it looks like it is not saved. Screen.Recording.2025-07-15.at.15.14.08.mov |
Contributor
Author
|
@mariairiartef I've created an issue specific for that #228203 |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
Contributor
|
this also fixes #226970 |
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16365636650 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 18, 2025
## Summary The issue was a regression caused by elastic#215947 where the wrong serialized state was used when cloning the panel fix elastic#227831 fixes elastic#226970 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 120bb3d)
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 18, 2025
## Summary The issue was a regression caused by elastic#215947 where the wrong serialized state was used when cloning the panel fix elastic#227831 fixes elastic#226970 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 120bb3d)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 18, 2025
# Backport This will backport the following commits from `main` to `9.1`: - [[TSVB] Serialise the actual vis on clone (#227882)](#227882) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"marco.vettorello@elastic.co"},"sourceCommit":{"committedDate":"2025-07-18T08:11:33Z","message":"[TSVB] Serialise the actual vis on clone (#227882)\n\n## Summary\n\nThe issue was a regression caused by\nhttps://github.com//pull/215947 where the wrong serialized\nstate was used when cloning the panel\n\nfix https://github.com/elastic/kibana/issues/227831\nfixes https://github.com/elastic/kibana/issues/226970\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"120bb3d18ecf32769baaf6c38e70772fa2cffeaa","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Visualizations","release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[TSVB] Serialise the actual vis on clone","number":227882,"url":"https://github.com/elastic/kibana/pull/227882","mergeCommit":{"message":"[TSVB] Serialise the actual vis on clone (#227882)\n\n## Summary\n\nThe issue was a regression caused by\nhttps://github.com//pull/215947 where the wrong serialized\nstate was used when cloning the panel\n\nfix https://github.com/elastic/kibana/issues/227831\nfixes https://github.com/elastic/kibana/issues/226970\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"120bb3d18ecf32769baaf6c38e70772fa2cffeaa"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227882","number":227882,"mergeCommit":{"message":"[TSVB] Serialise the actual vis on clone (#227882)\n\n## Summary\n\nThe issue was a regression caused by\nhttps://github.com//pull/215947 where the wrong serialized\nstate was used when cloning the panel\n\nfix https://github.com/elastic/kibana/issues/227831\nfixes https://github.com/elastic/kibana/issues/226970\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"120bb3d18ecf32769baaf6c38e70772fa2cffeaa"}}]}] BACKPORT--> Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jul 18, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[TSVB] Serialise the actual vis on clone (#227882)](#227882) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"marco.vettorello@elastic.co"},"sourceCommit":{"committedDate":"2025-07-18T08:11:33Z","message":"[TSVB] Serialise the actual vis on clone (#227882)\n\n## Summary\n\nThe issue was a regression caused by\nhttps://github.com//pull/215947 where the wrong serialized\nstate was used when cloning the panel\n\nfix https://github.com/elastic/kibana/issues/227831\nfixes https://github.com/elastic/kibana/issues/226970\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"120bb3d18ecf32769baaf6c38e70772fa2cffeaa","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Visualizations","release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[TSVB] Serialise the actual vis on clone","number":227882,"url":"https://github.com/elastic/kibana/pull/227882","mergeCommit":{"message":"[TSVB] Serialise the actual vis on clone (#227882)\n\n## Summary\n\nThe issue was a regression caused by\nhttps://github.com//pull/215947 where the wrong serialized\nstate was used when cloning the panel\n\nfix https://github.com/elastic/kibana/issues/227831\nfixes https://github.com/elastic/kibana/issues/226970\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"120bb3d18ecf32769baaf6c38e70772fa2cffeaa"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227882","number":227882,"mergeCommit":{"message":"[TSVB] Serialise the actual vis on clone (#227882)\n\n## Summary\n\nThe issue was a regression caused by\nhttps://github.com//pull/215947 where the wrong serialized\nstate was used when cloning the panel\n\nfix https://github.com/elastic/kibana/issues/227831\nfixes https://github.com/elastic/kibana/issues/226970\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"120bb3d18ecf32769baaf6c38e70772fa2cffeaa"}}]}] BACKPORT--> Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
Bluefinger
pushed a commit
to Bluefinger/kibana
that referenced
this pull request
Jul 22, 2025
## Summary The issue was a regression caused by elastic#215947 where the wrong serialized state was used when cloning the panel fix elastic#227831 fixes elastic#226970 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
## Summary The issue was a regression caused by elastic#215947 where the wrong serialized state was used when cloning the panel fix elastic#227831 fixes elastic#226970 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The issue was a regression caused by #215947 where the wrong serialized state was used when cloning the panel
fix #227831
fixes #226970