Skip to content

[Cloud Security] Mark internal cloud_security_posture ingest pipelines as managed#227684

Closed
zk2k2 wants to merge 5 commits intoelastic:mainfrom
zk2k2:bugfix/226696-mark-cloud-security-pipelines-managed
Closed

[Cloud Security] Mark internal cloud_security_posture ingest pipelines as managed#227684
zk2k2 wants to merge 5 commits intoelastic:mainfrom
zk2k2:bugfix/226696-mark-cloud-security-pipelines-managed

Conversation

@zk2k2
Copy link
Contributor

@zk2k2 zk2k2 commented Jul 11, 2025

Summary

Fixes:

This PR fixes a bug where internal ingest pipelines used by the cloud_security_posture plugin were not marked as managed.
By adding the _meta.managed: true field to these pipelines, they will now be correctly recognized as managed pipelines by Elasticsearch and Kibana.

This prevents accidental user modifications and aligns with other Elastic-managed pipelines.


Checklist

  • Follows EUI writing guidelines and includes i18n support where applicable
  • Documentation updated as needed
  • Unit or functional tests updated or added
  • Checked for breaking HTTP API changes
  • Flaky Test Runner used on tests changed
  • Release Notes section included and appropriate label applied

Identify risks

This change only adds metadata to existing ingest pipeline definitions and does not affect pipeline logic or data processing.
Risk of regressions or data loss is minimal. The change improves system stability by marking pipelines as managed.


 cloud_security_posture ingest pipelines so they
are correctly marked as managed, fixing
issue elastic#226696.
@zk2k2 zk2k2 requested a review from a team as a code owner July 11, 2025 15:32
@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
bddde25

Please, read and sign the above mentioned agreement if you want to contribute to this project

@opauloh opauloh added release_note:fix backport:skip This PR does not require backporting Team:Cloud Security Cloud Security team related v9.2.0 labels Jul 11, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@opauloh
Copy link
Contributor

opauloh commented Jul 11, 2025

cc @CohenIdo can you review it?

@zk2k2
Copy link
Contributor Author

zk2k2 commented Jul 11, 2025

Just commenting so that the CLA checks works

@opauloh
Copy link
Contributor

opauloh commented Jul 11, 2025

/ci

@opauloh
Copy link
Contributor

opauloh commented Jul 11, 2025

@elasticmachine run docs-build

Copy link
Contributor

@CohenIdo CohenIdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcold
Copy link
Contributor

maxcold commented Jul 24, 2025

@zk2k2 I think you need to actually online sign the CA agreement so we could merge

@opauloh
Copy link
Contributor

opauloh commented Jul 24, 2025

/ci

@zk2k2
Copy link
Contributor Author

zk2k2 commented Jul 24, 2025

@maxcold I signed the CLA multiple times I don't know why it's not picking up on it

@maxcold
Copy link
Contributor

maxcold commented Jul 24, 2025

@zk2k2 weird, haven't had a case like that before. Did you use the same email zied.kharrat@insat.ucar as you used for the commit authoring?

@opauloh
Copy link
Contributor

opauloh commented Jul 24, 2025

/ci

@maxcold
Copy link
Contributor

maxcold commented Jul 28, 2025

@elasticmachine run docs-build

@opauloh
Copy link
Contributor

opauloh commented Jul 29, 2025

/ci

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@opauloh opauloh closed this Jul 30, 2025
@opauloh opauloh reopened this Jul 30, 2025
@maxcold
Copy link
Contributor

maxcold commented Jul 31, 2025

@zk2k2 sorry for the ping but we would like to merge this PR and can't without CLA check passing. Can you check if you signed the agreement with the same email you did commits? It's zied.kharrat@insat.ucar . If you did indeed sign with the same email, I will bring it up internally with relevant team

@zk2k2
Copy link
Contributor Author

zk2k2 commented Jul 31, 2025

Hi @maxcold , I am pretty sure I signed the CLA with the following email zied.kharrat@insat.ucar.tn, I also tried signing it with my other GitHub emails. If this helps, I have successfully signed the CLA for another PR to another issue #227619, pretty sure it was using zied.kharrat@insat.ucar.tn, let me know if I can help any other way

@maxcold
Copy link
Contributor

maxcold commented Jul 31, 2025

@zk2k2 yeah, I think the issue is that the commit was created with email zied.kharrat@insat.ucar which is missing .tn in the end. You can see that in the list of commits, your user is not being linked properly to the commit (there is no link to https://github.com/zk2k2) .

Anyway, the simplest way to fix it, I think, is to recreate this PR, making sure the commit is made with email zied.kharrat@insat.ucar.tn, and then you should be able to sign CLA
Another option is to try to change the commit in this branch and amend the email, but it might get messy
Or if you don't want to spend time on that, I can recreate the PR from my name with your change, but I don't want to steal your thunder :)

@zk2k2
Copy link
Contributor Author

zk2k2 commented Jul 31, 2025

@maxcold Oh I see, my bad! I will recreate the PR ASAP :) thanks for pointing it out!

@zk2k2
Copy link
Contributor Author

zk2k2 commented Jul 31, 2025

HI @maxcold, i've submitted a new PR #230106 and CLA check works this time, thanks for your patience and help :)!

@maxcold
Copy link
Contributor

maxcold commented Aug 1, 2025

@zk2k2 thanks! closing this PR then

@maxcold maxcold closed this Aug 1, 2025
maxcold pushed a commit that referenced this pull request Aug 4, 2025
## Summary

Note: This PR replaces PR #227684
to fix a CLA issue (commit was made under the wrong e-mail)

Fixes: 
- #226696

This PR fixes a bug where internal ingest pipelines used by the
cloud_security_posture plugin were not marked as managed.
By adding the `_meta.managed: true` field to these pipelines, they will
now be correctly recognized as managed pipelines by Elasticsearch and
Kibana.

This prevents accidental user modifications and aligns with other
Elastic-managed pipelines.

---

### Checklist

- [x] Follows EUI writing guidelines and includes i18n support where
applicable
- [ ] Documentation updated as needed  
- [ ] Unit or functional tests updated or added  
- [ ] Checked for breaking HTTP API changes  
- [ ] Flaky Test Runner used on tests changed  
- [ ] Release Notes section included and appropriate label applied  

---

### Identify risks

This change only adds metadata to existing ingest pipeline definitions
and does not affect pipeline logic or data processing.
Risk of regressions or data loss is minimal. The change improves system
stability by marking pipelines as managed.

---

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
szaffarano pushed a commit to szaffarano/kibana that referenced this pull request Aug 5, 2025
## Summary

Note: This PR replaces PR elastic#227684
to fix a CLA issue (commit was made under the wrong e-mail)

Fixes: 
- elastic#226696

This PR fixes a bug where internal ingest pipelines used by the
cloud_security_posture plugin were not marked as managed.
By adding the `_meta.managed: true` field to these pipelines, they will
now be correctly recognized as managed pipelines by Elasticsearch and
Kibana.

This prevents accidental user modifications and aligns with other
Elastic-managed pipelines.

---

### Checklist

- [x] Follows EUI writing guidelines and includes i18n support where
applicable
- [ ] Documentation updated as needed  
- [ ] Unit or functional tests updated or added  
- [ ] Checked for breaking HTTP API changes  
- [ ] Flaky Test Runner used on tests changed  
- [ ] Release Notes section included and appropriate label applied  

---

### Identify risks

This change only adds metadata to existing ingest pipeline definitions
and does not affect pipeline logic or data processing.
Risk of regressions or data loss is minimal. The change improves system
stability by marking pipelines as managed.

---

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
## Summary

Note: This PR replaces PR elastic#227684
to fix a CLA issue (commit was made under the wrong e-mail)

Fixes: 
- elastic#226696

This PR fixes a bug where internal ingest pipelines used by the
cloud_security_posture plugin were not marked as managed.
By adding the `_meta.managed: true` field to these pipelines, they will
now be correctly recognized as managed pipelines by Elasticsearch and
Kibana.

This prevents accidental user modifications and aligns with other
Elastic-managed pipelines.

---

### Checklist

- [x] Follows EUI writing guidelines and includes i18n support where
applicable
- [ ] Documentation updated as needed  
- [ ] Unit or functional tests updated or added  
- [ ] Checked for breaking HTTP API changes  
- [ ] Flaky Test Runner used on tests changed  
- [ ] Release Notes section included and appropriate label applied  

---

### Identify risks

This change only adds metadata to existing ingest pipeline definitions
and does not affect pipeline logic or data processing.
Risk of regressions or data loss is minimal. The change improves system
stability by marking pipelines as managed.

---

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
## Summary

Note: This PR replaces PR elastic#227684
to fix a CLA issue (commit was made under the wrong e-mail)

Fixes: 
- elastic#226696

This PR fixes a bug where internal ingest pipelines used by the
cloud_security_posture plugin were not marked as managed.
By adding the `_meta.managed: true` field to these pipelines, they will
now be correctly recognized as managed pipelines by Elasticsearch and
Kibana.

This prevents accidental user modifications and aligns with other
Elastic-managed pipelines.

---

### Checklist

- [x] Follows EUI writing guidelines and includes i18n support where
applicable
- [ ] Documentation updated as needed  
- [ ] Unit or functional tests updated or added  
- [ ] Checked for breaking HTTP API changes  
- [ ] Flaky Test Runner used on tests changed  
- [ ] Release Notes section included and appropriate label applied  

---

### Identify risks

This change only adds metadata to existing ingest pipeline definitions
and does not affect pipeline logic or data processing.
Risk of regressions or data loss is minimal. The change improves system
stability by marking pipelines as managed.

---

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting 💝community release_note:fix Team:Cloud Security Cloud Security team related v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants