[CSP] Show loading indicator in misconfigurations flyout table#227619
Merged
opauloh merged 5 commits intoelastic:mainfrom Jul 28, 2025
Merged
[CSP] Show loading indicator in misconfigurations flyout table#227619opauloh merged 5 commits intoelastic:mainfrom
opauloh merged 5 commits intoelastic:mainfrom
Conversation
Currently, when expanding the misconfigurations flyout, the table shows a "No items found" message while data is loading. This change adds the `loading` prop to the `<EuiBasicTable>` to properly display a loading spinner during the data fetch. Fixes: Issue elastic#226694
|
💚 CLA has been signed |
opauloh
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
Contributor
|
Thanks for your PR @zk2k2, can you sign the Contributor agreement? |
Contributor
Author
|
@opauloh I signed it twice and it didn't register for some reason, any idea why? Edit: Nevermind I had to comment for it to register, all good now! |
Contributor
|
/ci |
Contributor
|
@elasticmachine run docs-build |
Contributor
|
Thanks for signing the CLA, I am running the CI and the code will be merged once it passes! |
Contributor
|
/ci |
2 similar comments
Contributor
|
/ci |
Contributor
|
/ci |
Contributor
|
/ci |
Contributor
|
/ci |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
@elasticmachine run docs-build |
Contributor
|
Hi @zk2k2 , your PR was successfully merged! Thanks for your contribution in Kibana! |
Contributor
Author
|
@opauloh Thanks! Glad to have helped :) |
6 tasks
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
…ic#227619) ## [CSP] Show loading indicator in misconfigurations flyout table **Fixes:** Issue elastic#226694 --- ### Summary When expanding the misconfigurations flyout in Host Details, the `<EuiBasicTable>` immediately shows “No items found” while the query is in flight. This PR adds the `loading={isLoading}` prop so that the table’s built-in spinner displays during data fetch, then renders rows once available. --- ### Checklist - [x] Any text added follows [EUI’s writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case, and includes i18n support - [ ] Documentation was added or updated (n/a; no new public API or user-facing docs) - [ ] Unit or functional tests were updated or added to cover the loading state - [ ] If a plugin configuration key changed, verify allowlist/cloud/docker entries (n/a) - [ ] Checked for breaking HTTP API changes (none) - [ ] Flaky Test Runner was used on any modified tests - [ ] Release note label applied: `release_note:non-issue` --- ### Identify risks - **Risk:** Very low. Only the existing `<EuiBasicTable>` gained a `loading` prop. - **Mitigation:** Manual smoke test confirms spinner appears on flyout expand and table renders correctly once data arrives. - No performance regression expected, as React-Query’s `isLoading` is already tracked, and EUI’s overlay is lightweight. ### Release Note Fixed a misleading "No items found" message in the misconfiguration flyout by displaying a loading spinner while data is being fetched. release_note:fix backport:skip --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Paulo Silva <paulo.henrique@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[CSP] Show loading indicator in misconfigurations flyout table
Fixes: Issue #226694
Summary
When expanding the misconfigurations flyout in Host Details, the
<EuiBasicTable>immediately shows “No items found” while the query is in flight.This PR adds the
loading={isLoading}prop so that the table’s built-in spinner displays during data fetch, then renders rows once available.Checklist
release_note:non-issueIdentify risks
<EuiBasicTable>gained aloadingprop.isLoadingis already tracked, and EUI’s overlay is lightweight.Release Note
Fixed a misleading "No items found" message in the misconfiguration flyout by displaying a loading spinner while data is being fetched.
release_note:fix
backport:skip