[9.0] [Dashboard][Controls] Do not recommend adhoc dataviews (#225705)

src/platform/packages/shared/presentation/presentation_publishing/interfaces/publishes_data_views.ts

@@ -10,6 +10,10 @@
 import { DataView } from '@kbn/data-views-plugin/common';
 import { PublishingSubject } from '../publishing_subject';
 
+/**
+ * This API publishes a list of data views that it uses. Note that this should not contain any
+ * ad-hoc data views.
+ */
 export interface PublishesDataViews {
   dataViews$: PublishingSubject<DataView[] | undefined>;
 }

src/platform/plugins/shared/controls/public/controls/data_controls/options_list_control/get_options_list_control_factory.tsx

@@ -189,7 +189,7 @@ export const getOptionsListControlFactory = (): DataControlFactory<
         stateManager,
         controlFetch$: (onReload: () => void) => controlGroupApi.controlFetch$(uuid, onReload),
       }).subscribe((result) => {
-        // if there was an error during fetch, set blocking error and return early
+        // if there was an error during fetch, set suggestion load error and return early
         if (Object.hasOwn(result, 'error')) {
           dataControl.api.setBlockingError((result as { error: Error }).error);
           return;

src/platform/plugins/shared/dashboard/public/dashboard_api/data_views_manager.ts

@@ -43,7 +43,10 @@ export function initializeDataViewsManager(
   const dataViewsSubscription = combineLatest([controlGroupDataViewsPipe, childDataViewsPipe])
     .pipe(
       switchMap(async ([controlGroupDataViews, childDataViews]) => {
-        const allDataViews = [...(controlGroupDataViews ?? []), ...childDataViews];
+        const allDataViews = [...(controlGroupDataViews ?? []), ...childDataViews].filter(
+          (dataView) => dataView.isPersisted()
+        );
+
         if (allDataViews.length === 0) {
           try {
             const defaultDataView = await dataService.dataViews.getDefaultDataView();

src/platform/plugins/shared/data_views/common/data_views/abstract_data_views.ts

@@ -235,6 +235,9 @@ export abstract class AbstractDataView {
     this.originalSavedObjectBody = this.getAsSavedObjectBody();
   };
 
+  /**
+   * Returns true if the data view is persisted, and false if the dataview is adhoc.
+   */
   isPersisted() {
     return typeof this.version === 'string';
   }