Skip to content

[8.19] [Search][Query Rules UI] FTR tests (#223553)#226384

Merged
efegurkan merged 1 commit intoelastic:8.19from
efegurkan:backport/8.19/pr-223553
Jul 3, 2025
Merged

[8.19] [Search][Query Rules UI] FTR tests (#223553)#226384
efegurkan merged 1 commit intoelastic:8.19from
efegurkan:backport/8.19/pr-223553

Conversation

@efegurkan
Copy link
Member

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

## Summary

Make sure FTR tests cover a few happy paths.

- Creating a query ruleset from an empty deployment
- Adding a new ruleset in a non-empty deployment
- Deleting a query ruleset from the ruleset details page
- Deleting a query ruleset from the rulesets management page
- Editing a query ruleset, changing the document ID for the first
document, and changing the first metadata field value

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Efe Gürkan YALAMAN <efeguerkan.yalaman@elastic.co>
(cherry picked from commit 308ba8f)

# Conflicts:
#	x-pack/test_serverless/functional/test_suites/search/config.feature_flags.ts
#	x-pack/test_serverless/functional/test_suites/search/index.feature_flags.ts
@efegurkan efegurkan requested a review from kibanamachine as a code owner July 3, 2025 10:42
@efegurkan efegurkan added the backport This PR is a backport of another PR label Jul 3, 2025
@efegurkan efegurkan enabled auto-merge (squash) July 3, 2025 10:42
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:rubber-stamp:

@efegurkan efegurkan merged commit f82f3da into elastic:8.19 Jul 3, 2025
11 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchQueryRules 128.9KB 129.1KB +252.0B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants