-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Security Assistant] Responsive design for welcome screen #226062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
stephmilovic
merged 5 commits into
elastic:main
from
stephmilovic:response_welcome_screen
Jul 2, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
...hared/kbn-elastic-assistant/impl/assistant/assistant_body/use_vertical_breakpoint.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { act, renderHook } from '@testing-library/react'; | ||
| import { useVerticalBreakpoint } from './use_vertical_breakpoint'; | ||
|
|
||
| describe('useVerticalBreakpoint', () => { | ||
| beforeEach(() => { | ||
| jest.useFakeTimers(); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| jest.useRealTimers(); | ||
| }); | ||
|
|
||
| function setWindowHeight(height: number) { | ||
| Object.defineProperty(window, 'innerHeight', { | ||
| writable: true, | ||
| configurable: true, | ||
| value: height, | ||
| }); | ||
| window.dispatchEvent(new Event('resize')); | ||
| } | ||
|
|
||
| it('returns "short" for height < 600', () => { | ||
| setWindowHeight(500); | ||
| const { result } = renderHook(() => useVerticalBreakpoint()); | ||
| expect(result.current).toBe('short'); | ||
| }); | ||
|
|
||
| it('returns "medium" for 600 <= height < 1100', () => { | ||
| setWindowHeight(800); | ||
| const { result } = renderHook(() => useVerticalBreakpoint()); | ||
| expect(result.current).toBe('medium'); | ||
| }); | ||
|
|
||
| it('returns "tall" for height >= 1100', () => { | ||
| setWindowHeight(1200); | ||
| const { result } = renderHook(() => useVerticalBreakpoint()); | ||
| expect(result.current).toBe('tall'); | ||
| }); | ||
|
|
||
| it('updates value on window resize once debounced', () => { | ||
| setWindowHeight(1200); | ||
| const { result } = renderHook(() => useVerticalBreakpoint()); | ||
| expect(result.current).toBe('tall'); | ||
| setWindowHeight(500); | ||
| expect(result.current).toBe('tall'); | ||
| act(() => { | ||
| jest.advanceTimersByTime(100); // debounce | ||
| }); | ||
| expect(result.current).toBe('short'); | ||
| }); | ||
| }); |
30 changes: 30 additions & 0 deletions
30
...ges/shared/kbn-elastic-assistant/impl/assistant/assistant_body/use_vertical_breakpoint.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { useEffect } from 'react'; | ||
| import useRafState from 'react-use/lib/useRafState'; | ||
|
|
||
| export type VerticalBreakpoint = 'short' | 'medium' | 'tall'; | ||
|
|
||
| export function useVerticalBreakpoint(): VerticalBreakpoint { | ||
| const [height, setHeight] = useRafState(() => window.innerHeight); | ||
|
|
||
| useEffect(() => { | ||
| const handleResize = () => { | ||
| const newHeight = window.innerHeight; | ||
| setHeight((prev) => (prev !== newHeight ? newHeight : prev)); | ||
| }; | ||
| window.addEventListener('resize', handleResize, { passive: true }); | ||
| return () => { | ||
| window.removeEventListener('resize', handleResize); | ||
| }; | ||
| }, [setHeight]); | ||
|
|
||
| if (height < 600) return 'short'; | ||
| if (height < 1100) return 'medium'; | ||
| return 'tall'; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not relevant to these changes, just a general question:
Do we have any guidelines on using classic function declaration vs arrow function? I see we mix both notations in kibana and assistant code base, but was wondering whether we have a preferred way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to quote ElasticGPT "The codebase and documentation show that both notations are used interchangeably, and there is no current enforcement of one style over the other."