[Security Assistant] Responsive design for welcome screen#226062
Merged
stephmilovic merged 5 commits intoelastic:mainfrom Jul 2, 2025
Merged
[Security Assistant] Responsive design for welcome screen#226062stephmilovic merged 5 commits intoelastic:mainfrom
stephmilovic merged 5 commits intoelastic:mainfrom
Conversation
stephmilovic
added
release_note:skip
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
e40pud
approved these changes
Jul 2, 2025
Contributor
e40pud
left a comment
e40pud
left a comment
There was a problem hiding this comment.
Thanks for the improvement! Tested locally and it works great 🚀
LGTM
|
|
||
| export type VerticalBreakpoint = 'short' | 'medium' | 'tall'; | ||
|
|
||
| export function useVerticalBreakpoint(): VerticalBreakpoint { |
Contributor
There was a problem hiding this comment.
Not relevant to these changes, just a general question:
Do we have any guidelines on using classic function declaration vs arrow function? I see we mix both notations in kibana and assistant code base, but was wondering whether we have a preferred way.
Contributor
Author
There was a problem hiding this comment.
to quote ElasticGPT "The codebase and documentation show that both notations are used interchangeably, and there is no current enforcement of one style over the other."
| const handleResizeRef = useRef<((event: UIEvent) => void) & { cancel: () => void }>(); | ||
|
|
||
| useEffect(() => { | ||
| const handleResize = debounce(() => { |
Contributor
There was a problem hiding this comment.
I wonder if using useRafState will be better here https://www.reactuse.com/state/userafstate? Looks like it could help to get rid of both debounce and handleResizeRef.
Contributor
Author
There was a problem hiding this comment.
Thanks, didn't know about that one
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
|
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16030488619 |
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 2, 2025
) (#226270) # Backport This will backport the following commits from `main` to `9.1`: - [[Security Assistant] Responsive design for welcome screen (#226062)](#226062) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2025-07-02T16:21:59Z","message":"[Security Assistant] Responsive design for welcome screen (#226062)","sha":"128d6fc7735cca837e887a989a0a945cf5503396","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: SecuritySolution","Team:Security Generative AI","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Security Assistant] Responsive design for welcome screen","number":226062,"url":"https://github.com/elastic/kibana/pull/226062","mergeCommit":{"message":"[Security Assistant] Responsive design for welcome screen (#226062)","sha":"128d6fc7735cca837e887a989a0a945cf5503396"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226062","number":226062,"mergeCommit":{"message":"[Security Assistant] Responsive design for welcome screen (#226062)","sha":"128d6fc7735cca837e887a989a0a945cf5503396"}}]}] BACKPORT--> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
stephmilovic
added a commit
that referenced
this pull request
Jul 2, 2025
…6062) (#226273) # Backport This will backport the following commits from `main` to `8.19`: - [[Security Assistant] Responsive design for welcome screen (#226062)](#226062) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2025-07-02T16:21:59Z","message":"[Security Assistant] Responsive design for welcome screen (#226062)","sha":"128d6fc7735cca837e887a989a0a945cf5503396","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: SecuritySolution","Team:Security Generative AI","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Security Assistant] Responsive design for welcome screen","number":226062,"url":"https://github.com/elastic/kibana/pull/226062","mergeCommit":{"message":"[Security Assistant] Responsive design for welcome screen (#226062)","sha":"128d6fc7735cca837e887a989a0a945cf5503396"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/226270","number":226270,"state":"OPEN"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226062","number":226062,"mergeCommit":{"message":"[Security Assistant] Responsive design for welcome screen (#226062)","sha":"128d6fc7735cca837e887a989a0a945cf5503396"}}]}] BACKPORT-->
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a responsive design for the Security Assistant welcome screen based on the available vertical space.
Tall vertical space
Short vertical space
Transition
Screen.Recording.2025-07-01.at.3.36.45.PM.mov