Skip to content

Conversation

@elastic-renovate-prod
Copy link
Contributor

@elastic-renovate-prod elastic-renovate-prod bot commented Jan 10, 2025

This PR contains the following updates:

Package Type Update Change
monaco-editor dependencies minor ^0.44.0 -> ^0.52.2

Release Notes

microsoft/monaco-editor (monaco-editor)

v0.52.2

Compare Source

Changes:

This list of changes was auto generated.

v0.52.0

Compare Source

  • Comment added inside of IModelContentChangedEvent

v0.51.0

Compare Source

  • New fields IEditorOptions.placeholder and IEditorOptions.compactMode
  • New fields IGotoLocationOptions.multipleTests and IGotoLocationOptions.alternativeTestsCommand
  • New field IInlineEditOptions.backgroundColoring
  • New experimental field IEditorOptions.experimental.useTrueInlineView
  • New options CommentThreadRevealOptions for comments

Contributions to monaco-editor:

v0.50.0

Compare Source

  • New field IEditorMinimapOptions.sectionHeaderLetterSpacing
  • New field IOverlayWidgetPosition.stackOridinal
  • New field EmitOutput.diagnostics
  • New event IOverlayWidget.onDidLayout
  • New events ICodeEditor.onBeginUpdate and ICodeEditor.onEndUpdate
  • HoverVerbosityRequest.action -> HoverVerbosityRequest.verbosityDelta
  • MultiDocumentHighlightProvider.selector changed from LanguageFilter to LanguageSelector
  • New optional parameters in getEmitOutput: emitOnlyDtsFiles and forceDtsEmit

Contributions to monaco-editor:

v0.49.0

Compare Source

  • New proposed editorHoverVerbosityLevel API
  • New proposed newSymbolNamesProvider API

Contributions to monaco-editor:

v0.48.0

Compare Source

Additions
  • Various bug fixes
  • Minimap Section Headers (see config option showRegionSectionHeaders)
  • Diff Editor Gutter Menu (see config option renderGutterMenu)
  • InlineCompletionsProvider.handlePartialAccept has PartialAcceptInfo

Contributions to monaco-editor:

v0.47.0

Compare Source

Additions
  • Bug fixes
  • registerNewSymbolNameProvider
  • Experimental registerInlineEditProvider

v0.46.0

Compare Source

  • Bug fixes

v0.45.0

Compare Source

Breaking Changes
  • wordBasedSuggestions: boolean -> 'off' | 'currentDocument' | 'matchingDocuments' | 'allDocuments'
  • occurrencesHighlight: boolean -> 'off' | 'singleFile' | 'multiFile'
Additions
  • Many bug fixes
  • IEditorScrollbarOptions.ignoreHorizontalScrollbarInContentHeight
  • IDiffEditor.goToDiff
  • IDiffEditor.revealFirstDiff

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@elastic-renovate-prod elastic-renovate-prod bot added backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// labels Jan 10, 2025
@elastic-renovate-prod elastic-renovate-prod bot requested a review from a team January 10, 2025 02:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@eokoneyo
Copy link
Contributor

@Dosant Dosant requested a review from eokoneyo May 2, 2025 15:15
@eokoneyo eokoneyo self-assigned this May 20, 2025
@eokoneyo
Copy link
Contributor

@elasticmachine merge upstream

@eokoneyo
Copy link
Contributor

/ci

@eokoneyo eokoneyo requested a review from a team as a code owner May 20, 2025 11:39
@kibanamachine kibanamachine requested a review from a team May 20, 2025 11:39
@eokoneyo
Copy link
Contributor

/ci

@eokoneyo eokoneyo marked this pull request as draft May 20, 2025 11:41
@eokoneyo
Copy link
Contributor

eokoneyo commented May 20, 2025

I've converted this PR back to draft because the upgrade isn't quite as straight forward as one would expect, as there's a need to make some adjustments, I'll open this for review again once it's ready.

@elastic-renovate-prod
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@eokoneyo
Copy link
Contributor

/ci

@eokoneyo eokoneyo force-pushed the renovate/main-monaco branch from 85c0f46 to 0d20422 Compare May 20, 2025 13:20
@eokoneyo
Copy link
Contributor

/ci

@eokoneyo eokoneyo force-pushed the renovate/main-monaco branch from 0d20422 to 0e462b5 Compare May 20, 2025 13:42
@eokoneyo
Copy link
Contributor

/ci

1 similar comment
@eokoneyo
Copy link
Contributor

/ci


describe('misc console behavior', function testMiscConsoleBehavior() {
before(async () => {
await browser.setWindowSize(1200, 800);
Copy link
Contributor

@eokoneyo eokoneyo May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed because of this failing test, strange thing is the expectation is met whilst running this PR locally as long the window isn't shrunk, however for FTR tests because of the window size this test fails. Ideally the URL provided should redirect to /operation-search, as seen when following the url like so;
curl -I https://www.elastic.co/guide/en/elasticsearch/reference/master/search-search.html, my guess would be that some kind of anchor scroll with the toc messes with the URL.

I've linked a video showing the experience;

Untitled.mov

@eokoneyo
Copy link
Contributor

/ci

@eokoneyo eokoneyo marked this pull request as ready for review May 21, 2025 00:56
@eokoneyo eokoneyo requested review from a team as code owners May 21, 2025 00:56
This was referenced Jun 5, 2025
pheyos added a commit that referenced this pull request Jun 6, 2025
…222854)

This reverts commit 11247fe.

We started seeing consistent failures of tests in MKI and the failure
logs are indicating a problem with the recent monaco editor update. I've
checked this revert commit with the MKI pipeline and these failures
didn't occur anymore.
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 9, 2025
PR to fix a test that broke after merging [this
PR](elastic#206176)

(cherry picked from commit 0b3a675)
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

pmuellr pushed a commit to pmuellr/kibana that referenced this pull request Jun 11, 2025
PR to fix a test that broke after merging [this
PR](elastic#206176)
pmuellr pushed a commit to pmuellr/kibana that referenced this pull request Jun 11, 2025
…6176)" (elastic#222854)

This reverts commit 11247fe.

We started seeing consistent failures of tests in MKI and the failure
logs are indicating a problem with the recent monaco editor update. I've
checked this revert commit with the MKI pipeline and these failures
didn't occur anymore.
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

nickpeihl pushed a commit to nickpeihl/kibana that referenced this pull request Jun 12, 2025
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [monaco-editor](https://github.com/microsoft/monaco-editor) |
dependencies | minor | [`^0.44.0` ->
`^0.52.2`](https://renovatebot.com/diffs/npm/monaco-editor/0.44.0/0.52.2)
|

---

### Release Notes

<details>
<summary>microsoft/monaco-editor (monaco-editor)</summary>

###
[`v0.52.2`](https://github.com/microsoft/monaco-editor/releases/tag/v0.52.2)

[Compare
Source](https://github.com/microsoft/monaco-editor/compare/v0.52.0...v0.52.2)

#### Changes:

-
[#&elastic#8203;4777](https://github.com/microsoft/monaco-editor/issues/4777):
0.52.2
-
[#&elastic#8203;4774](https://github.com/microsoft/monaco-editor/issues/4774):
Updates changelog

This list of changes was [auto
generated](https://dev.azure.com/monacotools/Monaco/\_build/results?buildId=309119\&view=logs).

###
[`v0.52.0`](https://github.com/microsoft/monaco-editor/blob/HEAD/CHANGELOG.md#0520)

[Compare
Source](https://github.com/microsoft/monaco-editor/compare/v0.51.0...v0.52.0)

-   Comment added inside of `IModelContentChangedEvent`

###
[`v0.51.0`](https://github.com/microsoft/monaco-editor/blob/HEAD/CHANGELOG.md#0510)

[Compare
Source](https://github.com/microsoft/monaco-editor/compare/v0.50.0...v0.51.0)

- New fields `IEditorOptions.placeholder` and
`IEditorOptions.compactMode`
- New fields `IGotoLocationOptions.multipleTests` and
`IGotoLocationOptions.alternativeTestsCommand`
-   New field `IInlineEditOptions.backgroundColoring`
- New experimental field `IEditorOptions.experimental.useTrueInlineView`
-   New options `CommentThreadRevealOptions` for comments

Contributions to `monaco-editor`:

- [@&elastic#8203;ScottCarda-MS (Scott
Carda)](https://github.com/ScottCarda-MS): Update Q# Keywords
[PR
#&elastic#8203;4586](https://github.com/microsoft/monaco-editor/pull/4586)

###
[`v0.50.0`](https://github.com/microsoft/monaco-editor/blob/HEAD/CHANGELOG.md#0500)

[Compare
Source](https://github.com/microsoft/monaco-editor/compare/v0.49.0...v0.50.0)

-   New field `IEditorMinimapOptions.sectionHeaderLetterSpacing`
-   New field `IOverlayWidgetPosition.stackOridinal`
-   New field `EmitOutput.diagnostics`
-   New event `IOverlayWidget.onDidLayout`
-   New events `ICodeEditor.onBeginUpdate` and `ICodeEditor.onEndUpdate`
- `HoverVerbosityRequest.action` ->
`HoverVerbosityRequest.verbosityDelta`
- `MultiDocumentHighlightProvider.selector` changed from
`LanguageFilter` to `LanguageSelector`
- New optional parameters in `getEmitOutput`: `emitOnlyDtsFiles` and
`forceDtsEmit`

Contributions to `monaco-editor`:

- [@&elastic#8203;htcfreek (Heiko)](https://github.com/htcfreek): Add
extension to `csp.contribution.ts` [PR
#&elastic#8203;4504](https://github.com/microsoft/monaco-editor/pull/4504)
- [@&elastic#8203;jakebailey (Jake
Bailey)](https://github.com/jakebailey): Call clearFiles on
internal EmitOutput diagnostics, pass args down [PR
#&elastic#8203;4482](https://github.com/microsoft/monaco-editor/pull/4482)
- [@&elastic#8203;johnyanarella (John
Yanarella)](https://github.com/johnyanarella): Update
TypeScript to TS 5.4.5 in all projects, vendored files [PR
#&elastic#8203;4305](https://github.com/microsoft/monaco-editor/pull/4305)
-
[@&elastic#8203;samstrohkorbatt](https://github.com/samstrohkorbatt):
Adding Python f-string syntax support [PR
#&elastic#8203;4401](https://github.com/microsoft/monaco-editor/pull/4401)

###
[`v0.49.0`](https://github.com/microsoft/monaco-editor/blob/HEAD/CHANGELOG.md#0490)

[Compare
Source](https://github.com/microsoft/monaco-editor/compare/v0.48.0...v0.49.0)

-   New proposed `editorHoverVerbosityLevel` API
-   New proposed `newSymbolNamesProvider` API

Contributions to `monaco-editor`:

- [@&elastic#8203;timotheeguerin (Timothee
Guerin)](https://github.com/timotheeguerin): Add support for
TypeSpec language [PR
#&elastic#8203;4450](https://github.com/microsoft/monaco-editor/pull/4450)

###
[`v0.48.0`](https://github.com/microsoft/monaco-editor/blob/HEAD/CHANGELOG.md#0480)

[Compare
Source](https://github.com/microsoft/monaco-editor/compare/v0.47.0...v0.48.0)

##### Additions

-   Various bug fixes
- Minimap Section Headers (see config option `showRegionSectionHeaders`)
-   Diff Editor Gutter Menu (see config option `renderGutterMenu`)
- `InlineCompletionsProvider.handlePartialAccept` has
`PartialAcceptInfo`

Contributions to `monaco-editor`:

- [@&elastic#8203;jeremy-rifkin (Jeremy
Rifkin)](https://github.com/jeremy-rifkin): Fix bug with
highlighting of C++ raw string literals [PR
#&elastic#8203;4436](https://github.com/microsoft/monaco-editor/pull/4436)

###
[`v0.47.0`](https://github.com/microsoft/monaco-editor/blob/HEAD/CHANGELOG.md#0470)

[Compare
Source](https://github.com/microsoft/monaco-editor/compare/v0.46.0...v0.47.0)

##### Additions

-   Bug fixes
-   `registerNewSymbolNameProvider`
-   Experimental `registerInlineEditProvider`

###
[`v0.46.0`](https://github.com/microsoft/monaco-editor/blob/HEAD/CHANGELOG.md#0460)

[Compare
Source](https://github.com/microsoft/monaco-editor/compare/v0.45.0...v0.46.0)

-   Bug fixes

###
[`v0.45.0`](https://github.com/microsoft/monaco-editor/blob/HEAD/CHANGELOG.md#0450)

[Compare
Source](https://github.com/microsoft/monaco-editor/compare/v0.44.0...v0.45.0)

##### Breaking Changes

- `wordBasedSuggestions: boolean` -> `'off' | 'currentDocument' |
'matchingDocuments' | 'allDocuments'`
- `occurrencesHighlight: boolean` -> `'off' | 'singleFile' |
'multiFile'`

##### Additions

-   Many bug fixes
-   `IEditorScrollbarOptions.ignoreHorizontalScrollbarInContentHeight`
-   `IDiffEditor.goToDiff`
-   `IDiffEditor.revealFirstDiff`

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM5LjEwNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOlNoYXJlZFVYIiwiYmFja3BvcnQ6YWxsLW9wZW4iLCJyZWxlYXNlX25vdGU6c2tpcCJdfQ==-->

---------

Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>
Co-authored-by: Eyo Okon Eyo <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: “jeramysoucy” <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
nickpeihl pushed a commit to nickpeihl/kibana that referenced this pull request Jun 12, 2025
PR to fix a test that broke after merging [this
PR](elastic#206176)
nickpeihl pushed a commit to nickpeihl/kibana that referenced this pull request Jun 12, 2025
…6176)" (elastic#222854)

This reverts commit 11247fe.

We started seeing consistent failures of tests in MKI and the failure
logs are indicating a problem with the recent monaco editor update. I've
checked this revert commit with the MKI pipeline and these failures
didn't occur anymore.
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

8 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @eokoneyo

@eokoneyo eokoneyo removed the backport:all-open Backport to all branches that could still receive a release label Jun 26, 2025
@kibanamachine kibanamachine added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jun 26, 2025
@eokoneyo
Copy link
Contributor

This PR was reverted here #222854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants