Mgmt saved object test#22564
Conversation
|
jenkins, test this |
💚 Build Succeeded |
|
jenkins, test this |
💚 Build Succeeded |
|
jenkins, test this |
💚 Build Succeeded |
|
@LeeDr can you please tae a look ? |
|
@Rasroh Are you sure you added your files? I see |
| await PageObjects.header.waitUntilLoadingHasFinished(); | ||
| await PageObjects.settings.setImportIndexFieldOption(2); | ||
| await PageObjects.settings.setImportIndexFieldOption('d1e4c910-a2e6-11e7-bb30-233be9be6a15', 2); | ||
| await PageObjects.settings.clickConfirmChanges(); |
There was a problem hiding this comment.
I don't understand why we're still using an integer index here "2"? I thought a data-test-subj was added so we could select them by name?
| await find.clickByCssSelector( | ||
| `select[data-test-subj="managementChangeIndexSelection"] > option:nth-child(${child})` | ||
| `select[data-test-subj="managementChangeIndexSelection-${id}"] > option:nth-child(${child})` | ||
| ); |
There was a problem hiding this comment.
Related to the other comment about the integer index. Hopefully we can use the name instead.
There was a problem hiding this comment.
here , I have parametrized the id - when I run the test- setImportIndexFieldOption takes 2 parameters -> (id, child)` - id is the name of the indexPattern
...bana/public/management/sections/objects/components/objects_table/components/flyout/flyout.js
Show resolved
Hide resolved
|
Here's a screenshot as I inspected elements in that selection list. The only selection I have is the one index pattern I created
|
…ration of review comments
…cih loads logstash indexpattern
|
incorporated all the review changes and testing it in jenkins. |
💔 Build Failed |
💔 Build Failed |
|
jenkins test this |
bmcconaghy
left a comment
bmcconaghy
left a comment
There was a problem hiding this comment.
Had a question about some deletions.
bmcconaghy
left a comment
bmcconaghy
left a comment
There was a problem hiding this comment.
LGTM assuming tests pass.
|
jenkins, test this |
💔 Build Failed |
💚 Build Succeeded |
This reverts commit a4c3bc2.
💔 Build Failed |
💚 Build Succeeded |
4 participants
Test to check the import of the saved object works.
Tests #22238 - but the json is a subset.