added log info for clarity while running the test with additional params- test huge field#22277
Merged
rashmivkulkarni merged 1 commit intoelastic:6.xfrom Aug 23, 2018
Merged
Conversation
Contributor
Author
|
jenkins, test this |
Contributor
💚 Build Succeeded |
LeeDr
reviewed
Aug 23, 2018
LeeDr
left a comment
LeeDr
left a comment
There was a problem hiding this comment.
LGTM - Code review and checked these Jenkins results;
01:09:10.416 │ info if there is a failure, start the server with "node scripts/functional_tests_server -- --server.maxPayloadBytes=1648576"
01:09:10.417 └- ✓ pass
01:09:10.419 └-> "after all" hook
rashmivkulkarni
added a commit
to rashmivkulkarni/kibana
that referenced
this pull request
Aug 23, 2018
rashmivkulkarni
added a commit
to rashmivkulkarni/kibana
that referenced
this pull request
Aug 23, 2018
rashmivkulkarni
added a commit
that referenced
this pull request
Aug 23, 2018
rashmivkulkarni
added a commit
that referenced
this pull request
Aug 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding additional log.info - in case the test fails and has instructions how to run this test with additional params while starting the test.
investigating -- if there is another better way if we can decrease the number of fields or make a change where it's still within the default bounds. Or, can we post to ES directly.