Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/serverless.oblt.logs_essentials.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ xpack.apm.enabled: false
xpack.legacy_uptime.enabled: false
xpack.ux.enabled: false
xpack.uptime.enabled: false
xpack.exploratoryView.enabled: false

xpack.fleet.internal.registry.excludePackages: [
# Oblt integrations
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
"plugin": {
"id": "exploratoryView",
"browser": true,
"server": false,
"server": true,
"configPath": [
"xpack",
"exploratory_view"
"exploratoryView"
],
"requiredPlugins": [
"alerting",
Expand Down Expand Up @@ -52,4 +52,4 @@
"common"
]
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/

import { type PluginConfigDescriptor, PluginInitializerContext } from '@kbn/core/server';
import { schema } from '@kbn/config-schema';

export const plugin = async (initializerContext: PluginInitializerContext) => {
const { Plugin } = await import('./plugin');
return new Plugin();
};

export const config: PluginConfigDescriptor = {
schema: schema.object({
enabled: schema.boolean({ defaultValue: true }),
}),
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import { CoreStart, CoreSetup, Plugin as PluginType } from '@kbn/core/server';

export class Plugin implements PluginType {
constructor() {}

public setup(core: CoreSetup, plugins: {}) {
return {};
}

public start(coreStart: CoreStart, pluginsStart: {}) {}

public stop() {}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"compilerOptions": {
"outDir": "target/types"
},
"include": ["common/**/*", "public/**/*", "public/**/*.json", "../../../../../typings/**/*"],
"include": ["common/**/*", "public/**/*", "server/**/*", "public/**/*.json", "../../../../../typings/**/*"],
"kbn_references": [
"@kbn/core",
"@kbn/data-plugin",
Expand Down Expand Up @@ -44,7 +44,8 @@
"@kbn/react-kibana-mount",
"@kbn/core-analytics-browser",
"@kbn/expressions-plugin",
"@kbn/ebt-tools"
"@kbn/ebt-tools",
"@kbn/config-schema"
],
"exclude": ["target/**/*"]
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
"fieldFormats",
"uiActions",
"presentationUtil",
"exploratoryView",
"features",
"files",
"inspector",
Expand All @@ -50,6 +49,7 @@
],
"optionalPlugins": [
"discover",
"exploratoryView",
"home",
"usageCollection",
"cloud",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ export function UXSection({ bucketSize }: Props) {
const { forceUpdate, hasDataMap } = useHasData();
const { services } = useKibana<ObservabilityPublicPluginsStart>();

const { ExploratoryViewEmbeddable } = services.exploratoryView;

const { relativeStart, relativeEnd, absoluteStart, absoluteEnd, lastUpdated } =
useDatePickerContext();
const uxHasDataResponse = hasDataMap.ux;
Expand Down Expand Up @@ -79,9 +77,10 @@ export function UXSection({ bucketSize }: Props) {
]
);

if (!uxHasDataResponse?.hasData) {
if (!uxHasDataResponse?.hasData || !services.exploratoryView) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also prevent the CoreVitals component from being rendered, is that the expected behaviour?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's expected

return null;
}
const ExploratoryViewEmbeddable = services.exploratoryView.ExploratoryViewEmbeddable;

const isLoading = status === FETCH_STATUS.LOADING;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export interface ObservabilityPublicPluginsStart {
dataViewEditor: DataViewEditorStart;
discover: DiscoverStart;
embeddable: EmbeddableStart;
exploratoryView: ExploratoryViewPublicStart;
exploratoryView?: ExploratoryViewPublicStart;
fieldFormats: FieldFormatsStart;
guidedOnboarding?: GuidedOnboardingPluginStart;
lens: LensPublicStart;
Expand Down