Skip to content

Comments

[Logs Essential] Disable exploratory view !!#225445

Merged
shahzad31 merged 4 commits intoelastic:mainfrom
shahzad31:disable-exp-view
Jun 27, 2025
Merged

[Logs Essential] Disable exploratory view !!#225445
shahzad31 merged 4 commits intoelastic:mainfrom
shahzad31:disable-exp-view

Conversation

@shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jun 26, 2025 •
edited by kibanamachine
Loading

@shahzad31 shahzad31 requested review from a team as code owners June 26, 2025 12:45
@shahzad31 shahzad31 requested a review from a team June 26, 2025 12:45
@shahzad31 shahzad31 requested a review from a team as a code owner June 26, 2025 12:45
@botelastic botelastic bot added the Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. label Jun 26, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 26, 2025

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions github-actions bot added the author:obs-ux-management PRs authored by the obs ux management team label Jun 26, 2025
@shahzad31 shahzad31 added the release_note:skip Skip the PR/issue when compiling release notes label Jun 26, 2025
@kc13greiner kc13greiner self-requested a review June 26, 2025 12:47
@shahzad31 shahzad31 added backport:skip This PR does not require backporting v8.19.0 backport:version Backport to applied version labels and removed release_note:skip Skip the PR/issue when compiling release notes labels Jun 26, 2025
@shahzad31 shahzad31 added the release_note:skip Skip the PR/issue when compiling release notes label Jun 26, 2025
@kc13greiner
Copy link
Contributor

kc13greiner commented Jun 26, 2025

@shahzad31 are there associated tests that should be updated as part of this fix?

rmyz
rmyz approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@rmyz rmyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra & services changes LGTM

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 26, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.3MB 1.3MB +18.0B

History

gsoldevila
gsoldevila approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@gsoldevila gsoldevila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config changes LGTM (reviewed when last commit was 1f2080d)

tonyghiani
tonyghiani reviewed Jun 27, 2025
View reviewed changes
...ervability/plugins/observability/public/pages/overview/components/sections/ux/ux_section.tsx
);

if (!uxHasDataResponse?.hasData) {
if (!uxHasDataResponse?.hasData || !services.exploratoryView) {
Copy link
Contributor

@tonyghiani tonyghiani Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also prevent the CoreVitals component from being rendered, is that the expected behaviour?

Copy link
Contributor Author

@shahzad31 shahzad31 Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's expected

@shahzad31
Copy link
Contributor Author

shahzad31 commented Jun 27, 2025

@kc13greiner this is a plugin disable, we aren't making it optional anywhere, so this has no impact in terms of actions, the place where it's being used is still required and those are disbaled as well, so IMO this doesn't warrant any tests.

@shahzad31 shahzad31 merged commit f7253bc into elastic:main Jun 27, 2025
12 checks passed
@shahzad31 shahzad31 deleted the disable-exp-view branch June 27, 2025 08:15
tonyghiani
tonyghiani requested changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the observability plugins, also apm, synthetics, uptime and ux plugins depends on it. Probably some of them will be disabled anyway, but the safest approach would be to make this an optional dependency for those plugins too to avoid undesired side effects where plugins we want to keep around are disabled.

@shahzad31
Copy link
Contributor Author

shahzad31 commented Jun 27, 2025

Apart from the observability plugins, also apm, synthetics, uptime and ux plugins depends on it. Probably some of them will be disabled anyway, but the safest approach would be to make this an optional dependency for those plugins too to avoid undesired side effects where plugins we want to keep around are disabled.

No that can't be done, Exp view is a hard requirement for synthetics and ux , we can't make it optional

@shahzad31 shahzad31 added backport:version Backport to applied version labels and removed backport:skip This PR does not require backporting backport:version Backport to applied version labels labels Jun 27, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 27, 2025

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/15921645277

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 27, 2025

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/15921651038

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 27, 2025
@shahzad31
[Logs Essential] Disable exploratory view !! (elastic#225445)
a62fa22 
## Summary

Disable exploratory view !!

Fixes elastic/observability-dev#4638 !!

### Testing
http://localhost:5601/app/exploratory-view

<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/5a03fe49-0057-4a6c-aa76-795fa562edf3"
/>

(cherry picked from commit f7253bc)
@kibanamachine kibanamachine mentioned this pull request Jun 27, 2025
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 27, 2025

💔 Some backports could not be created

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts
✅ 9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 225445

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 27, 2025
@shahzad31
[Logs Essential] Disable exploratory view !! (elastic#225445)
e8fd616 
## Summary

Disable exploratory view !!

Fixes elastic/observability-dev#4638 !!

### Testing
http://localhost:5601/app/exploratory-view

<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/5a03fe49-0057-4a6c-aa76-795fa562edf3"
/>

(cherry picked from commit f7253bc)
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 27, 2025

💔 Some backports could not be created

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts
✅ 9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 225445

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Jun 27, 2025
Merged
@jeramysoucy
Copy link
Contributor

jeramysoucy commented Jun 30, 2025

@kc13greiner this is a plugin disable, we aren't making it optional anywhere, so this has no impact in terms of actions, the place where it's being used is still required and those are disbaled as well, so IMO this doesn't warrant any tests.

@shahzad31 As I understand it, the other ways to navigate to this view are disabled, and this PR is simply disabling the plugin altogether in order to prevent direct URL navigation. The issue has criteria for acceptance, so I think we were just wondering if there are, or should be, tests that qualify the config, in addition to manual testing.

Acceptance Criteria

When running a serverless project is running in Logs Essentials mode, it is not possible to load Exploratory View by loading /app/exploratory-view

We might be missing some context here, and if so, apologies!

kibanamachine added a commit that referenced this pull request Jun 30, 2025
@kibanamachine @shahzad31
[9.1] [Logs Essential] Disable exploratory view !! (#225445) (#225584)
3076740 
# Backport

This will backport the following commits from `main` to `9.1`:
- [[Logs Essential] Disable exploratory view !!
(#225445)](#225445)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2025-06-27T08:15:18Z","message":"[Logs
Essential] Disable exploratory view !! (#225445)\n\n##
Summary\n\nDisable exploratory view !!\n\nFixes
elastic/observability-dev#4638 !!\n\n###
Testing \nhttp://localhost:5601/app/exploratory-view\n\n<img
width=\"1728\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/5a03fe49-0057-4a6c-aa76-795fa562edf3\"\n/>","sha":"f7253bc0d1750d556ebaee9eb5fc8b35999a9b78","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.2.0"],"title":"[Logs
Essential] Disable exploratory view
!!","number":225445,"url":"https://github.com/elastic/kibana/pull/225445","mergeCommit":{"message":"[Logs
Essential] Disable exploratory view !! (#225445)\n\n##
Summary\n\nDisable exploratory view !!\n\nFixes
elastic/observability-dev#4638 !!\n\n###
Testing \nhttp://localhost:5601/app/exploratory-view\n\n<img
width=\"1728\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/5a03fe49-0057-4a6c-aa76-795fa562edf3\"\n/>","sha":"f7253bc0d1750d556ebaee9eb5fc8b35999a9b78"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225445","number":225445,"mergeCommit":{"message":"[Logs
Essential] Disable exploratory view !! (#225445)\n\n##
Summary\n\nDisable exploratory view !!\n\nFixes
elastic/observability-dev#4638 !!\n\n###
Testing \nhttp://localhost:5601/app/exploratory-view\n\n<img
width=\"1728\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/5a03fe49-0057-4a6c-aa76-795fa562edf3\"\n/>","sha":"f7253bc0d1750d556ebaee9eb5fc8b35999a9b78"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonyghiani tonyghiani tonyghiani requested changes

@rmyz rmyz rmyz approved these changes

@gsoldevila gsoldevila gsoldevila approved these changes

@baileycash-elastic baileycash-elastic baileycash-elastic approved these changes

@kc13greiner kc13greiner Awaiting requested review from kc13greiner

Assignees

No one assigned

Labels

author:obs-ux-management PRs authored by the obs ux management team backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.19.0 v9.1.0 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@shahzad31 @elasticmachine @kc13greiner @kibanamachine @jeramysoucy @rmyz @gsoldevila @tonyghiani @baileycash-elastic