Skip to content

[8.19] Share experience Improvements (#222242)#225321

Merged
eokoneyo merged 2 commits into
elastic:8.19from
eokoneyo:backport/8.19/pr-222242
Jun 25, 2025
Merged

[8.19] Share experience Improvements (#222242)#225321
eokoneyo merged 2 commits into
elastic:8.19from
eokoneyo:backport/8.19/pr-222242

Conversation

@eokoneyo
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

## Summary

Closes elastic#222093

Changes

- restrict copy link height
~- copy link to clipboard for lens without opening flyout, when lens is
already saved~
- display share modal without tab indicator when there's only one share
option available

<!--
### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

-->

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 4bedf05)

# Conflicts:
#	src/platform/plugins/shared/share/tsconfig.json
@eokoneyo eokoneyo requested a review from kibanamachine as a code owner June 25, 2025 15:27
@eokoneyo eokoneyo added the backport This PR is a backport of another PR label Jun 25, 2025
@eokoneyo eokoneyo enabled auto-merge (squash) June 25, 2025 15:27
@eokoneyo eokoneyo merged commit a8b390b into elastic:8.19 Jun 25, 2025
8 checks passed
@eokoneyo eokoneyo deleted the backport/8.19/pr-222242 branch June 25, 2025 17:43
@eokoneyo eokoneyo self-assigned this Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants