Share experience Improvements#222242
Merged
eokoneyo merged 13 commits intoelastic:mainfrom Jun 23, 2025
Merged
Conversation
eokoneyo
added
release_note:skip
eokoneyo
changed the title
eokoneyo
force-pushed
the
chore/resolve-222093-export-menu-improvements
branch
3 times, most recently
from
9a22a07 to
db6ff2c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
eokoneyo
force-pushed
the
chore/resolve-222093-export-menu-improvements
branch
from
b204394 to
b9803a1
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
eokoneyo
force-pushed
the
chore/resolve-222093-export-menu-improvements
branch
from
b9803a1 to
c425d81
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
eokoneyo
force-pushed
the
chore/resolve-222093-export-menu-improvements
branch
2 times, most recently
from
aa333a1 to
dc02bca
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
eokoneyo
force-pushed
the
chore/resolve-222093-export-menu-improvements
branch
2 times, most recently
from
01ba8a3 to
af3e96d
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
eokoneyo
force-pushed
the
chore/resolve-222093-export-menu-improvements
branch
from
af3e96d to
c23e083
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
eokoneyo
force-pushed
the
chore/resolve-222093-export-menu-improvements
branch
from
c23e083 to
d083ebd
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
eokoneyo
force-pushed
the
chore/resolve-222093-export-menu-improvements
branch
from
d083ebd to
b4cec52
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
eokoneyo
force-pushed
the
chore/resolve-222093-export-menu-improvements
branch
from
b4cec52 to
d083ebd
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
eokoneyo
force-pushed
the
chore/resolve-222093-export-menu-improvements
branch
from
07cfdd9 to
c7eff10
Compare
eokoneyo
changed the title
eokoneyo
force-pushed
the
chore/resolve-222093-export-menu-improvements
branch
from
824f9e4 to
83f7590
Compare
eokoneyo
force-pushed
the
chore/resolve-222093-export-menu-improvements
branch
from
83f7590 to
42175ce
Compare
eokoneyo
force-pushed
the
chore/resolve-222093-export-menu-improvements
branch
from
9844fcf to
128c5e4
Compare
Contributor
💚 Build Succeeded
Metrics [docs]Page load bundle
History
cc @eokoneyo |
Contributor
Author
|
@elasticmachine merge upstream |
markov00
approved these changes
Jun 23, 2025
Contributor
markov00
left a comment
markov00
left a comment
There was a problem hiding this comment.
Tested locally, looks good now except for this little detail (that is not super important #222242 (comment))
I'm approving anyway since it looks safe
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
Jun 25, 2025
## Summary Closes elastic#222093 Changes - restrict copy link height ~- copy link to clipboard for lens without opening flyout, when lens is already saved~ - display share modal without tab indicator when there's only one share option available <!-- ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
eokoneyo
added a commit
to eokoneyo/kibana
that referenced
this pull request
Jun 25, 2025
## Summary Closes elastic#222093 Changes - restrict copy link height ~- copy link to clipboard for lens without opening flyout, when lens is already saved~ - display share modal without tab indicator when there's only one share option available <!-- ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 4bedf05) # Conflicts: # src/platform/plugins/shared/share/tsconfig.json
eokoneyo
added a commit
that referenced
this pull request
Jun 25, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [Share experience Improvements (#222242)](#222242) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Eyo O. Eyo","email":"7893459+eokoneyo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-06-23T09:37:41Z","message":"Share experience Improvements (#222242)\n\n## Summary\n\nCloses #222093 \n\nChanges\n\n- restrict copy link height\n~- copy link to clipboard for lens without opening flyout, when lens is\nalready saved~\n- display share modal without tab indicator when there's only one share\noption available\n\n\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"4bedf051b449f0f72fe3c379c7fcb1c876e641b7","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:SharedUX","v9.1.0"],"title":"Share experience Improvements","number":222242,"url":"https://github.com/elastic/kibana/pull/222242","mergeCommit":{"message":"Share experience Improvements (#222242)\n\n## Summary\n\nCloses #222093 \n\nChanges\n\n- restrict copy link height\n~- copy link to clipboard for lens without opening flyout, when lens is\nalready saved~\n- display share modal without tab indicator when there's only one share\noption available\n\n\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"4bedf051b449f0f72fe3c379c7fcb1c876e641b7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222242","number":222242,"mergeCommit":{"message":"Share experience Improvements (#222242)\n\n## Summary\n\nCloses #222093 \n\nChanges\n\n- restrict copy link height\n~- copy link to clipboard for lens without opening flyout, when lens is\nalready saved~\n- display share modal without tab indicator when there's only one share\noption available\n\n\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"4bedf051b449f0f72fe3c379c7fcb1c876e641b7"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #222093
Changes
- copy link to clipboard for lens without opening flyout, when lens is already saved