Skip to content

Comments

[Response Ops][Reporting][Task Manager] Allow setting dtstart in rrule schedule - schema changes only for intermediate release#224979

Merged
ymao1 merged 2 commits intoelastic:mainfrom
ymao1:scheduled-report-tm-started-at-intermediate-release
Jun 27, 2025
Merged

[Response Ops][Reporting][Task Manager] Allow setting dtstart in rrule schedule - schema changes only for intermediate release#224979
ymao1 merged 2 commits intoelastic:mainfrom
ymao1:scheduled-report-tm-started-at-intermediate-release

Conversation

@ymao1
Copy link
Contributor

@ymao1 ymao1 commented Jun 23, 2025

Summary

This PR contains the schema changes needed to support using dtstart in task manager rrule schedules. This is meant for intermediate release and then the changes will be used in this PR: #224948

@ymao1 ymao1 force-pushed the scheduled-report-tm-started-at-intermediate-release branch from 35a7a1f to be3d7fa Compare June 23, 2025 23:45
@ymao1 ymao1 force-pushed the scheduled-report-tm-started-at-intermediate-release branch from be3d7fa to 8a1ff63 Compare June 24, 2025 00:16
@ymao1 ymao1 self-assigned this Jun 25, 2025
@ymao1 ymao1 added Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// Feature:Reporting:Framework Reporting issues pertaining to the overall framework backport:version Backport to applied version labels v9.1.0 v8.19.0 v9.2.0 release_note:skip Skip the PR/issue when compiling release notes labels Jun 25, 2025
@ymao1 ymao1 marked this pull request as ready for review June 25, 2025 17:18
@ymao1 ymao1 requested review from a team as code owners June 25, 2025 17:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@ymao1 ymao1 requested a review from ersin-erdal June 25, 2025 17:21
Copy link
Contributor

@ersin-erdal ersin-erdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gsoldevila gsoldevila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review only)

@ymao1
Copy link
Contributor Author

ymao1 commented Jun 27, 2025

@elasticmachine merge upstream

@ymao1 ymao1 enabled auto-merge (squash) June 27, 2025 12:14
@ymao1 ymao1 disabled auto-merge June 27, 2025 12:36
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #94 / Stateful Observability - Deployment-agnostic API integration tests SyntheticsAPITests EnableDefaultAlerting deletes (and recreates) the default rule when settings are updated

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
taskManager 71 72 +1
Unknown metric groups

API count

id before after diff
taskManager 117 118 +1

History

cc @ymao1

@ymao1 ymao1 added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels and removed release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels labels Jun 27, 2025
@ymao1 ymao1 merged commit f43138c into elastic:main Jun 27, 2025
16 checks passed
@ymao1 ymao1 deleted the scheduled-report-tm-started-at-intermediate-release branch June 27, 2025 14:05
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/15928242607

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 27, 2025
…e schedule - schema changes only for intermediate release (elastic#224979)

## Summary

This PR contains the schema changes needed to support using `dtstart` in
task manager rrule schedules. This is meant for intermediate release and
then the changes will be used in this PR:
elastic#224948

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit f43138c)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.19 Backport failed because of merge conflicts
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 224979

Questions ?

Please refer to the Backport tool documentation

@ymao1
Copy link
Contributor Author

ymao1 commented Jun 27, 2025

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

ymao1 added a commit to ymao1/kibana that referenced this pull request Jun 27, 2025
…e schedule - schema changes only for intermediate release (elastic#224979)

## Summary

This PR contains the schema changes needed to support using `dtstart` in
task manager rrule schedules. This is meant for intermediate release and
then the changes will be used in this PR:
elastic#224948

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit f43138c)

# Conflicts:
#	src/core/server/integration_tests/ci_checks/saved_objects/check_registered_types.test.ts
kibanamachine added a commit that referenced this pull request Jun 27, 2025
…n rrule schedule - schema changes only for intermediate release (#224979) (#225645)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Response Ops][Reporting][Task Manager] Allow setting dtstart in
rrule schedule - schema changes only for intermediate release
(#224979)](#224979)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Ying
Mao","email":"ying.mao@elastic.co"},"sourceCommit":{"committedDate":"2025-06-27T14:05:28Z","message":"[Response
Ops][Reporting][Task Manager] Allow setting dtstart in rrule schedule -
schema changes only for intermediate release (#224979)\n\n##
Summary\n\nThis PR contains the schema changes needed to support using
`dtstart` in\ntask manager rrule schedules. This is meant for
intermediate release and\nthen the changes will be used in this
PR:\nhttps://github.com//pull/224948\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"f43138c059047b5a73ea8fabbc976ed2fc09a6b9","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Reporting:Framework","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Response
Ops][Reporting][Task Manager] Allow setting dtstart in rrule schedule -
schema changes only for intermediate
release","number":224979,"url":"https://github.com/elastic/kibana/pull/224979","mergeCommit":{"message":"[Response
Ops][Reporting][Task Manager] Allow setting dtstart in rrule schedule -
schema changes only for intermediate release (#224979)\n\n##
Summary\n\nThis PR contains the schema changes needed to support using
`dtstart` in\ntask manager rrule schedules. This is meant for
intermediate release and\nthen the changes will be used in this
PR:\nhttps://github.com//pull/224948\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"f43138c059047b5a73ea8fabbc976ed2fc09a6b9"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224979","number":224979,"mergeCommit":{"message":"[Response
Ops][Reporting][Task Manager] Allow setting dtstart in rrule schedule -
schema changes only for intermediate release (#224979)\n\n##
Summary\n\nThis PR contains the schema changes needed to support using
`dtstart` in\ntask manager rrule schedules. This is meant for
intermediate release and\nthen the changes will be used in this
PR:\nhttps://github.com//pull/224948\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"f43138c059047b5a73ea8fabbc976ed2fc09a6b9"}}]}]
BACKPORT-->

Co-authored-by: Ying Mao <ying.mao@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
ymao1 added a commit that referenced this pull request Jun 27, 2025
…in rrule schedule - schema changes only for intermediate release (#224979) (#225646)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Response Ops][Reporting][Task Manager] Allow setting dtstart in
rrule schedule - schema changes only for intermediate release
(#224979)](#224979)

<!--- Backport version: 10.0.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Ying
Mao","email":"ying.mao@elastic.co"},"sourceCommit":{"committedDate":"2025-06-27T14:05:28Z","message":"[Response
Ops][Reporting][Task Manager] Allow setting dtstart in rrule schedule -
schema changes only for intermediate release (#224979)\n\n##
Summary\n\nThis PR contains the schema changes needed to support using
`dtstart` in\ntask manager rrule schedules. This is meant for
intermediate release and\nthen the changes will be used in this
PR:\nhttps://github.com//pull/224948\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"f43138c059047b5a73ea8fabbc976ed2fc09a6b9","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Reporting:Framework","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Response
Ops][Reporting][Task Manager] Allow setting dtstart in rrule schedule -
schema changes only for intermediate
release","number":224979,"url":"https://github.com/elastic/kibana/pull/224979","mergeCommit":{"message":"[Response
Ops][Reporting][Task Manager] Allow setting dtstart in rrule schedule -
schema changes only for intermediate release (#224979)\n\n##
Summary\n\nThis PR contains the schema changes needed to support using
`dtstart` in\ntask manager rrule schedules. This is meant for
intermediate release and\nthen the changes will be used in this
PR:\nhttps://github.com//pull/224948\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"f43138c059047b5a73ea8fabbc976ed2fc09a6b9"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/225645","number":225645,"state":"OPEN"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224979","number":224979,"mergeCommit":{"message":"[Response
Ops][Reporting][Task Manager] Allow setting dtstart in rrule schedule -
schema changes only for intermediate release (#224979)\n\n##
Summary\n\nThis PR contains the schema changes needed to support using
`dtstart` in\ntask manager rrule schedules. This is meant for
intermediate release and\nthen the changes will be used in this
PR:\nhttps://github.com//pull/224948\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"f43138c059047b5a73ea8fabbc976ed2fc09a6b9"}}]}]
BACKPORT-->
kibanamachine added a commit that referenced this pull request Jul 1, 2025
… in rrule schedule (#224948) (#226047)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Response Ops][Reporting][Task Manager] Allow setting `dtstart` in
rrule schedule (#224948)](#224948)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Ying
Mao","email":"ying.mao@elastic.co"},"sourceCommit":{"committedDate":"2025-07-01T15:31:44Z","message":"[Response
Ops][Reporting][Task Manager] Allow setting `dtstart` in rrule schedule
(#224948)\n\n## Summary\n\n- Updates task manager `rrule` schedule to
allow for specifying an\noptional `dtstart` date time. Task manager will
use this to calculate\nthe first `runAt` for a recurring task (if
defined). Each subsequent\n`runAt` will continue to be calculated based
on the previous `runAt`\ntime.\n- Updates scheduled reporting API to use
this ability.\n\nIntermediate release PR for schema changes
only:\nhttps://github.com//pull/224979/files\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"29d210323cb4e15eb2c4b693eeeb8fbbf3d1324f","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Reporting:Framework","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Response
Ops][Reporting][Task Manager] Allow setting `dtstart` in rrule
schedule","number":224948,"url":"https://github.com/elastic/kibana/pull/224948","mergeCommit":{"message":"[Response
Ops][Reporting][Task Manager] Allow setting `dtstart` in rrule schedule
(#224948)\n\n## Summary\n\n- Updates task manager `rrule` schedule to
allow for specifying an\noptional `dtstart` date time. Task manager will
use this to calculate\nthe first `runAt` for a recurring task (if
defined). Each subsequent\n`runAt` will continue to be calculated based
on the previous `runAt`\ntime.\n- Updates scheduled reporting API to use
this ability.\n\nIntermediate release PR for schema changes
only:\nhttps://github.com//pull/224979/files\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"29d210323cb4e15eb2c4b693eeeb8fbbf3d1324f"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224948","number":224948,"mergeCommit":{"message":"[Response
Ops][Reporting][Task Manager] Allow setting `dtstart` in rrule schedule
(#224948)\n\n## Summary\n\n- Updates task manager `rrule` schedule to
allow for specifying an\noptional `dtstart` date time. Task manager will
use this to calculate\nthe first `runAt` for a recurring task (if
defined). Each subsequent\n`runAt` will continue to be calculated based
on the previous `runAt`\ntime.\n- Updates scheduled reporting API to use
this ability.\n\nIntermediate release PR for schema changes
only:\nhttps://github.com//pull/224979/files\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"29d210323cb4e15eb2c4b693eeeb8fbbf3d1324f"}}]}]
BACKPORT-->

Co-authored-by: Ying Mao <ying.mao@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Jul 1, 2025
…` in rrule schedule (#224948) (#226046)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Response Ops][Reporting][Task Manager] Allow setting `dtstart` in
rrule schedule (#224948)](#224948)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Ying
Mao","email":"ying.mao@elastic.co"},"sourceCommit":{"committedDate":"2025-07-01T15:31:44Z","message":"[Response
Ops][Reporting][Task Manager] Allow setting `dtstart` in rrule schedule
(#224948)\n\n## Summary\n\n- Updates task manager `rrule` schedule to
allow for specifying an\noptional `dtstart` date time. Task manager will
use this to calculate\nthe first `runAt` for a recurring task (if
defined). Each subsequent\n`runAt` will continue to be calculated based
on the previous `runAt`\ntime.\n- Updates scheduled reporting API to use
this ability.\n\nIntermediate release PR for schema changes
only:\nhttps://github.com//pull/224979/files\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"29d210323cb4e15eb2c4b693eeeb8fbbf3d1324f","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Reporting:Framework","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Response
Ops][Reporting][Task Manager] Allow setting `dtstart` in rrule
schedule","number":224948,"url":"https://github.com/elastic/kibana/pull/224948","mergeCommit":{"message":"[Response
Ops][Reporting][Task Manager] Allow setting `dtstart` in rrule schedule
(#224948)\n\n## Summary\n\n- Updates task manager `rrule` schedule to
allow for specifying an\noptional `dtstart` date time. Task manager will
use this to calculate\nthe first `runAt` for a recurring task (if
defined). Each subsequent\n`runAt` will continue to be calculated based
on the previous `runAt`\ntime.\n- Updates scheduled reporting API to use
this ability.\n\nIntermediate release PR for schema changes
only:\nhttps://github.com//pull/224979/files\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"29d210323cb4e15eb2c4b693eeeb8fbbf3d1324f"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224948","number":224948,"mergeCommit":{"message":"[Response
Ops][Reporting][Task Manager] Allow setting `dtstart` in rrule schedule
(#224948)\n\n## Summary\n\n- Updates task manager `rrule` schedule to
allow for specifying an\noptional `dtstart` date time. Task manager will
use this to calculate\nthe first `runAt` for a recurring task (if
defined). Each subsequent\n`runAt` will continue to be calculated based
on the previous `runAt`\ntime.\n- Updates scheduled reporting API to use
this ability.\n\nIntermediate release PR for schema changes
only:\nhttps://github.com//pull/224979/files\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"29d210323cb4e15eb2c4b693eeeb8fbbf3d1324f"}}]}]
BACKPORT-->

Co-authored-by: Ying Mao <ying.mao@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:Reporting:Framework Reporting issues pertaining to the overall framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.19.0 v9.1.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants