[Response Ops][Reporting][Task Manager] Allow setting `dtstart` in rrule schedule by ymao1 · Pull Request #224948 · elastic/kibana

ymao1 · 2025-06-23T18:59:40Z

Summary

Updates task manager rrule schedule to allow for specifying an optional dtstart date time. Task manager will use this to calculate the first runAt for a recurring task (if defined). Each subsequent runAt will continue to be calculated based on the previous runAt time.
Updates scheduled reporting API to use this ability.

Intermediate release PR for schema changes only: https://github.com/elastic/kibana/pull/224979/files

elasticmachine · 2025-06-25T17:18:45Z

Pinging @elastic/response-ops (Team:ResponseOps)

…t-tm-started-at

umbopepato · 2025-06-26T12:17:50Z

Thanks Ying! I drafted the UI integration with these changes in #225437, I just have some small comments:

I see that the type for dtstart is optional: we cannot make it required because of backward compatibility, right?
The original requirements for the scheduled reports functionality included a Make recurring toggle to choose between running only once on the start date or also make the report recurring. Are we adding support for that too? (Just to know if I have to reenable the toggle too in the form).

I'll review the code too in a minute! 🙂

ymao1 · 2025-06-26T12:29:17Z

I see that the type for dtstart is optional: we cannot make it required because of backward compatibility, right?

Yes that's correct. Will that be a problem?

The original requirements for the scheduled reports functionality included a Make recurring toggle to choose between running only once on the start date or also make the report recurring. Are we adding support for that too? (Just to know if I have to reenable the toggle too in the form).

I think the original requirement was making the assumption that the user flow would be something like Select export type > Open the flyout > Select between one-time or recurring vs our current flow which is Select export type or recurring > Open flyout. Given that, I don't think it makes sense to have that toggle when users have already clicked the Schedule export option. WDYT?

umbopepato

LGTM!

umbopepato · 2025-06-26T12:38:40Z

x-pack/platform/plugins/shared/task_manager/server/lib/get_first_run_at.ts

    try {
+      const dtstart = taskInstance.schedule.rrule.dtstart
+        ? new Date(taskInstance.schedule.rrule.dtstart)
+        : now;


Just to be sure: is now fine even if it's not in the timezone from the rrule?

cc @ersin-erdal

I think this is the problem Zach solved, so yeah it is ok.
tzid is used to generate the recurrences with the given day, hour, minute etc.
dtstart is the start date of the recurrences, tzid doesn't affect it.

I tested it with the below config:

rrule: { freq: 3, interval: 1, tzid: 'Europe/Minsk', --> GMT+3 dtstart: '2025-06-27T13:10:10.003Z', byhour: [19], byminute: [21], },

and the calculated nextRun is: 2025-06-27T16:21:10.003Z

umbopepato · 2025-06-26T12:43:37Z

x-pack/platform/plugins/shared/task_manager/server/lib/get_first_run_at.ts

-        dtstart: now,
+        dtstart,
      });
      return rrule.after(now)?.toISOString() || nowString;


This override is not reflected in the dtstart returned in the list API, right?

Correct, that dtstart should remain fixed

tiamliu · 2025-06-26T15:15:44Z

I see that the type for dtstart is optional: we cannot make it required because of backward compatibility, right?

Yes that's correct. Will that be a problem?

The original requirements for the scheduled reports functionality included a Make recurring toggle to choose between running only once on the start date or also make the report recurring. Are we adding support for that too? (Just to know if I have to reenable the toggle too in the form).

I think the original requirement was making the assumption that the user flow would be something like Select export type > Open the flyout > Select between one-time or recurring vs our current flow which is Select export type or recurring > Open flyout. Given that, I don't think it makes sense to have that toggle when users have already clicked the Schedule export option. WDYT?

I think the original toggle is to allow a one time scheduled export vs a recurring export. Aka, I would like to schedule a one time export for July 2nd or I would like to schedule the export for July 2nd and all following tuesdays on a weekly bases.

ymao1 · 2025-06-26T15:29:41Z

I think the original toggle is to allow a one time scheduled export vs a recurring export. Aka, I would like to schedule a one time export for July 2nd or I would like to schedule the export for July 2nd and all following tuesdays on a weekly bases.

Gotcha. I don't think we can support that right now.

…t-tm-started-at

ersin-erdal

LGTM
Tested locally, works as expected.

…e schedule - schema changes only for intermediate release (#224979) ## Summary This PR contains the schema changes needed to support using `dtstart` in task manager rrule schedules. This is meant for intermediate release and then the changes will be used in this PR: #224948 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…e schedule - schema changes only for intermediate release (elastic#224979) ## Summary This PR contains the schema changes needed to support using `dtstart` in task manager rrule schedules. This is meant for intermediate release and then the changes will be used in this PR: elastic#224948 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit f43138c)

…e schedule - schema changes only for intermediate release (elastic#224979) ## Summary This PR contains the schema changes needed to support using `dtstart` in task manager rrule schedules. This is meant for intermediate release and then the changes will be used in this PR: elastic#224948 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit f43138c) # Conflicts: # src/core/server/integration_tests/ci_checks/saved_objects/check_registered_types.test.ts

…n rrule schedule - schema changes only for intermediate release (#224979) (#225645) # Backport This will backport the following commits from `main` to `9.1`: - [[Response Ops][Reporting][Task Manager] Allow setting dtstart in rrule schedule - schema changes only for intermediate release (#224979)](#224979)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Ying Mao <ying.mao@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…in rrule schedule - schema changes only for intermediate release (#224979) (#225646) # Backport This will backport the following commits from `main` to `8.19`: - [[Response Ops][Reporting][Task Manager] Allow setting dtstart in rrule schedule - schema changes only for intermediate release (#224979)](#224979)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)

ymao1 · 2025-07-01T12:10:22Z

@elasticmachine merge upstream

elasticmachine · 2025-07-01T14:06:32Z

💚 Build Succeeded

Buildkite Build
Commit: 34b90fe

Metrics [docs]

✅ unchanged

History

💚 Build #313612 succeeded b4df5b6
💚 Build #313133 succeeded eead54e
💚 Build #312860 succeeded c9d9ffa
💔 Build #311711 failed ad71706
💔 Build #311700 failed 02b780f

cc @ymao1

kibanamachine · 2025-07-01T15:31:58Z

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16003724040

…ule schedule (elastic#224948) ## Summary - Updates task manager `rrule` schedule to allow for specifying an optional `dtstart` date time. Task manager will use this to calculate the first `runAt` for a recurring task (if defined). Each subsequent `runAt` will continue to be calculated based on the previous `runAt` time. - Updates scheduled reporting API to use this ability. Intermediate release PR for schema changes only: https://github.com/elastic/kibana/pull/224979/files --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 29d2103)

kibanamachine · 2025-07-01T15:39:02Z

💚 All backports created successfully

Status	Branch	Result
✅	8.19
✅	9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

… in rrule schedule (#224948) (#226047) # Backport This will backport the following commits from `main` to `9.1`: - [[Response Ops][Reporting][Task Manager] Allow setting `dtstart` in rrule schedule (#224948)](#224948)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Ying Mao <ying.mao@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…` in rrule schedule (#224948) (#226046) # Backport This will backport the following commits from `main` to `8.19`: - [[Response Ops][Reporting][Task Manager] Allow setting `dtstart` in rrule schedule (#224948)](#224948)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Ying Mao <ying.mao@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…ule schedule (elastic#224948) ## Summary - Updates task manager `rrule` schedule to allow for specifying an optional `dtstart` date time. Task manager will use this to calculate the first `runAt` for a recurring task (if defined). Each subsequent `runAt` will continue to be calculated based on the previous `runAt` time. - Updates scheduled reporting API to use this ability. Intermediate release PR for schema changes only: https://github.com/elastic/kibana/pull/224979/files --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

ymao1 force-pushed the scheduled-report-tm-started-at branch from 34ab1df to 02b780f Compare June 23, 2025 19:38

ymao1 changed the title ~~Scheduled report tm started at~~ [Response Ops][Reporting][Task Manager] Allow setting dtstart in rrule schedule Jun 23, 2025

Allow specifying dtstart for task manager rrule schedule

b24e2c6

ymao1 force-pushed the scheduled-report-tm-started-at branch from ad71706 to b24e2c6 Compare June 23, 2025 23:38

ymao1 mentioned this pull request Jun 23, 2025

[Response Ops][Reporting][Task Manager] Allow setting dtstart in rrule schedule - schema changes only for intermediate release #224979

Merged

ymao1 added 3 commits June 23, 2025 20:16

Schema changes for intermediate release

8a1ff63

Merging in schema changes

a877b4d

Cleanup

bd0f53c

ymao1 self-assigned this Jun 25, 2025

ymao1 marked this pull request as ready for review June 25, 2025 17:18

ymao1 requested review from a team as code owners June 25, 2025 17:18

ymao1 requested review from ersin-erdal and umbopepato June 25, 2025 17:20

ymao1 added 2 commits June 25, 2025 17:38

PR feedback

a944700

Merge branch 'main' of github.com:elastic/kibana into scheduled-repor…

c9d9ffa

…t-tm-started-at

umbopepato mentioned this pull request Jun 26, 2025

[ResponseOps][Reporting] Re-enable start date field in scheduled reports flyout #225437

Merged

umbopepato approved these changes Jun 26, 2025

View reviewed changes

PR feedback

4f909e9

Merge branch 'main' of github.com:elastic/kibana into scheduled-repor…

eead54e

…t-tm-started-at

ersin-erdal approved these changes Jun 26, 2025

View reviewed changes

Merge

b4df5b6

ymao1 removed the request for review from a team June 27, 2025 16:35

Merge branch 'main' into scheduled-report-tm-started-at

34b90fe

ymao1 merged commit 29d2103 into elastic:main Jul 1, 2025
10 checks passed

ymao1 deleted the scheduled-report-tm-started-at branch July 1, 2025 15:31

kibanamachine mentioned this pull request Jul 1, 2025

[8.19] [Response Ops][Reporting][Task Manager] Allow setting dtstart in rrule schedule (#224948) #226046

Merged

kibanamachine mentioned this pull request Jul 1, 2025

[9.1] [Response Ops][Reporting][Task Manager] Allow setting dtstart in rrule schedule (#224948) #226047

Merged

ymao1 mentioned this pull request Jul 3, 2025

[Response Ops][Task Manager] Allow setting startdate in task manager rrule schedule interval #224707

Closed

Comments

Conversation

ymao1 commented Jun 23, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Jun 25, 2025

Uh oh!

umbopepato commented Jun 26, 2025

Uh oh!

ymao1 commented Jun 26, 2025

Uh oh!

umbopepato left a comment

Choose a reason for hiding this comment

Uh oh!

umbopepato Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

ymao1 Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

ersin-erdal Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

umbopepato Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

ymao1 Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

tiamliu commented Jun 26, 2025

Uh oh!

ymao1 commented Jun 26, 2025

Uh oh!

ersin-erdal left a comment

Choose a reason for hiding this comment

Uh oh!

ymao1 commented Jul 1, 2025

Uh oh!

elasticmachine commented Jul 1, 2025

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

Uh oh!

kibanamachine commented Jul 1, 2025

Uh oh!

kibanamachine commented Jul 1, 2025

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ymao1 commented Jun 23, 2025 •

edited by kibanamachine

Loading