Skip to content

[Streams 🌊] Improve warning on missing simulation samples #224405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonyghiani merged 5 commits into from
Jun 23, 2025
Merged

[Streams 🌊] Improve warning on missing simulation samples #224405

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9b6b83
feat(streams): warn on missing samples
tonyghiani Jun 18, 2025
43b5538
feat(streams): hide table filters on missing docs
tonyghiani Jun 18, 2025
b8aa04d
Merge branch 'main' into 212728-warn-on-missing-samples
tonyghiani Jun 20, 2025
f9eff05
Merge branch 'main' into 212728-warn-on-missing-samples
tonyghiani Jun 20, 2025
fa81553
Merge branch 'main' into 212728-warn-on-missing-samples
tonyghiani Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 33 additions & 30 deletions .../public/components/data_management/stream_detail_enrichment/processor_outcome_preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import { isEmpty } from 'lodash';
import { Sample } from '@kbn/grok-ui';
import { GrokProcessorDefinition } from '@kbn/streams-schema';
import { PreviewTable } from '../preview_table';
import { AssetImage } from '../../asset_image';
import {
useSimulatorSelector,
useStreamEnrichmentEvents,
Expand All @@ -38,9 +37,41 @@ import { WithUIAttributes } from './types';

export const ProcessorOutcomePreview = () => {
const isLoading = useSimulatorSelector(
(state) => state.matches('debouncingChanges') || state.matches('runningSimulation')
(snapshot) => snapshot.matches('debouncingChanges') || snapshot.matches('runningSimulation')
);
const previewDocuments = useSimulatorSelector((snapshot) =>
selectPreviewDocuments(snapshot.context)
);

if (isEmpty(previewDocuments)) {
return (
<EuiEmptyPrompt
color="warning"
iconType="warning"
titleSize="s"
title={
<h2>
{i18n.translate(
'xpack.streams.streamDetailView.managementTab.enrichment.processor.outcomePreviewTable.noDataTitle',
{ defaultMessage: 'No data available to validate processor changes' }
)}
</h2>
}
body={
<p>
{i18n.translate(
'xpack.streams.streamDetailView.managementTab.enrichment.processor.outcomePreviewTable.noDataBody',
{
defaultMessage:
'Changes will be applied, but we can’t confirm they’ll work as expected. Proceed with caution.',
}
)}
</p>
}
/>
);
}

return (
<>
<EuiFlexItem grow={false}>
Expand Down Expand Up @@ -246,34 +277,6 @@ const OutcomePreviewTable = () => {
setPreviewColumnsOrder(visibleColumns);
};

if (!previewDocuments || isEmpty(previewDocuments)) {
return (
<EuiEmptyPrompt
titleSize="xs"
icon={<AssetImage type="unableToGeneratePreview" />}
title={
<h2>
{i18n.translate(
'xpack.streams.streamDetailView.managementTab.rootStreamEmptyPrompt.noDataTitle',
{ defaultMessage: 'Unable to generate a preview' }
)}
</h2>
}
body={
<p>
{i18n.translate(
'xpack.streams.streamDetailView.managementTab.enrichment.processor.outcomePreviewTable.noDataBody',
{
defaultMessage:
"There are no sample documents to test the processors. Try updating the time range or ingesting more data, it might be possible we could not find any matching documents with the processors' source fields.",
}
)}
</p>
}
/>
);
}

return (
<PreviewTable
documents={previewDocuments}
Expand Down