Skip to content

[Streams 🌊] Improve warning on missing simulation samples#224405

Merged
tonyghiani merged 5 commits intoelastic:mainfrom
tonyghiani:212728-warn-on-missing-samples
Jun 23, 2025
Merged

[Streams 🌊] Improve warning on missing simulation samples#224405
tonyghiani merged 5 commits intoelastic:mainfrom
tonyghiani:212728-warn-on-missing-samples

Conversation

@tonyghiani
Copy link
Contributor

@tonyghiani tonyghiani commented Jun 18, 2025

📓 Summary

Closes #212728

There was already an empty prompt in place when samples are not available for the simulation; this change makes it clearer that pipeline changes can be saved, but we can't confirm they'll work correctly.

Screenshot 2025-06-18 at 12 39 57

@tonyghiani tonyghiani requested a review from a team as a code owner June 18, 2025 10:41
@tonyghiani tonyghiani added release_note:skip Skip the PR/issue when compiling release notes Team:obs-onboarding Observability Onboarding Team backport:version Backport to applied version labels Feature:Streams This is the label for the Streams Project v9.1.0 v8.19.0 labels Jun 18, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@tonyghiani tonyghiani changed the title feat(streams): warn on missing samples [Streams 🌊] Improve warning on missing simulation samples Jun 18, 2025
@tonyghiani
Copy link
Contributor Author

Waiting for #219736 to be merged so that hiding the date picker won't break the UX

@tonyghiani tonyghiani self-assigned this Jun 20, 2025
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 541.0KB 540.9KB -46.0B

History

cc @tonyghiani

@tonyghiani tonyghiani enabled auto-merge (squash) June 23, 2025 07:02
@tonyghiani tonyghiani merged commit cac001b into elastic:main Jun 23, 2025
10 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15818279345

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.19:
- [Streams 🌊] Listing and overview page improvements (#223603)

Manual backport

To create the backport manually run:

node scripts/backport --pr 224405

Questions ?

Please refer to the Backport tool documentation

@tonyghiani tonyghiani added backport:version Backport to applied version labels and removed backport:version Backport to applied version labels labels Jun 23, 2025
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15822351171

@tonyghiani tonyghiani deleted the 212728-warn-on-missing-samples branch June 23, 2025 10:56
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 23, 2025
…4405)

## 📓 Summary

Closes elastic#212728

There was already an empty prompt in place when samples are not
available for the simulation; this change makes it clearer that pipeline
changes can be saved, but we can't confirm they'll work correctly.

<img width="3006" alt="Screenshot 2025-06-18 at 12 39 57"
src="https://github.com/user-attachments/assets/c4dc7d4e-7634-4790-a356-b3de07098adb"
/>

(cherry picked from commit cac001b)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 23, 2025
…4405) (#224846)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Streams 🌊] Improve warning on missing simulation samples
(#224405)](#224405)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Marco Antonio
Ghiani","email":"marcoantonio.ghiani01@gmail.com"},"sourceCommit":{"committedDate":"2025-06-23T07:42:52Z","message":"[Streams
🌊] Improve warning on missing simulation samples (#224405)\n\n## 📓
Summary\n\nCloses #212728 \n\nThere was already an empty prompt in place
when samples are not\navailable for the simulation; this change makes it
clearer that pipeline\nchanges can be saved, but we can't confirm
they'll work correctly.\n\n<img width=\"3006\" alt=\"Screenshot
2025-06-18 at 12 39
57\"\nsrc=\"https://github.com/user-attachments/assets/c4dc7d4e-7634-4790-a356-b3de07098adb\"\n/>","sha":"cac001b61539950f4b0c166dcd7cc21bf5dd550e","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-logs","backport:version","Feature:Streams","v9.1.0","v8.19.0"],"title":"[Streams
🌊] Improve warning on missing simulation
samples","number":224405,"url":"https://github.com/elastic/kibana/pull/224405","mergeCommit":{"message":"[Streams
🌊] Improve warning on missing simulation samples (#224405)\n\n## 📓
Summary\n\nCloses #212728 \n\nThere was already an empty prompt in place
when samples are not\navailable for the simulation; this change makes it
clearer that pipeline\nchanges can be saved, but we can't confirm
they'll work correctly.\n\n<img width=\"3006\" alt=\"Screenshot
2025-06-18 at 12 39
57\"\nsrc=\"https://github.com/user-attachments/assets/c4dc7d4e-7634-4790-a356-b3de07098adb\"\n/>","sha":"cac001b61539950f4b0c166dcd7cc21bf5dd550e"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224405","number":224405,"mergeCommit":{"message":"[Streams
🌊] Improve warning on missing simulation samples (#224405)\n\n## 📓
Summary\n\nCloses #212728 \n\nThere was already an empty prompt in place
when samples are not\navailable for the simulation; this change makes it
clearer that pipeline\nchanges can be saved, but we can't confirm
they'll work correctly.\n\n<img width=\"3006\" alt=\"Screenshot
2025-06-18 at 12 39
57\"\nsrc=\"https://github.com/user-attachments/assets/c4dc7d4e-7634-4790-a356-b3de07098adb\"\n/>","sha":"cac001b61539950f4b0c166dcd7cc21bf5dd550e"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request Jun 25, 2025
…4405)

## 📓 Summary

Closes elastic#212728 

There was already an empty prompt in place when samples are not
available for the simulation; this change makes it clearer that pipeline
changes can be saved, but we can't confirm they'll work correctly.

<img width="3006" alt="Screenshot 2025-06-18 at 12 39 57"
src="https://github.com/user-attachments/assets/c4dc7d4e-7634-4790-a356-b3de07098adb"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes Team:obs-onboarding Observability Onboarding Team v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Streams 🌊] Enrichment - Warn user on changes without data samples

4 participants