-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[streams] enable streams ui setting #224111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
klacabane
merged 10 commits into
elastic:main
from
klacabane:enable-streams-ui-advanced-setting
Jun 19, 2025
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ca17fdb
streams ui setting
klacabane f81be4c
enable
klacabane 3a69a51
default to true for serverless oblt
klacabane c7a8c33
Merge branch 'main' into enable-streams-ui-advanced-setting
klacabane 297b748
serverless allow list
klacabane d8cd42c
[CI] Auto-commit changed files from 'node scripts/styled_components_m…
kibanamachine 84b457a
telemetry --fix
klacabane 2459267
rename setting to Streams UI
klacabane 4ece772
Merge branch 'main' into enable-streams-ui-advanced-setting
klacabane 72bef1d
Merge branch 'main' into enable-streams-ui-advanced-setting
klacabane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,8 @@ import { KibanaFeatureScope } from '@kbn/features-plugin/common'; | |
| import { i18n } from '@kbn/i18n'; | ||
| import { STREAMS_RULE_TYPE_IDS } from '@kbn/rule-data-utils'; | ||
| import { registerRoutes } from '@kbn/server-route-repository'; | ||
| import { schema } from '@kbn/config-schema'; | ||
| import { OBSERVABILITY_ENABLE_STREAMS_UI } from '@kbn/management-settings-ids'; | ||
| import { StreamsConfig, configSchema, exposeToBrowserConfig } from '../common/config'; | ||
| import { | ||
| STREAMS_API_PRIVILEGES, | ||
|
|
@@ -63,7 +65,7 @@ export class StreamsPlugin | |
| public logger: Logger; | ||
| public server?: StreamsServer; | ||
| private isDev: boolean; | ||
| private telemtryService = new StreamsTelemetryService(); | ||
| private telemetryService = new StreamsTelemetryService(); | ||
|
|
||
| constructor(context: PluginInitializerContext<StreamsConfig>) { | ||
| this.isDev = context.env.mode.dev; | ||
|
|
@@ -80,7 +82,7 @@ export class StreamsPlugin | |
| logger: this.logger, | ||
| } as StreamsServer; | ||
|
|
||
| this.telemtryService.setup(core.analytics); | ||
| this.telemetryService.setup(core.analytics); | ||
|
|
||
| const isSignificantEventsEnabled = this.config.experimental?.significantEventsEnabled === true; | ||
| const alertingFeatures = isSignificantEventsEnabled | ||
|
|
@@ -157,7 +159,7 @@ export class StreamsPlugin | |
| dependencies: { | ||
| assets: assetService, | ||
| server: this.server, | ||
| telemetry: this.telemtryService.getClient(), | ||
| telemetry: this.telemetryService.getClient(), | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 😌 |
||
| getScopedClients: async ({ | ||
| request, | ||
| }: { | ||
|
|
@@ -200,6 +202,30 @@ export class StreamsPlugin | |
| runDevModeChecks: this.isDev, | ||
| }); | ||
|
|
||
| const isObservabilityServerless = | ||
| plugins.cloud?.isServerlessEnabled && | ||
| plugins.cloud?.serverless.projectType === 'observability'; | ||
| core.uiSettings.register({ | ||
| [OBSERVABILITY_ENABLE_STREAMS_UI]: { | ||
| category: ['observability'], | ||
| name: 'Streams UI', | ||
| value: isObservabilityServerless, | ||
| description: i18n.translate('xpack.streams.enableStreamsUIDescription', { | ||
| defaultMessage: '{technicalPreviewLabel} Enable the {streamsLink}.', | ||
| values: { | ||
| technicalPreviewLabel: `<em>[${i18n.translate('xpack.streams.technicalPreviewLabel', { | ||
| defaultMessage: 'Technical Preview', | ||
| })}]</em>`, | ||
| streamsLink: `<a href="https://www.elastic.co/docs/solutions/observability/logs/streams/streams">Streams UI</href>`, | ||
| }, | ||
| }), | ||
| type: 'boolean', | ||
| schema: schema.boolean(), | ||
| requiresPageReload: true, | ||
| solution: 'oblt', | ||
| }, | ||
| }); | ||
|
|
||
| return {}; | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Settings allow list for serverless