Skip to content

[streams] enable streams ui setting#224111

Merged
klacabane merged 10 commits intoelastic:mainfrom
klacabane:enable-streams-ui-advanced-setting
Jun 19, 2025
Merged

[streams] enable streams ui setting#224111
klacabane merged 10 commits intoelastic:mainfrom
klacabane:enable-streams-ui-advanced-setting

Conversation

@klacabane
Copy link
Copy Markdown
Contributor

@klacabane klacabane commented Jun 16, 2025 •
edited by kibanamachine
Loading

Summary

Add an advanced setting to enable streams UI. The setting is enabled by default for observability serverless deployment

enable_streams_ui

Testing

  • yarn start --serverless oblt - streams UI is activated by default - do not forget to set xpack.cloud.serverless.project_id: test-123 to have a proper serverless deployment
  • yarn start - streams UI is not activated by default

@klacabane klacabane self-assigned this Jun 16, 2025
@klacabane klacabane added release_note:skip Skip the PR/issue when compiling release notes Team:obs-onboarding Observability Onboarding Team backport:version Backport to applied version labels Feature:Streams This is the label for the Streams Project v9.1.0 v8.19.0 labels Jun 16, 2025
@klacabane klacabane added the ci:project-deploy-observability Create an Observability project label Jun 17, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 17, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@flash1293
Copy link
Copy Markdown
Contributor

flash1293 commented Jun 17, 2025

@klacabane Is this ready for review?

@klacabane klacabane marked this pull request as ready for review June 17, 2025 08:11
@klacabane klacabane requested review from a team as code owners June 17, 2025 08:11
klacabane
klacabane commented Jun 17, 2025
View reviewed changes
src/platform/packages/shared/serverless/settings/observability_project/index.ts
settings.OBSERVABILITY_AI_ASSISTANT_SIMULATED_FUNCTION_CALLING,
settings.OBSERVABILITY_AI_ASSISTANT_SEARCH_CONNECTOR_INDEX_PATTERN,
settings.OBSERVABILITY_LOGS_DATA_ACCESS_LOG_SOURCES_ID,
settings.OBSERVABILITY_ENABLE_STREAMS_UI,
Copy link
Copy Markdown
Contributor Author

@klacabane klacabane Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Settings allow list for serverless

sabarasaba
sabarasaba approved these changes Jun 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana management changes lgtm

@klacabane klacabane requested review from a team as code owners June 17, 2025 13:58
ddillinger
ddillinger approved these changes Jun 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ddillinger ddillinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

telemetry schema ✅

kdelemme
kdelemme approved these changes Jun 17, 2025
View reviewed changes
x-pack/platform/plugins/shared/streams/server/plugin.ts
assets: assetService,
server: this.server,
telemetry: this.telemtryService.getClient(),
telemetry: this.telemetryService.getClient(),
Copy link
Copy Markdown
Contributor

@kdelemme kdelemme Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😌

@miltonhultgren
Copy link
Copy Markdown
Contributor

miltonhultgren commented Jun 18, 2025

@klacabane What do you think about the suggestion I made here?

@klacabane klacabane enabled auto-merge (squash) June 19, 2025 10:38
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 19, 2025

⏳ Build in-progress

  • Buildkite Build
  • Commit: 72bef1d
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-224111-72bef1d31172

History

cc @klacabane

@klacabane klacabane merged commit 7f63d9d into elastic:main Jun 19, 2025
10 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 19, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15758193874

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 19, 2025
@klacabane @kibanamachine
[streams] enable streams ui setting (elastic#224111)
b22af2a 
## Summary
Add an advanced setting to enable streams UI. The setting is enabled by
default for observability serverless deployment

![enable_streams_ui](https://github.com/user-attachments/assets/5e533ab5-ca73-40e4-bbe7-89e9e1c6659c)

### Testing
- `yarn start --serverless oblt` - streams UI is activated by default -
do not forget to set `xpack.cloud.serverless.project_id: test-123` to
have a proper serverless deployment
- `yarn start` - streams UI is not activated by default

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 7f63d9d)
@kibanamachine kibanamachine mentioned this pull request Jun 19, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 19, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Jun 19, 2025
Merged
7 tasks
kibanamachine added a commit that referenced this pull request Jun 19, 2025
@kibanamachine @klacabane
[8.19] [streams] enable streams ui setting (#224111) (#224566)
ed78b05 
# Backport

This will backport the following commits from `main` to `8.19`:
- [[streams] enable streams ui setting
(#224111)](#224111)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Lacabane","email":"kevin.lacabane@elastic.co"},"sourceCommit":{"committedDate":"2025-06-19T12:45:36Z","message":"[streams]
enable streams ui setting (#224111)\n\n## Summary\nAdd an advanced
setting to enable streams UI. The setting is enabled by\ndefault for
observability serverless
deployment\n\n\n![enable_streams_ui](https://github.com/user-attachments/assets/5e533ab5-ca73-40e4-bbe7-89e9e1c6659c)\n\n###
Testing\n- `yarn start --serverless oblt` - streams UI is activated by
default -\ndo not forget to set `xpack.cloud.serverless.project_id:
test-123` to\nhave a proper serverless deployment\n- `yarn start` -
streams UI is not activated by default\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"7f63d9d08d7c414fe04e7232d70e205cf903849b","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:project-deploy-observability","Team:obs-ux-logs","backport:version","Feature:Streams","v9.1.0","v8.19.0"],"title":"[streams]
enable streams ui
setting","number":224111,"url":"https://github.com/elastic/kibana/pull/224111","mergeCommit":{"message":"[streams]
enable streams ui setting (#224111)\n\n## Summary\nAdd an advanced
setting to enable streams UI. The setting is enabled by\ndefault for
observability serverless
deployment\n\n\n![enable_streams_ui](https://github.com/user-attachments/assets/5e533ab5-ca73-40e4-bbe7-89e9e1c6659c)\n\n###
Testing\n- `yarn start --serverless oblt` - streams UI is activated by
default -\ndo not forget to set `xpack.cloud.serverless.project_id:
test-123` to\nhave a proper serverless deployment\n- `yarn start` -
streams UI is not activated by default\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"7f63d9d08d7c414fe04e7232d70e205cf903849b"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224111","number":224111,"mergeCommit":{"message":"[streams]
enable streams ui setting (#224111)\n\n## Summary\nAdd an advanced
setting to enable streams UI. The setting is enabled by\ndefault for
observability serverless
deployment\n\n\n![enable_streams_ui](https://github.com/user-attachments/assets/5e533ab5-ca73-40e4-bbe7-89e9e1c6659c)\n\n###
Testing\n- `yarn start --serverless oblt` - streams UI is activated by
default -\ndo not forget to set `xpack.cloud.serverless.project_id:
test-123` to\nhave a proper serverless deployment\n- `yarn start` -
streams UI is not activated by default\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"7f63d9d08d7c414fe04e7232d70e205cf903849b"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Kevin Lacabane <kevin.lacabane@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sabarasaba sabarasaba sabarasaba approved these changes

@kdelemme kdelemme kdelemme approved these changes

@Dosant Dosant Dosant approved these changes

@dokmic dokmic dokmic approved these changes

+1 more reviewer

@ddillinger ddillinger ddillinger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@klacabane klacabane

Labels

backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes Team:obs-onboarding Observability Onboarding Team v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@klacabane @flash1293 @miltonhultgren @elasticmachine @kibanamachine @ddillinger @sabarasaba @kdelemme @Dosant @dokmic