[8.19] [Security Solution] Rename isPreview prop to isRulePreview (#214639)#223583
Merged
christineweng merged 6 commits intoelastic:8.19from Jun 18, 2025
Merged
Conversation
…14639) ## Summary Dependency: elastic#223321 to be merged first This PR renamed `isPreview` to `isRulePreview` in the document details code. A clearer distinction between `isPreview` and `isPreviewMode` helps improve comprehensibility and avoid mixing them up. In some UI components, rule preview is not part of any logic, they are renamed to something more explicit. - In `SuppressedAlerts`, `isPreview` is now `showInvestigateInTimeline` - In `Assignee`, `isPreview` is now `showAssignees` (opposite check) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 3a08e64) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/flyout/document_details/left/index.tsx # x-pack/solutions/security/plugins/security_solution/public/flyout/document_details/right/components/analyzer_preview_container.test.tsx # x-pack/solutions/security/plugins/security_solution/public/flyout/document_details/right/components/graph_preview_container.tsx # x-pack/solutions/security/plugins/security_solution/public/flyout/document_details/right/components/session_preview_container.test.tsx
2 tasks
PhilippeOberti
approved these changes
Jun 17, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation