[Security Solution] Remove unneeded isPreview prop in highlighted fields#223321
Merged
christineweng merged 1 commit intoelastic:mainfrom Jun 11, 2025
Merged
[Security Solution] Remove unneeded isPreview prop in highlighted fields#223321christineweng merged 1 commit intoelastic:mainfrom
christineweng merged 1 commit intoelastic:mainfrom
Conversation
christineweng
added
release_note:skip
christineweng
force-pushed
the
hf-clean-up
branch
from
eefa0d3 to
dfb41b0
Compare
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
2 tasks
PhilippeOberti
approved these changes
Jun 11, 2025
Contributor
PhilippeOberti
left a comment
PhilippeOberti
left a comment
There was a problem hiding this comment.
Desk tested and code LGTM. Thank you for this nice cleanup!
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15590138017 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 task
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
christineweng
added a commit
to christineweng/kibana
that referenced
this pull request
Jun 11, 2025
…lds (elastic#223321) ## Summary `isPreview` check is not used and no longer needed. No change to UI ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 1ca1e79)
christineweng
added a commit
that referenced
this pull request
Jun 11, 2025
…ted fields (#223321) (#223469) # Backport This will backport the following commits from `main` to `8.19`: - [[Security Solution] Remove unneeded isPreview prop in highlighted fields (#223321)](#223321) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-06-11T16:15:57Z","message":"[Security Solution] Remove unneeded isPreview prop in highlighted fields (#223321)\n\n## Summary\n\n`isPreview` check is not used and no longer needed. No change to UI\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"1ca1e7981377524ef898f8ca77a69bd82ac90b9b","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","backport:version","v9.1.0","v8.19.0"],"title":"[Security Solution] Remove unneeded isPreview prop in highlighted fields","number":223321,"url":"https://github.com/elastic/kibana/pull/223321","mergeCommit":{"message":"[Security Solution] Remove unneeded isPreview prop in highlighted fields (#223321)\n\n## Summary\n\n`isPreview` check is not used and no longer needed. No change to UI\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"1ca1e7981377524ef898f8ca77a69bd82ac90b9b"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/223321","number":223321,"mergeCommit":{"message":"[Security Solution] Remove unneeded isPreview prop in highlighted fields (#223321)\n\n## Summary\n\n`isPreview` check is not used and no longer needed. No change to UI\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"1ca1e7981377524ef898f8ca77a69bd82ac90b9b"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
christineweng
added a commit
that referenced
this pull request
Jun 12, 2025
## Summary Dependency: #223321 to be merged first This PR renamed `isPreview` to `isRulePreview` in the document details code. A clearer distinction between `isPreview` and `isPreviewMode` helps improve comprehensibility and avoid mixing them up. In some UI components, rule preview is not part of any logic, they are renamed to something more explicit. - In `SuppressedAlerts`, `isPreview` is now `showInvestigateInTimeline` - In `Assignee`, `isPreview` is now `showAssignees` (opposite check) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
christineweng
added a commit
to christineweng/kibana
that referenced
this pull request
Jun 12, 2025
…14639) ## Summary Dependency: elastic#223321 to be merged first This PR renamed `isPreview` to `isRulePreview` in the document details code. A clearer distinction between `isPreview` and `isPreviewMode` helps improve comprehensibility and avoid mixing them up. In some UI components, rule preview is not part of any logic, they are renamed to something more explicit. - In `SuppressedAlerts`, `isPreview` is now `showInvestigateInTimeline` - In `Assignee`, `isPreview` is now `showAssignees` (opposite check) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 3a08e64) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/flyout/document_details/left/index.tsx # x-pack/solutions/security/plugins/security_solution/public/flyout/document_details/right/components/analyzer_preview_container.test.tsx # x-pack/solutions/security/plugins/security_solution/public/flyout/document_details/right/components/graph_preview_container.tsx # x-pack/solutions/security/plugins/security_solution/public/flyout/document_details/right/components/session_preview_container.test.tsx
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Jun 12, 2025
…lds (elastic#223321) ## Summary `isPreview` check is not used and no longer needed. No change to UI ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
iblancof
pushed a commit
to iblancof/kibana
that referenced
this pull request
Jun 16, 2025
…lds (elastic#223321) ## Summary `isPreview` check is not used and no longer needed. No change to UI ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
iblancof
pushed a commit
to iblancof/kibana
that referenced
this pull request
Jun 16, 2025
…14639) ## Summary Dependency: elastic#223321 to be merged first This PR renamed `isPreview` to `isRulePreview` in the document details code. A clearer distinction between `isPreview` and `isPreviewMode` helps improve comprehensibility and avoid mixing them up. In some UI components, rule preview is not part of any logic, they are renamed to something more explicit. - In `SuppressedAlerts`, `isPreview` is now `showInvestigateInTimeline` - In `Assignee`, `isPreview` is now `showAssignees` (opposite check) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
christineweng
added a commit
that referenced
this pull request
Jun 18, 2025
…14639) (#223583) # Backport This will backport the following commits from `main` to `8.19`: - [[Security Solution] Rename isPreview prop to isRulePreview (#214639)](#214639) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-06-12T15:11:35Z","message":"[Security Solution] Rename isPreview prop to isRulePreview (#214639)\n\n## Summary\n\nDependency: #223321 to be merged\nfirst\n\nThis PR renamed `isPreview` to `isRulePreview` in the document details\ncode. A clearer distinction between `isPreview` and `isPreviewMode`\nhelps improve comprehensibility and avoid mixing them up.\n\nIn some UI components, rule preview is not part of any logic, they are\nrenamed to something more explicit.\n- In `SuppressedAlerts`, `isPreview` is now `showInvestigateInTimeline`\n- In `Assignee`, `isPreview` is now `showAssignees` (opposite check) \n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"3a08e64a543dc3831248f681575357a078ae6fee","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","backport:version","v9.1.0","v8.19.0"],"title":"[Security Solution] Rename isPreview prop to isRulePreview","number":214639,"url":"https://github.com/elastic/kibana/pull/214639","mergeCommit":{"message":"[Security Solution] Rename isPreview prop to isRulePreview (#214639)\n\n## Summary\n\nDependency: #223321 to be merged\nfirst\n\nThis PR renamed `isPreview` to `isRulePreview` in the document details\ncode. A clearer distinction between `isPreview` and `isPreviewMode`\nhelps improve comprehensibility and avoid mixing them up.\n\nIn some UI components, rule preview is not part of any logic, they are\nrenamed to something more explicit.\n- In `SuppressedAlerts`, `isPreview` is now `showInvestigateInTimeline`\n- In `Assignee`, `isPreview` is now `showAssignees` (opposite check) \n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"3a08e64a543dc3831248f681575357a078ae6fee"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214639","number":214639,"mergeCommit":{"message":"[Security Solution] Rename isPreview prop to isRulePreview (#214639)\n\n## Summary\n\nDependency: #223321 to be merged\nfirst\n\nThis PR renamed `isPreview` to `isRulePreview` in the document details\ncode. A clearer distinction between `isPreview` and `isPreviewMode`\nhelps improve comprehensibility and avoid mixing them up.\n\nIn some UI components, rule preview is not part of any logic, they are\nrenamed to something more explicit.\n- In `SuppressedAlerts`, `isPreview` is now `showInvestigateInTimeline`\n- In `Assignee`, `isPreview` is now `showAssignees` (opposite check) \n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"3a08e64a543dc3831248f681575357a078ae6fee"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isPreviewcheck is not used and no longer needed. No change to UIChecklist
release_note:*label is applied per the guidelines