Skip to content

[8.19] [Discover] Support setting columns in Discover session embeddable (#222858)#223281

Merged
davismcphee merged 4 commits intoelastic:8.19from
davismcphee:backport/8.19/pr-222858
Jun 12, 2025
Merged

[8.19] [Discover] Support setting columns in Discover session embeddable (#222858)#223281
davismcphee merged 4 commits intoelastic:8.19from
davismcphee:backport/8.19/pr-222858

Conversation

@davismcphee
Copy link
Contributor

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

…astic#222858)

## Summary

This PR adds support for consumers to set columns in the Discover
session embeddable, and updates `SavedSearchComponent` to make use of
it. This is a requirement for some usages of the embedded logs component
where specific columns are needed.

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 7cf1fa2)

# Conflicts:
#	src/platform/plugins/shared/discover/public/embeddable/initialize_search_embeddable_api.tsx
@davismcphee davismcphee added the backport This PR is a backport of another PR label Jun 10, 2025
@davismcphee davismcphee enabled auto-merge (squash) June 10, 2025 18:47
@davismcphee davismcphee self-assigned this Jun 10, 2025
@davismcphee davismcphee added the Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// label Jun 10, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/saved-search-component 14 15 +1
discover 95 98 +3
total +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.7MB 2.7MB +102.0B
discover 1.1MB 1.1MB +34.0B
logsShared 219.5KB 219.6KB +102.0B
total +238.0B
Unknown metric groups

API count

id before after diff
@kbn/saved-search-component 15 16 +1
discover 144 147 +3
total +4

History

cc @davismcphee

@davismcphee davismcphee merged commit 4f9b42a into elastic:8.19 Jun 12, 2025
8 checks passed
@davismcphee davismcphee deleted the backport/8.19/pr-222858 branch June 13, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t//

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants