[Discover] Support setting columns in Discover session embeddable by davismcphee · Pull Request #222858 · elastic/kibana

davismcphee · 2025-06-05T16:58:49Z

Summary

This PR adds support for consumers to set columns in the Discover session embeddable, and updates SavedSearchComponent to make use of it. This is a requirement for some usages of the embedded logs component where specific columns are needed.

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

elasticmachine · 2025-06-07T01:25:49Z

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

elasticmachine · 2025-06-10T04:31:46Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 4150b70

Failed CI Steps

Jest Tests #1

Test Failures

[job] [logs] Jest Tests #1 / UserActionMarkdown errors Shows error message and save button disabled if current text is empty

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/saved-search-component`	14	15	+1
`discover`	153	156	+3
total			+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	2.6MB	2.6MB	+102.0B
`discover`	1.1MB	1.1MB	+34.0B
`logsShared`	200.8KB	200.9KB	+102.0B
total			+238.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/saved-search-component`	15	16	+1
`discover`	204	207	+3
total			+4

History

💚 Build #306408 succeeded 9fcb9ca
💔 Build #306359 failed dfd6091
💔 Build #305908 failed 227df2f

cc @davismcphee

AlexGPlay · 2025-06-10T08:44:47Z

src/platform/plugins/shared/discover/public/embeddable/initialize_search_embeddable_api.tsx

+  const setColumns = (columns: string[] | undefined) => {
+    stateManager.columns.next(columns);
+  };


just for my understanding here, we are calling this from saved_search, and I guess this is an observable which already has some subscribers. So this change propagates the new columns to the subscribers from the saved search?

Yes your understanding is accurate! But specifically in this case the subscribers are other areas of the embeddable that use these observables for state management. Essentially changes are propagated throughout the saved search embeddable, so things like the UI are updated and any other functionality that depends on the state has the latest values.

achyutjhunjhunwala

Tested the changed in my own PR and it works perfectly. Thank you for adding this

kibanamachine · 2025-06-10T17:38:11Z

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15566375228

kibanamachine · 2025-06-10T17:44:21Z

💔 All backports failed

Status	Branch	Result
❌	8.19	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 222858

Questions ?

Please refer to the Backport tool documentation

davismcphee · 2025-06-10T18:47:05Z

💚 All backports created successfully

Status	Branch	Result
✅	8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…astic#222858) ## Summary This PR adds support for consumers to set columns in the Discover session embeddable, and updates `SavedSearchComponent` to make use of it. This is a requirement for some usages of the embedded logs component where specific columns are needed. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 7cf1fa2) # Conflicts: # src/platform/plugins/shared/discover/public/embeddable/initialize_search_embeddable_api.tsx

kibanamachine · 2025-06-12T18:01:37Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @davismcphee

…ble (#222858) (#223281) # Backport This will backport the following commits from `main` to `8.19`: - [[Discover] Support setting columns in Discover session embeddable (#222858)](#222858)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>

…astic#222858) ## Summary This PR adds support for consumers to set columns in the Discover session embeddable, and updates `SavedSearchComponent` to make use of it. This is a requirement for some usages of the embedded logs component where specific columns are needed. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

davismcphee self-assigned this Jun 5, 2025

davismcphee force-pushed the discover-embeddable-set-columns branch from 410cf61 to dfd6091 Compare June 6, 2025 16:37

davismcphee marked this pull request as ready for review June 7, 2025 01:25

davismcphee requested review from a team as code owners June 7, 2025 01:25

davismcphee force-pushed the discover-embeddable-set-columns branch from 9fcb9ca to 2f3a394 Compare June 9, 2025 03:08

davismcphee and others added 4 commits June 9, 2025 23:32

Support setting columns in Discover embeddable

9fcf1da

Fix types

ec8674c

Fix initial columns bug

3ddecef

[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'

4150b70

davismcphee force-pushed the discover-embeddable-set-columns branch from 2f3a394 to 4150b70 Compare June 10, 2025 02:32

AlexGPlay reviewed Jun 10, 2025

View reviewed changes

AlexGPlay approved these changes Jun 10, 2025

View reviewed changes

achyutjhunjhunwala approved these changes Jun 10, 2025

View reviewed changes

davismcphee merged commit 7cf1fa2 into elastic:main Jun 10, 2025
10 checks passed

davismcphee deleted the discover-embeddable-set-columns branch June 10, 2025 17:38

davismcphee mentioned this pull request Jun 10, 2025

[8.19] [Discover] Support setting columns in Discover session embeddable (#222858) #223281

Merged

This was referenced Jun 11, 2025

[Dashboard] Rewrite scss to emotion #220520

Merged

[Obs AI Assistant] Improve conversation callout #223442

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 12, 2025

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Discover] Support setting columns in Discover session embeddable#222858

[Discover] Support setting columns in Discover session embeddable#222858
davismcphee merged 4 commits intoelastic:mainfrom
davismcphee:discover-embeddable-set-columns

davismcphee commented Jun 5, 2025 •

edited by kibanamachine

Loading

Uh oh!

elasticmachine commented Jun 7, 2025

Uh oh!

elasticmachine commented Jun 10, 2025

API count

Uh oh!

AlexGPlay Jun 10, 2025

Uh oh!

davismcphee Jun 10, 2025

Uh oh!

achyutjhunjhunwala left a comment

Uh oh!

Uh oh!

kibanamachine commented Jun 10, 2025

Uh oh!

kibanamachine commented Jun 10, 2025

Uh oh!

davismcphee commented Jun 10, 2025

Uh oh!

kibanamachine commented Jun 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

davismcphee commented Jun 5, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Jun 7, 2025

Uh oh!

elasticmachine commented Jun 10, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Public APIs missing comments

Async chunks

API count

History

Uh oh!

AlexGPlay Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

davismcphee Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

achyutjhunjhunwala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Jun 10, 2025

Uh oh!

kibanamachine commented Jun 10, 2025

💔 All backports failed

Manual backport

Questions ?

Uh oh!

davismcphee commented Jun 10, 2025

💚 All backports created successfully

Questions ?

Uh oh!

kibanamachine commented Jun 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

davismcphee commented Jun 5, 2025 •

edited by kibanamachine

Loading