Add logging to messages validation#22296
Merged
LeanidShutau merged 7 commits intoelastic:masterfrom Sep 5, 2018
Merged
Conversation
LeanidShutau
added
WIP
LeanidShutau
force-pushed
the
feature/parallelize-default-messages-validation
branch
2 times, most recently
from
a4f7e60 to
2f206d5
Compare
Contributor
Author
|
Blocked by #22254 |
LeanidShutau
force-pushed
the
feature/parallelize-default-messages-validation
branch
4 times, most recently
from
5568fe8 to
a743982
Compare
LeanidShutau
force-pushed
the
feature/parallelize-default-messages-validation
branch
from
a743982 to
898dbe8
Compare
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
azasypkin
reviewed
Aug 30, 2018
Contributor
💔 Build Failed |
LeanidShutau
changed the title
Contributor
💔 Build Failed |
LeanidShutau
force-pushed
the
feature/parallelize-default-messages-validation
branch
from
d0e2cb5 to
5fc0b7b
Compare
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
…ze-default-messages-validation
LeanidShutau
force-pushed
the
feature/parallelize-default-messages-validation
branch
from
820c409 to
bad82e8
Compare
Contributor
💚 Build Succeeded |
LeanidShutau
requested review from
azasypkin and
maryia-lapata
and removed request for
pavel06081991
azasypkin
approved these changes
Sep 4, 2018
Contributor
azasypkin
left a comment
azasypkin
left a comment
There was a problem hiding this comment.
LGTM, worked well locally for me, just a couple of nits.
maryia-lapata
approved these changes
Sep 4, 2018
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
LeanidShutau
deleted the
feature/parallelize-default-messages-validation
branch
LeanidShutau
added a commit
to LeanidShutau/kibana
that referenced
this pull request
Sep 7, 2018
* Add logging and parallelization to messages validation * Refactor dev/i18n * Resolve comments * Remove parallelism and fix tests * Resolve comments
LeanidShutau
added a commit
that referenced
this pull request
Sep 7, 2018
Contributor
Author
|
6.x/6.5: 8612a53 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22280