Implement a build tool for locale files integration#19826
Merged
pavel06081991 merged 46 commits intoelastic:masterfrom Dec 22, 2018
Merged
Implement a build tool for locale files integration#19826pavel06081991 merged 46 commits intoelastic:masterfrom
pavel06081991 merged 46 commits intoelastic:masterfrom
Conversation
5 tasks
Contributor
Author
LeanidShutau
requested review from
Bargs,
azasypkin,
epixa,
maksim-tolo,
rhoboat and
spalger
LeanidShutau
added
review
Team:Core
Contributor
💔 Build Failed |
LeanidShutau
changed the title
Contributor
azasypkin
removed request for
Bargs,
azasypkin,
epixa,
maksim-tolo,
rhoboat and
spalger
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
azasypkin
requested changes
Dec 18, 2018
Contributor
azasypkin
left a comment
azasypkin
left a comment
There was a problem hiding this comment.
Looks good overall, just a number of suggestions.
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
azasypkin
approved these changes
Dec 20, 2018
Contributor
azasypkin
left a comment
azasypkin
left a comment
There was a problem hiding this comment.
LGTM, tested locally - works as we expect it to work right now.
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
pavel06081991
approved these changes
Dec 22, 2018
Contributor
pavel06081991
left a comment
pavel06081991
left a comment
There was a problem hiding this comment.
Tested locally, works as expected. LGTM
azasypkin
reviewed
Dec 22, 2018
| import parser from 'intl-messageformat-parser'; | ||
| import normalize from 'normalize-path'; | ||
| import path from 'path'; | ||
| import chalk from 'chalk'; |
Contributor
There was a problem hiding this comment.
optional nit: unnecessary change,
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check locale files for unused translations and missing translations.
Split locale files by namespaces (using
.i18nrc.json) and move them to plugins folders.Usage
node scripts/i18n_integrate --path ./path_to_locale_file