Skip to content

[8.19] [Security Solution] Remove index pattern field from Sourcerer (#190113) And other sourcerer clean ups#222889

Merged
christineweng merged 4 commits intoelastic:8.19from
christineweng:backport/8.19/pr-190113
Jun 6, 2025
Merged

[8.19] [Security Solution] Remove index pattern field from Sourcerer (#190113) And other sourcerer clean ups#222889
christineweng merged 4 commits intoelastic:8.19from
christineweng:backport/8.19/pr-190113

Conversation

@christineweng
Copy link
Contributor

@christineweng christineweng commented Jun 5, 2025

@christineweng christineweng added the backport This PR is a backport of another PR label Jun 5, 2025
@christineweng christineweng enabled auto-merge (squash) June 5, 2025 20:10
@christineweng christineweng force-pushed the backport/8.19/pr-190113 branch from da87961 to 865be6e Compare June 5, 2025 21:10
@christineweng christineweng changed the title [8.19] [Security Solution] Remove index pattern field from Sourcerer (#190113) [8.19] [Security Solution] Remove index pattern field from Sourcerer (#190113) And other sourcerer clean ups Jun 5, 2025
christineweng and others added 3 commits June 5, 2025 17:06
…c#190113)

This PR removes index pattern field from the sourcerer model, replacing
it with direct access to data view spec.

The end goal for the sourcerer is to just utilize platform wide Data
View Types, instead of some custom abstractions / containers such as
indexPattern field which is effectively a DataViewSpec, just packed up
differently.
Some properties returned from this hook are no longer in the sourcerer
model (and the declared result type).
This PR removes them.
elastic#216542)

This PR cleaned up some naming inconsistencies related to index pattern
and data view spec. No change to features/UI.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
@christineweng christineweng force-pushed the backport/8.19/pr-190113 branch from c5f0ec7 to e92163f Compare June 5, 2025 22:23
@christineweng christineweng force-pushed the backport/8.19/pr-190113 branch from e92163f to a909f52 Compare June 5, 2025 23:05
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 7389 7390 +1
threatIntelligence 177 178 +1
total +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.3MB 9.3MB -285.0B
threatIntelligence 754.4KB 754.3KB -109.0B
total -394.0B

History

@christineweng christineweng merged commit 7cbb4e3 into elastic:8.19 Jun 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants