[Security Solution][Sourcerer] Rename index pattern props to data view#216542

Merged

christineweng merged 1 commit intoelastic:mainfrom

christineweng:rename-index-pattern-to-dv

Apr 1, 2025

Contributor

christineweng commented Mar 31, 2025 •

edited by kibanamachine

Loading

Summary

This PR cleaned up some naming inconsistencies related to index pattern and data view spec. No change to features/UI.

Checklist

Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

christineweng added release_note:skip Team:Threat Hunting:Investigations backport:version v9.1.0 v8.19.0 labels

christineweng self-assigned this

christineweng force-pushed the rename-index-pattern-to-dv branch from 77f1d2b to c9bbf82 Compare

March 31, 2025 21:08

christineweng commented

View reviewed changes

...y/plugins/security_solution/public/flyout/document_details/shared/hooks/use_event_details.ts

                   dataAsNestedObject,
                   dataFormattedForFieldBrowser,
                   getFieldsData,
-                  indexPattern: sourcererDataView.sourcererDataView,

Contributor Author

christineweng Mar 31, 2025

never used

christineweng commented

View reviewed changes

.../security_solution/public/explore/network/components/network_top_countries_table/columns.tsx

               ];
               export const getNetworkTopCountriesColumns = (
-                indexPattern: DataViewBase,

Contributor Author

christineweng Mar 31, 2025 •

edited

Loading

not used in this function anymore

christineweng marked this pull request as ready for review

March 31, 2025 21:51

christineweng requested review from a team as code owners

March 31, 2025 21:51

Contributor

elasticmachine commented Mar 31, 2025

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

christineweng requested a review from lgestc

March 31, 2025 22:26

fix

c0b6ccb

christineweng force-pushed the rename-index-pattern-to-dv branch from c9bbf82 to c0b6ccb Compare

March 31, 2025 23:02

PhilippeOberti approved these changes

View reviewed changes

Contributor

elasticmachine commented Apr 1, 2025

💚 Build Succeeded

Buildkite Build
Commit: c0b6ccb

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	8.9MB	8.9MB	-73.0B

History

💔 Build #288792 failed c9bbf82

cc @christineweng

agusruidiazgd approved these changes

View reviewed changes

Contributor

agusruidiazgd left a comment

LGTM! Thanks for this cleanup Christine! 😸

lgestc approved these changes

View reviewed changes

christineweng merged commit 005940c into elastic:main

9 checks passed

Contributor

kibanamachine commented Apr 1, 2025

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/14199045024

Contributor

kibanamachine commented Apr 1, 2025

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 216542

Questions ?

Please refer to the Backport tool documentation

kibanamachine mentioned this pull request

[Obs AI Assistant] Skip lock tests in MKI temporarily #216753

Merged

christineweng removed the v8.19.0 label

kibanamachine added the backport missing label

Contributor

kibanamachine commented Apr 3, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 216542 locally

2 similar comments

Contributor

kibanamachine commented Apr 4, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 216542 locally

Contributor

kibanamachine commented Apr 7, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 216542 locally

Contributor

kibanamachine commented Apr 8, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 216542 locally

6 similar comments

Contributor

kibanamachine commented Apr 9, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 216542 locally

Contributor

kibanamachine commented Apr 10, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 216542 locally

Contributor

kibanamachine commented Apr 11, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 216542 locally

Contributor

kibanamachine commented Apr 14, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 216542 locally

Contributor

kibanamachine commented Apr 15, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 216542 locally

Contributor

kibanamachine commented Apr 16, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 216542 locally

christineweng added backport:skip and removed backport missing backport:version labels

christineweng mentioned this pull request

[8.19] [Security Solution] Remove index pattern field from Sourcerer (#190113) And other sourcerer clean ups #222889

Merged

christineweng added a commit to christineweng/kibana that referenced this pull request


          [Security Solution][Sourcerer] Rename index pattern props to data view (

2da41db

elastic#216542)

This PR cleaned up some naming inconsistencies related to index pattern
and data view spec. No change to features/UI.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

christineweng added a commit to christineweng/kibana that referenced this pull request


          [Security Solution][Sourcerer] Rename index pattern props to data view (

b8bd24a

elastic#216542)

This PR cleaned up some naming inconsistencies related to index pattern
and data view spec. No change to features/UI.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

christineweng added a commit that referenced this pull request


          [8.19] [Security Solution] Remove index pattern field from Sourcerer (#…

7cbb4e3

…190113) And other sourcerer clean ups (#222889)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Security Solution] Remove index pattern field from Sourcerer
(#190113)](#190113)
- [remove unused fields from the sourcerer hook result
#206030](#206030)
- [[Security Solution][Sourcerer] Rename index pattern props to data
view #216542](#216542)

<!--- Backport version: 10.0.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Luke
Gmys","email":"11671118+lgestc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-28T11:11:00Z","message":"[Security
Solution] Remove index pattern field from Sourcerer (#190113)\n\n##
Summary\r\n\r\nThis PR removes index pattern field from the sourcerer
model, replacing\r\nit with direct access to data view spec.\r\n\r\nThe
end goal for the sourcerer is to just utilize platform wide Data\r\nView
Types, instead of some custom abstractions / containers such
as\r\nindexPattern field which is effectively a DataViewSpec, just
packed
up\r\ndifferently.","sha":"a8048ddf6b3f6623c87236c875a0ef1506a39fe2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","Team:Threat
Hunting:Investigations","Team:Threat
Hunting:Explore"],"title":"[Security Solution] Remove index pattern
field from
Sourcerer","number":190113,"url":"https://github.com/elastic/kibana/pull/190113","mergeCommit":{"message":"[Security
Solution] Remove index pattern field from Sourcerer (#190113)\n\n##
Summary\r\n\r\nThis PR removes index pattern field from the sourcerer
model, replacing\r\nit with direct access to data view spec.\r\n\r\nThe
end goal for the sourcerer is to just utilize platform wide Data\r\nView
Types, instead of some custom abstractions / containers such
as\r\nindexPattern field which is effectively a DataViewSpec, just
packed
up\r\ndifferently.","sha":"a8048ddf6b3f6623c87236c875a0ef1506a39fe2"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190113","number":190113,"mergeCommit":{"message":"[Security
Solution] Remove index pattern field from Sourcerer (#190113)\n\n##
Summary\r\n\r\nThis PR removes index pattern field from the sourcerer
model, replacing\r\nit with direct access to data view spec.\r\n\r\nThe
end goal for the sourcerer is to just utilize platform wide Data\r\nView
Types, instead of some custom abstractions / containers such
as\r\nindexPattern field which is effectively a DataViewSpec, just
packed
up\r\ndifferently.","sha":"a8048ddf6b3f6623c87236c875a0ef1506a39fe2"}}]}]
BACKPORT-->

---------

Co-authored-by: Luke Gmys <11671118+lgestc@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip release_note:skip Team:Threat Hunting:Investigations v9.1.0