[8.19] [SharedUX] use core.rendering service for Share plugin interfaces (#221714)#222613
Merged
tsullivan merged 2 commits intoelastic:8.19from Jun 5, 2025
Merged
[8.19] [SharedUX] use core.rendering service for Share plugin interfaces (#221714)#222613tsullivan merged 2 commits intoelastic:8.19from
tsullivan merged 2 commits intoelastic:8.19from
Conversation
…astic#221714) ## Summary Split out from elastic#220170 This pull request refactors the `Reporting` and `Share` modules to streamline usage of services required for rendering React components. It replaces the deprecated `KibanaRenderContextProvider`-related services (`analytics`, `i18n`, `theme`, `userProfile`) with the new rendering service. ### Reporting Module Updates: * Updated Reporting modals and actions to use the `rendering` service instead of the deprecated services. * All usages of `toMountPoint` now receive the `rendering` service as a parameter, aligning with the new rendering context. ### Share Module Updates: * Refactored `share_menu_manager.tsx` to remove dependencies on deprecated services for rendering the share menu. * Updated the `toggleShareContextMenu` method: * Removed `toasts` from the `ShareContext` interface object. * Now accepts `rendering` as a parameter and passes it to `toMountPoint`. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 395844f) # Conflicts: # src/platform/packages/private/kbn-reporting/public/share/share_context_menu/register_csv_modal_reporting.tsx # src/platform/packages/private/kbn-reporting/public/share/share_context_menu/register_pdf_png_modal_reporting.tsx # src/platform/plugins/shared/dashboard/public/dashboard_app/top_nav/share/show_share_modal.tsx # src/platform/plugins/shared/discover/public/application/main/components/top_nav/app_menu_actions/get_share.tsx # src/platform/plugins/shared/share/public/components/context/index.tsx # src/platform/plugins/shared/share/public/components/export_popover/export_popover.test.tsx # src/platform/plugins/shared/share/public/components/share_tabs.test.tsx # src/platform/plugins/shared/share/public/services/share_menu_manager.tsx # src/platform/plugins/shared/share/public/types.ts # src/platform/plugins/shared/share/tsconfig.json # src/platform/plugins/shared/visualizations/public/visualize_app/utils/get_top_nav_config.tsx # x-pack/platform/plugins/shared/lens/public/app_plugin/lens_top_nav.tsx
1 task
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation