Convert usage of notify.error to toastNotifications.addDanger for string messages#22243
Merged
cjcenizal merged 2 commits intoelastic:masterfrom Aug 23, 2018
Merged
Conversation
Contributor
Author
|
@joshdover Could you please review the change to the status page? @bmcconaghy Could you review the change to index patterns? @ppisljar Could you review the changees to @Bargs Could you review the change to @nreese Could you review the tutorial changes? |
Contributor
Author
|
CC @spalger |
cjcenizal
requested review from
Bargs,
bmcconaghy,
joshdover,
nreese and
ppisljar
Contributor
💔 Build Failed |
ppisljar
approved these changes
Aug 22, 2018
Contributor
ppisljar
left a comment
ppisljar
left a comment
There was a problem hiding this comment.
code LGTM for graph and hierarchical response handler
nreese
approved these changes
Aug 22, 2018
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
lgtm
code review tutorial changes
Bargs
approved these changes
Aug 22, 2018
Contributor
Bargs
left a comment
Bargs
left a comment
There was a problem hiding this comment.
Reviewed code and tested functionality for GetEnabledScriptingLanguagesProvider. LGTM.
Contributor
💚 Build Succeeded |
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Aug 23, 2018
…ing messages (elastic#22243) * Update buildHierarchicalData test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Index patterns
Status page
Tutorials