Skip to content

[8.19] [Spaces] Move getSpaceIdFromPath to a separate package (#221485)#222196

Merged
kowalczyk-krzysztof merged 4 commits intoelastic:8.19from
kowalczyk-krzysztof:backport/8.19/pr-221485
Jun 3, 2025
Merged

[8.19] [Spaces] Move getSpaceIdFromPath to a separate package (#221485)#222196
kowalczyk-krzysztof merged 4 commits intoelastic:8.19from
kowalczyk-krzysztof:backport/8.19/pr-221485

Conversation

@kowalczyk-krzysztof
Copy link
Member

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

## Summary

This PR creates a separate package with `getSpaceIdFromPath` exported to
avoid creating a circular dependency in
elastic#220138

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 7ac80fa)

# Conflicts:
#	.github/CODEOWNERS
#	package.json
#	tsconfig.base.json
#	x-pack/platform/plugins/shared/spaces/tsconfig.json
#	yarn.lock
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
spaces 310 312 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/spaces-utils - 1 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
spaces 28.4KB 28.4KB +6.0B
Unknown metric groups

API count

id before after diff
@kbn/spaces-utils - 8 +8

History

@kowalczyk-krzysztof kowalczyk-krzysztof merged commit 0adf946 into elastic:8.19 Jun 3, 2025
8 checks passed
@kowalczyk-krzysztof kowalczyk-krzysztof deleted the backport/8.19/pr-221485 branch August 1, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants