Skip to content

[Spaces] Move getSpaceIdFromPath to a separate package#221485

Merged
kowalczyk-krzysztof merged 7 commits intoelastic:mainfrom
kowalczyk-krzysztof:chore/move-getspaceidfrompath
May 27, 2025
Merged

[Spaces] Move getSpaceIdFromPath to a separate package#221485
kowalczyk-krzysztof merged 7 commits intoelastic:mainfrom
kowalczyk-krzysztof:chore/move-getspaceidfrompath

Conversation

@kowalczyk-krzysztof
Copy link
Member

@kowalczyk-krzysztof kowalczyk-krzysztof commented May 26, 2025 •
edited by kibanamachine
Loading

Summary

This PR creates a separate package with getSpaceIdFromPath exported to avoid creating a circular dependency in #220138

@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this May 26, 2025
@kowalczyk-krzysztof kowalczyk-krzysztof requested a review from a team as a code owner May 26, 2025 09:02
@kowalczyk-krzysztof kowalczyk-krzysztof added Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// Feature:Security/Spaces Platform Security - Spaces feature release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels May 26, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented May 26, 2025

Pinging @elastic/kibana-security (Team:Security)

@jeramysoucy jeramysoucy self-requested a review May 26, 2025 09:17
@elasticmachine
Copy link
Contributor

elasticmachine commented May 26, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
spaces 234 236 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/spaces-utils - 1 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
spaces 28.1KB 28.1KB +6.0B
Unknown metric groups

API count

id before after diff
@kbn/spaces-utils - 8 +8

History

cc @kowalczyk-krzysztof

jeramysoucy
jeramysoucy approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@jeramysoucy jeramysoucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@kowalczyk-krzysztof kowalczyk-krzysztof merged commit 7ac80fa into elastic:main May 27, 2025
12 checks passed
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
@kowalczyk-krzysztof @kibanamachine @akowalska622
[Spaces] Move getSpaceIdFromPath to a separate package (elastic#221485)
2c81f59 
## Summary

This PR creates a separate package with `getSpaceIdFromPath` exported to
avoid creating a circular dependency in
elastic#220138

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kowalczyk-krzysztof kowalczyk-krzysztof added backport:version Backport to applied version labels v8.19.0 and removed backport:skip This PR does not require backporting labels Jun 2, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 2, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15391305407

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 2, 2025

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 221485

Questions ?

Please refer to the Backport tool documentation

@kowalczyk-krzysztof kowalczyk-krzysztof mentioned this pull request Jun 2, 2025
Merged
@kowalczyk-krzysztof
Copy link
Member Author

kowalczyk-krzysztof commented Jun 2, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kowalczyk-krzysztof added a commit to kowalczyk-krzysztof/kibana that referenced this pull request Jun 2, 2025
@kowalczyk-krzysztof
[Spaces] Move getSpaceIdFromPath to a separate package (elastic#221485)
b3274fc 
## Summary

This PR creates a separate package with `getSpaceIdFromPath` exported to
avoid creating a circular dependency in
elastic#220138

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 7ac80fa)

# Conflicts:
#	.github/CODEOWNERS
#	package.json
#	tsconfig.base.json
#	x-pack/platform/plugins/shared/spaces/tsconfig.json
#	yarn.lock
kowalczyk-krzysztof added a commit that referenced this pull request Jun 3, 2025
@kowalczyk-krzysztof @kibanamachine
[8.19] [Spaces] Move getSpaceIdFromPath to a separate package (#221485)…
0adf946 
… (#222196)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Spaces] Move getSpaceIdFromPath to a separate package
(#221485)](#221485)

<!--- Backport version: 10.0.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-05-27T09:57:30Z","message":"[Spaces]
Move getSpaceIdFromPath to a separate package (#221485)\n\n##
Summary\n\nThis PR creates a separate package with `getSpaceIdFromPath`
exported to\navoid creating a circular dependency
in\nhttps://github.com//pull/220138\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"7ac80fa5a6352c7ede93691e60d3e4da81e051d0","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","Feature:Security/Spaces","release_note:skip","backport:version","v9.1.0","v8.19.0"],"title":"[Spaces]
Move getSpaceIdFromPath to a separate
package","number":221485,"url":"https://github.com/elastic/kibana/pull/221485","mergeCommit":{"message":"[Spaces]
Move getSpaceIdFromPath to a separate package (#221485)\n\n##
Summary\n\nThis PR creates a separate package with `getSpaceIdFromPath`
exported to\navoid creating a circular dependency
in\nhttps://github.com//pull/220138\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"7ac80fa5a6352c7ede93691e60d3e4da81e051d0"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221485","number":221485,"mergeCommit":{"message":"[Spaces]
Move getSpaceIdFromPath to a separate package (#221485)\n\n##
Summary\n\nThis PR creates a separate package with `getSpaceIdFromPath`
exported to\navoid creating a circular dependency
in\nhttps://github.com//pull/220138\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"7ac80fa5a6352c7ede93691e60d3e4da81e051d0"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kowalczyk-krzysztof kowalczyk-krzysztof deleted the chore/move-getspaceidfrompath branch August 1, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeramysoucy jeramysoucy jeramysoucy approved these changes

Assignees

@kowalczyk-krzysztof kowalczyk-krzysztof

Labels

backport:version Backport to applied version labels Feature:Security/Spaces Platform Security - Spaces feature release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kowalczyk-krzysztof @elasticmachine @kibanamachine @jeramysoucy