Add telemetry for ignored fields#220872
Closed
maryam-saeidi wants to merge 22 commits intoelastic:mainfrom
Closed
Conversation
…e aggregation result
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Member
Author
|
Closing in favor of #221480 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #220815
Summary
This PR adds telemetry for _ignored fields. The goal is to have an alert based on this field and get notified in case a user hits the mapping limit, but by default, we don't expect this to happen.
This PR adds
count_ignored_fields_by_rule_typefield that counts the number of _ignored fields per rule type.In the future, we can extend the telemetry data to also include the actual number of mappings over the limit (there is a feature request for adding field count information to index API)
How to test
count_ignored_fields_by_rule_typeHere is what it looks like: