[Obs AI Assistant] Do not attempt to overwrite index mappings if inference id in component template has changed#220739
Merged
sorenlouv merged 7 commits intoelastic:mainfrom May 12, 2025
Conversation
botelastic
bot
added
ci:project-deploy-observability
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
sorenlouv
changed the title
sorenlouv
changed the title
sorenlouv
changed the title
sorenlouv
added
backport:version
sorenlouv
changed the title
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#8261[✅] x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.ai_assistant.serverless.config.ts: 100/100 tests passed. |
…del deployment” error
the model id is the same as the deployment id of a current model deployment]: Cannot create model [pt_tiny_text_embedding] the model id is the same as the deployment id of a current model deployment","attributes":{"body":{"error":{"root_cause":[{"type":"status_exception","reason":"Cannot create model [pt_tiny_text_embedding] the model id is the same as the deployment id of a current model deployment"}],"type":"status_exception","reason":"Cannot create model [pt_tiny_text_embedding] the model id is the same as the deployment id of a current model deployment"},"status":400}}}'
Contributor
⏳ Build in-progress
History
|
viduni94
reviewed
May 12, 2025
| }); | ||
| // `createConcreteWriteIndex` will create the write index, or update the index mappings if the index already exists | ||
| // only invoke `createConcreteWriteIndex` if the write index does not exist or the inferenceId in the component template is the same as the one in the write index | ||
| if (!writeIndexInferenceId || writeIndexInferenceId === componentTemplateInferenceId) { |
Contributor
There was a problem hiding this comment.
Hey @sorenlouv
Would this work when changing the model as well?
In the /setup route we call createOrUpdateKnowledgeBaseIndexAssets with nextInferenceId when currentWriteIndexInferenceId !== nextInferenceId.
In that scenario, are we avoiding calling createConcreteWriteIndex here with this change?
Contributor
There was a problem hiding this comment.
I tested locally and changing the model seems to be working
viduni94
approved these changes
May 12, 2025
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/14975898963 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
sorenlouv
deleted the
do-not-overwrite-index-mappings-with-different-inference-id
branch
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
May 14, 2025
…rence id in component template has changed (elastic#220739) Improve flaky API tests and avoid errors like: ``` [ERROR][plugins.observabilityAIAssistant.service] Failed to PUT mapping for .kibana-observability-ai-assistant-kb: illegal_argument_exception Root causes: illegal_argument_exception: Mapper for [semantic_text] conflicts with existing mapper: Cannot update parameter [inference_id] from [pt_tiny_elser_inference_id] to [pt_tiny_text_embedding_inference_id] ``` (cherry picked from commit d2f25df)
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
sorenlouv
added a commit
that referenced
this pull request
May 14, 2025
… AI Assistant] Do not attempt to overwrite index mappings if inference id in component template has changed (#220739) (#220791) # Backport This will backport the following commits from `main` to `8.19`: - [[Obs AI Assistant] Improve flaky recall tests (#220638)](#220638) - [[Obs AI Assistant] Do not attempt to overwrite index mappings if inference id in component template has changed (#220739)](#220739) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Søren Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2025-05-09T13:21:07Z","message":"[Obs AI Assistant] Improve flaky recall tests (#220638)","sha":"ed1f558f30127b36f450e9b9f991fcc1c13c36c3","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","ci:build-cloud-image","ci:build-serverless-image","Team:Obs AI Assistant","ci:project-deploy-observability","backport:version","v9.1.0","v8.19.0"],"title":"[Obs AI Assistant] Improve flaky recall tests","number":220638,"url":"https://github.com/elastic/kibana/pull/220638","mergeCommit":{"message":"[Obs AI Assistant] Improve flaky recall tests (#220638)","sha":"ed1f558f30127b36f450e9b9f991fcc1c13c36c3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220638","number":220638,"mergeCommit":{"message":"[Obs AI Assistant] Improve flaky recall tests (#220638)","sha":"ed1f558f30127b36f450e9b9f991fcc1c13c36c3"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/220790","number":220790,"state":"OPEN"}]},{"author":{"name":"Søren Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2025-05-12T15:11:03Z","message":"[Obs AI Assistant] Do not attempt to overwrite index mappings if inference id in component template has changed (#220739)\n\nImprove flaky API tests and avoid errors like:\n\n```\n[ERROR][plugins.observabilityAIAssistant.service] Failed to PUT mapping for .kibana-observability-ai-assistant-kb: illegal_argument_exception\n \tRoot causes:\n \t\tillegal_argument_exception: Mapper for [semantic_text] conflicts with existing mapper:\n \tCannot update parameter [inference_id] from [pt_tiny_elser_inference_id] to [pt_tiny_text_embedding_inference_id]\n```","sha":"d2f25df5f3c8337ae9237093fde05d43660e0cf2","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Obs AI Assistant","ci:project-deploy-observability","backport:version","v9.1.0","v8.19.0"],"title":"[Obs AI Assistant] Do not attempt to overwrite index mappings if inference id in component template has changed","number":220739,"url":"https://github.com/elastic/kibana/pull/220739","mergeCommit":{"message":"[Obs AI Assistant] Do not attempt to overwrite index mappings if inference id in component template has changed (#220739)\n\nImprove flaky API tests and avoid errors like:\n\n```\n[ERROR][plugins.observabilityAIAssistant.service] Failed to PUT mapping for .kibana-observability-ai-assistant-kb: illegal_argument_exception\n \tRoot causes:\n \t\tillegal_argument_exception: Mapper for [semantic_text] conflicts with existing mapper:\n \tCannot update parameter [inference_id] from [pt_tiny_elser_inference_id] to [pt_tiny_text_embedding_inference_id]\n```","sha":"d2f25df5f3c8337ae9237093fde05d43660e0cf2"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220739","number":220739,"mergeCommit":{"message":"[Obs AI Assistant] Do not attempt to overwrite index mappings if inference id in component template has changed (#220739)\n\nImprove flaky API tests and avoid errors like:\n\n```\n[ERROR][plugins.observabilityAIAssistant.service] Failed to PUT mapping for .kibana-observability-ai-assistant-kb: illegal_argument_exception\n \tRoot causes:\n \t\tillegal_argument_exception: Mapper for [semantic_text] conflicts with existing mapper:\n \tCannot update parameter [inference_id] from [pt_tiny_elser_inference_id] to [pt_tiny_text_embedding_inference_id]\n```","sha":"d2f25df5f3c8337ae9237093fde05d43660e0cf2"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Contributor
Author
|
Backported to 8.19 in #220791 |
kibanamachine
removed
the
backport missing
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
…rence id in component template has changed (elastic#220739) Improve flaky API tests and avoid errors like: ``` [ERROR][plugins.observabilityAIAssistant.service] Failed to PUT mapping for .kibana-observability-ai-assistant-kb: illegal_argument_exception Root causes: illegal_argument_exception: Mapper for [semantic_text] conflicts with existing mapper: Cannot update parameter [inference_id] from [pt_tiny_elser_inference_id] to [pt_tiny_text_embedding_inference_id] ```
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jun 3, 2025
…rence id in component template has changed (elastic#220739) Improve flaky API tests and avoid errors like: ``` [ERROR][plugins.observabilityAIAssistant.service] Failed to PUT mapping for .kibana-observability-ai-assistant-kb: illegal_argument_exception Root causes: illegal_argument_exception: Mapper for [semantic_text] conflicts with existing mapper: Cannot update parameter [inference_id] from [pt_tiny_elser_inference_id] to [pt_tiny_text_embedding_inference_id] ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve flaky API tests and avoid errors like: