Skip to content

[Obs AI Assistant] Add support for dense vector embeddings in API tests#219199

Merged
sorenlouv merged 5 commits intoelastic:mainfrom
sorenlouv:add-support-for-dense-embeddings
Apr 28, 2025
Merged

[Obs AI Assistant] Add support for dense vector embeddings in API tests#219199
sorenlouv merged 5 commits intoelastic:mainfrom
sorenlouv:add-support-for-dense-embeddings

Conversation

@sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented Apr 25, 2025

This adds support for the tiny_text_embedding model that generated dense vector embeddings in API tests. This will be useful when we support multiple models and need to confirm that we can switch between models, and embeddings are correctly updated.

Also adds some small refactorings/cleanup

@sorenlouv sorenlouv requested review from a team as code owners April 25, 2025 08:05
@sorenlouv sorenlouv added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Apr 25, 2025
Copy link
Contributor

@viduni94 viduni94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment. The rest LGTM.
Thanks @sorenlouv

}
},

async startTrainedModelDeploymentES(deploymentId: string) {
Copy link
Contributor

@viduni94 viduni94 Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the route definition for /internal/ml//trained_models/{modelId}/deployment/_start the path param seems to be the modelId and deploymentId is an optional query param.

I'm not sure whether the /_ml/trained_models/${deploymentId}/deployment/_start definition is different from the /internal/ml/trained_models/{modelId}/deployment/_startl definition.

If it's the same, can we call this modelId instead of deploymentId for clarity?

Suggested change
async startTrainedModelDeploymentES(deploymentId: string) {
async startTrainedModelDeploymentES(modelId: string) {

sorenlouv and others added 3 commits April 27, 2025 21:21
…lity/ai_assistant/knowledge_base/knowledge_base.spec.ts

Co-authored-by: Viduni Wickramarachchi <viduni.ushanka@gmail.com>
@sorenlouv sorenlouv enabled auto-merge (squash) April 28, 2025 07:07
@sorenlouv sorenlouv merged commit ca5cae9 into elastic:main Apr 28, 2025
10 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/14711737381

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / MlUserJobDescription should render toast that shows admin permissions required

Metrics [docs]

✅ unchanged

History

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 219199

Questions ?

Please refer to the Backport tool documentation

@sorenlouv sorenlouv deleted the add-support-for-dense-embeddings branch April 29, 2025 15:00
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 30, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 219199 locally
cc: @sorenlouv

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 219199 locally
cc: @sorenlouv

@sorenlouv sorenlouv added the backport:skip This PR does not require backporting label May 1, 2025
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 1, 2025
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
…ts (elastic#219199)

This adds support for the `tiny_text_embedding` model that generated
dense vector embeddings in API tests. This will be useful when we
support multiple models and need to confirm that we can switch between
models, and embeddings are correctly updated.

Also adds some small refactorings/cleanup

---------

Co-authored-by: Viduni Wickramarachchi <viduni.ushanka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants