Skip to content

Conversation

@dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented May 8, 2025

Summary

Part of https://github.com/elastic/kibana-team/issues/1503

This PR is mostly about moving tests from x-pack/test to x-pack/solutions/security/test

Before:

x-pack/test/
     | - api_integration/apis/cloud_security_posture/
     | - cloud_security_posture_api/
     | - cloud_security_posture_functional/

After:

x-pack/solutions/security/test/
     | - api_integration/apis/cloud_security_posture/
     | - cloud_security_posture_api/
     | - cloud_security_posture_functional/

dmlemeshko and others added 30 commits April 30, 2025 10:49
@dmlemeshko dmlemeshko added the backport:skip This PR does not require backporting label Jun 4, 2025
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #32 / discover Discover CSV Export Generate CSV: sparse data handles field formatting for a field that doesn't exist initially

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
@kbn/test-suites-xpack 22 21 -1
@kbn/test-suites-xpack-security - 1 +1
total -0

ESLint disabled line counts

id before after diff
@kbn/test-suites-xpack 703 659 -44
@kbn/test-suites-xpack-security - 43 +43
total -1

Total ESLint disabled count

id before after diff
@kbn/test-suites-xpack 725 680 -45
@kbn/test-suites-xpack-security - 44 +44
total -1

History

cc @dmlemeshko

Copy link
Contributor

@maxcold maxcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

export default async function ({ readConfigFile }: FtrConfigProviderContext) {
const xpackFunctionalConfig = await readConfigFile(
require.resolve('../functional/config.base.js')
require.resolve('@kbn/test-suites-xpack/functional/config.base')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️
I love to see reusing code now through packages, finally

@dmlemeshko dmlemeshko merged commit 9cc9e20 into elastic:main Jun 4, 2025
12 checks passed
zacharyparikh pushed a commit to zacharyparikh/kibana that referenced this pull request Jun 4, 2025
## Summary

Part of elastic/kibana-team#1503

This PR is mostly about moving tests from x-pack/test to
x-pack/solutions/security/test

Before:

```
x-pack/test/
     | - api_integration/apis/cloud_security_posture/
     | - cloud_security_posture_api/
     | - cloud_security_posture_functional/
```

After: 
```
x-pack/solutions/security/test/
     | - api_integration/apis/cloud_security_posture/
     | - cloud_security_posture_api/
     | - cloud_security_posture_functional/
```

---------

Co-authored-by: kibanamachine <[email protected]>
nickpeihl pushed a commit to nickpeihl/kibana that referenced this pull request Jun 12, 2025
## Summary

Part of elastic/kibana-team#1503

This PR is mostly about moving tests from x-pack/test to
x-pack/solutions/security/test

Before:

```
x-pack/test/
     | - api_integration/apis/cloud_security_posture/
     | - cloud_security_posture_api/
     | - cloud_security_posture_functional/
```

After: 
```
x-pack/solutions/security/test/
     | - api_integration/apis/cloud_security_posture/
     | - cloud_security_posture_api/
     | - cloud_security_posture_functional/
```

---------

Co-authored-by: kibanamachine <[email protected]>
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Jun 17, 2025
## Summary

Part of elastic/kibana-team#1503

This PR is mostly about moving tests from x-pack/test to
x-pack/solutions/security/test

Before:

```
x-pack/test/
     | - api_integration/apis/cloud_security_posture/
     | - cloud_security_posture_api/
     | - cloud_security_posture_functional/
```

After:
```
x-pack/solutions/security/test/
     | - api_integration/apis/cloud_security_posture/
     | - cloud_security_posture_api/
     | - cloud_security_posture_functional/
```

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 9cc9e20)

# Conflicts:
#	.buildkite/ftr_security_stateful_configs.yml
#	.github/CODEOWNERS
#	package.json
#	tsconfig.base.json
#	x-pack/solutions/search/plugins/enterprise_search/public/applications/shared/role_mapping/__mocks__/elasticsearch_users.ts
#	x-pack/solutions/security/plugins/cloud_security_posture/README.md
#	x-pack/solutions/security/test/cloud_security_posture_functional/pages/cis_integrations/constants.ts
#	x-pack/solutions/security/test/cloud_security_posture_functional/pages/rules.ts
#	x-pack/solutions/security/test/cloud_security_posture_functional/pages/rules/rules_counters.ts
#	x-pack/solutions/security/test/cloud_security_posture_functional/pages/rules/rules_table.ts
#	x-pack/solutions/security/test/cloud_security_posture_functional/pages/rules/rules_table_headers.ts
#	x-pack/test/cloud_security_posture_functional/pages/cis_integrations/constants.ts
#	x-pack/test_serverless/api_integration/test_suites/security/cloud_security_posture/serverless_metering/cloud_security_metering.ts
#	yarn.lock
@dmlemeshko
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dmlemeshko added a commit that referenced this pull request Jun 17, 2025
…224189)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[ska][x-pack] relocate security solution tests [5]
(#220465)](#220465)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-06-04T14:52:19Z","message":"[ska][x-pack]
relocate security solution tests [5] (#220465)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving tests from x-pack/test
to\nx-pack/solutions/security/test\n\nBefore:\n\n```\nx-pack/test/\n | -
api_integration/apis/cloud_security_posture/\n | -
cloud_security_posture_api/\n | -
cloud_security_posture_functional/\n```\n\nAfter:
\n```\nx-pack/solutions/security/test/\n | -
api_integration/apis/cloud_security_posture/\n | -
cloud_security_posture_api/\n | -
cloud_security_posture_functional/\n```\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"9cc9e20c95cc96d7df90c1fb3d4674ecf5254307","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.1.0","v8.19.0"],"title":"[ska][x-pack]
relocate security solution tests
[5]","number":220465,"url":"https://github.com/elastic/kibana/pull/220465","mergeCommit":{"message":"[ska][x-pack]
relocate security solution tests [5] (#220465)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving tests from x-pack/test
to\nx-pack/solutions/security/test\n\nBefore:\n\n```\nx-pack/test/\n | -
api_integration/apis/cloud_security_posture/\n | -
cloud_security_posture_api/\n | -
cloud_security_posture_functional/\n```\n\nAfter:
\n```\nx-pack/solutions/security/test/\n | -
api_integration/apis/cloud_security_posture/\n | -
cloud_security_posture_api/\n | -
cloud_security_posture_functional/\n```\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"9cc9e20c95cc96d7df90c1fb3d4674ecf5254307"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220465","number":220465,"mergeCommit":{"message":"[ska][x-pack]
relocate security solution tests [5] (#220465)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly
about moving tests from x-pack/test
to\nx-pack/solutions/security/test\n\nBefore:\n\n```\nx-pack/test/\n | -
api_integration/apis/cloud_security_posture/\n | -
cloud_security_posture_api/\n | -
cloud_security_posture_functional/\n```\n\nAfter:
\n```\nx-pack/solutions/security/test/\n | -
api_integration/apis/cloud_security_posture/\n | -
cloud_security_posture_api/\n | -
cloud_security_posture_functional/\n```\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"9cc9e20c95cc96d7df90c1fb3d4674ecf5254307"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants