Skip to content

Update Kibana URLs in doc link service#219657

Merged
lcawl merged 16 commits intoelastic:mainfrom
lcawl:kibana-links
May 5, 2025
Merged

Update Kibana URLs in doc link service#219657
lcawl merged 16 commits intoelastic:mainfrom
lcawl:kibana-links

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 30, 2025 •
edited by kibanamachine
Loading

Summary

Relates to #217722
This PR:

  • updates the URLs in the kibana, management, scriptedFields, upgradeAssistant, indexPatterns, playground, reporting, kibanaUpgradeSavedObjects, upgrade, console, runtimeFields, date, spaces, settings, and telemetry sections of the Kibana doc link service.
  • removes the console.serverlessGuide entry since it's no longer different than console.guide.
  • adds a new entry to fix a partial URL in public_base_url.tsx.

The jest tests are resolved with the following commands:

yarn test:jest -u src/core/packages/saved-objects/migration-server-internal/src/initial_state.test.ts
yarn test:jest -u x-pack/platform/plugins/private/upgrade_assistant/public/application/components/es_deprecations/deprecation_types/indices/flyout/steps/details/reindex_details_step.test.tsx
yarn test:jest -u src/platform/plugins/shared/data_view_field_editor/public/components/field_format_editor/editors/url/url.test.tsx

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@lcawl lcawl added Team:Docs release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v9.0.1 labels Apr 30, 2025
@lcawl lcawl mentioned this pull request Apr 30, 2025
Closed
12 tasks
@lcawl lcawl marked this pull request as ready for review April 30, 2025 14:10
@lcawl lcawl requested review from a team as code owners April 30, 2025 14:10
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 30, 2025

Pinging @elastic/kibana-docs (Team:Docs)

florent-leborgne
florent-leborgne approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl requested a review from a team as a code owner April 30, 2025 14:35
@lcawl lcawl mentioned this pull request Apr 30, 2025
Closed
9 tasks
@lcawl lcawl requested review from a team as code owners April 30, 2025 23:07
@prodsecmachine
Copy link
Collaborator

prodsecmachine commented Apr 30, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

davismcphee
davismcphee approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Discovery snapshot change LGTM

jloleysens
jloleysens approved these changes May 1, 2025
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM!

...ration_tests/saved_objects/migrations/group3/incompatible_cluster_routing_allocation.test.ts
Copy link
Contributor

@jloleysens jloleysens May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored this test a little with a try..finally and update the expected text to something not dependent on the doc link.

@lcawl lcawl enabled auto-merge (squash) May 5, 2025 16:58
@lcawl lcawl merged commit be57bf7 into elastic:main May 5, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented May 5, 2025

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/14844096204

@elasticmachine
Copy link
Contributor

elasticmachine commented May 5, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 68.9KB 69.7KB +823.0B
lists 115.6KB 116.4KB +823.0B
total +1.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 431.9KB 432.7KB +814.0B
serverlessSearch 26.1KB 26.1KB -10.0B
total +804.0B

History

@lcawl lcawl deleted the kibana-links branch May 5, 2025 19:06
@kibanamachine
Copy link
Contributor

kibanamachine commented May 5, 2025

💔 All backports failed

Status Branch Result
❌ 9.0 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 219657

Questions ?

Please refer to the Backport tool documentation

@lcawl lcawl mentioned this pull request May 5, 2025
Merged
@lcawl
Copy link
Contributor Author

lcawl commented May 5, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit to lcawl/kibana that referenced this pull request May 5, 2025
@lcawl @jloleysens
Update Kibana URLs in doc link service (elastic#219657)
515e26f 
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
(cherry picked from commit be57bf7)
This was referenced May 5, 2025
Merged
Merged
lcawl added a commit that referenced this pull request May 6, 2025
@lcawl @jloleysens
[9.0] Update Kibana URLs in doc link service (#219657) (#220149)
3c475ee 
# Backport

This will backport the following commits from `main` to `9.0`:
- [Update Kibana URLs in doc link service
(#219657)](#219657)

The following additional command was required to fix a jest failure:

```
yarn test:jest -u x-pack/platform/plugins/private/upgrade_assistant/public/application/components/es_deprecations/deprecation_types/reindex/flyout/checklist_step.test.tsx
```

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2025-05-05T19:03:09Z","message":"Update
Kibana URLs in doc link service (#219657)\n\nCo-authored-by: Jean-Louis
Leysens
<jloleysens@gmail.com>","sha":"be57bf7c814c957837b11eb1a362e440dcbb108c","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","backport:version","v9.1.0","v9.0.1"],"title":"Update
Kibana URLs in doc link
service","number":219657,"url":"https://github.com/elastic/kibana/pull/219657","mergeCommit":{"message":"Update
Kibana URLs in doc link service (#219657)\n\nCo-authored-by: Jean-Louis
Leysens
<jloleysens@gmail.com>","sha":"be57bf7c814c957837b11eb1a362e440dcbb108c"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219657","number":219657,"mergeCommit":{"message":"Update
Kibana URLs in doc link service (#219657)\n\nCo-authored-by: Jean-Louis
Leysens
<jloleysens@gmail.com>","sha":"be57bf7c814c957837b11eb1a362e440dcbb108c"}},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
@lcawl @jloleysens @akowalska622
Update Kibana URLs in doc link service (elastic#219657)
977ade6 
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
qn895 pushed a commit to qn895/kibana that referenced this pull request Jun 3, 2025
@lcawl @jloleysens @qn895
Update Kibana URLs in doc link service (elastic#219657)
f9ff8d7 
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattkime mattkime mattkime approved these changes

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey approved these changes

@jloleysens jloleysens jloleysens approved these changes

@florent-leborgne florent-leborgne florent-leborgne approved these changes

@davismcphee davismcphee davismcphee approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Docs v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@lcawl @elasticmachine @prodsecmachine @kibanamachine @mattkime @TattdCodeMonkey @jloleysens @florent-leborgne @davismcphee