[A11y] Fix Files Flyout incorrect label announcement using VoiceOver#219615
Merged
paulinashakirova merged 6 commits intoelastic:mainfrom May 26, 2025
Merged
Conversation
paulinashakirova
added
Project:Accessibility
Team:SharedUX
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Contributor
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
| defaultMessage: 'Count by extension', | ||
| } | ||
| ), | ||
| filesFlyoutLabel: i18n.translate('filesManagement.filesFlyout.flyoutLabel', { |
Contributor
Author
There was a problem hiding this comment.
Or is it better to write filesFlyoutAriaLabel?
Or what if we add a label/title to the flyout like so?
Also!
Adding aria-label, instead of creating a titleId and connecting them, because for example in my case, the "screenshot etc." wouldn't add clarity so as to what I opened.
Or... this won't be an issue in production since the names there make sense at all times? Not sure... WDYT?
Contributor
There was a problem hiding this comment.
let's link aria label with h2 element
paulinashakirova
added
the
release_note:skip
paulinashakirova
changed the title
alexwizp
approved these changes
May 8, 2025
Dosant
approved these changes
May 8, 2025
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 7.17, 8.17, 8.18, 8.19, 9.0 https://github.com/elastic/kibana/actions/runs/15259521500 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 26, 2025
…lastic#219615) ## Summary This PR fixes [[Platform:StackManagement:Kibana:Files] File panel flyout not announced correctly](elastic#217695) issue. https://github.com/user-attachments/assets/694b475b-0418-427d-bd19-07e218a9cd64 (cherry picked from commit f517280)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 26, 2025
…lastic#219615) ## Summary This PR fixes [[Platform:StackManagement:Kibana:Files] File panel flyout not announced correctly](elastic#217695) issue. https://github.com/user-attachments/assets/694b475b-0418-427d-bd19-07e218a9cd64 (cherry picked from commit f517280)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 26, 2025
…lastic#219615) ## Summary This PR fixes [[Platform:StackManagement:Kibana:Files] File panel flyout not announced correctly](elastic#217695) issue. https://github.com/user-attachments/assets/694b475b-0418-427d-bd19-07e218a9cd64 (cherry picked from commit f517280)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 26, 2025
…lastic#219615) ## Summary This PR fixes [[Platform:StackManagement:Kibana:Files] File panel flyout not announced correctly](elastic#217695) issue. https://github.com/user-attachments/assets/694b475b-0418-427d-bd19-07e218a9cd64 (cherry picked from commit f517280)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 26, 2025
…eOver (#219615) (#221552) # Backport This will backport the following commits from `main` to `9.0`: - [[A11y] Fix Files Flyout incorrect label announcement using VoiceOver (#219615)](#219615) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Paulina Shakirova","email":"paulina.shakirova@elastic.co"},"sourceCommit":{"committedDate":"2025-05-26T17:47:00Z","message":"[A11y] Fix Files Flyout incorrect label announcement using VoiceOver (#219615)\n\n## Summary\n\nThis PR fixes [[Platform:StackManagement:Kibana:Files] File panel flyout\nnot announced\ncorrectly](#217695) issue.\n\n\n\nhttps://github.com/user-attachments/assets/694b475b-0418-427d-bd19-07e218a9cd64","sha":"f517280d92b8d970abcb827aa8eb7ea69c1378f5","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","Team:SharedUX","backport:all-open","a11y","v9.1.0"],"title":"[A11y] Fix Files Flyout incorrect label announcement using VoiceOver","number":219615,"url":"https://github.com/elastic/kibana/pull/219615","mergeCommit":{"message":"[A11y] Fix Files Flyout incorrect label announcement using VoiceOver (#219615)\n\n## Summary\n\nThis PR fixes [[Platform:StackManagement:Kibana:Files] File panel flyout\nnot announced\ncorrectly](#217695) issue.\n\n\n\nhttps://github.com/user-attachments/assets/694b475b-0418-427d-bd19-07e218a9cd64","sha":"f517280d92b8d970abcb827aa8eb7ea69c1378f5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219615","number":219615,"mergeCommit":{"message":"[A11y] Fix Files Flyout incorrect label announcement using VoiceOver (#219615)\n\n## Summary\n\nThis PR fixes [[Platform:StackManagement:Kibana:Files] File panel flyout\nnot announced\ncorrectly](#217695) issue.\n\n\n\nhttps://github.com/user-attachments/assets/694b475b-0418-427d-bd19-07e218a9cd64","sha":"f517280d92b8d970abcb827aa8eb7ea69c1378f5"}}]}] BACKPORT--> Co-authored-by: Paulina Shakirova <paulina.shakirova@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
May 26, 2025
…ceOver (#219615) (#221547) # Backport This will backport the following commits from `main` to `8.17`: - [[A11y] Fix Files Flyout incorrect label announcement using VoiceOver (#219615)](#219615) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Paulina Shakirova","email":"paulina.shakirova@elastic.co"},"sourceCommit":{"committedDate":"2025-05-26T17:47:00Z","message":"[A11y] Fix Files Flyout incorrect label announcement using VoiceOver (#219615)\n\n## Summary\n\nThis PR fixes [[Platform:StackManagement:Kibana:Files] File panel flyout\nnot announced\ncorrectly](#217695) issue.\n\n\n\nhttps://github.com/user-attachments/assets/694b475b-0418-427d-bd19-07e218a9cd64","sha":"f517280d92b8d970abcb827aa8eb7ea69c1378f5","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","Team:SharedUX","backport:all-open","a11y","v9.1.0"],"title":"[A11y] Fix Files Flyout incorrect label announcement using VoiceOver","number":219615,"url":"https://github.com/elastic/kibana/pull/219615","mergeCommit":{"message":"[A11y] Fix Files Flyout incorrect label announcement using VoiceOver (#219615)\n\n## Summary\n\nThis PR fixes [[Platform:StackManagement:Kibana:Files] File panel flyout\nnot announced\ncorrectly](#217695) issue.\n\n\n\nhttps://github.com/user-attachments/assets/694b475b-0418-427d-bd19-07e218a9cd64","sha":"f517280d92b8d970abcb827aa8eb7ea69c1378f5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219615","number":219615,"mergeCommit":{"message":"[A11y] Fix Files Flyout incorrect label announcement using VoiceOver (#219615)\n\n## Summary\n\nThis PR fixes [[Platform:StackManagement:Kibana:Files] File panel flyout\nnot announced\ncorrectly](#217695) issue.\n\n\n\nhttps://github.com/user-attachments/assets/694b475b-0418-427d-bd19-07e218a9cd64","sha":"f517280d92b8d970abcb827aa8eb7ea69c1378f5"}}]}] BACKPORT--> Co-authored-by: Paulina Shakirova <paulina.shakirova@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
May 26, 2025
…ceOver (#219615) (#221549) # Backport This will backport the following commits from `main` to `8.18`: - [[A11y] Fix Files Flyout incorrect label announcement using VoiceOver (#219615)](#219615) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Paulina Shakirova","email":"paulina.shakirova@elastic.co"},"sourceCommit":{"committedDate":"2025-05-26T17:47:00Z","message":"[A11y] Fix Files Flyout incorrect label announcement using VoiceOver (#219615)\n\n## Summary\n\nThis PR fixes [[Platform:StackManagement:Kibana:Files] File panel flyout\nnot announced\ncorrectly](#217695) issue.\n\n\n\nhttps://github.com/user-attachments/assets/694b475b-0418-427d-bd19-07e218a9cd64","sha":"f517280d92b8d970abcb827aa8eb7ea69c1378f5","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","Team:SharedUX","backport:all-open","a11y","v9.1.0"],"title":"[A11y] Fix Files Flyout incorrect label announcement using VoiceOver","number":219615,"url":"https://github.com/elastic/kibana/pull/219615","mergeCommit":{"message":"[A11y] Fix Files Flyout incorrect label announcement using VoiceOver (#219615)\n\n## Summary\n\nThis PR fixes [[Platform:StackManagement:Kibana:Files] File panel flyout\nnot announced\ncorrectly](#217695) issue.\n\n\n\nhttps://github.com/user-attachments/assets/694b475b-0418-427d-bd19-07e218a9cd64","sha":"f517280d92b8d970abcb827aa8eb7ea69c1378f5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219615","number":219615,"mergeCommit":{"message":"[A11y] Fix Files Flyout incorrect label announcement using VoiceOver (#219615)\n\n## Summary\n\nThis PR fixes [[Platform:StackManagement:Kibana:Files] File panel flyout\nnot announced\ncorrectly](#217695) issue.\n\n\n\nhttps://github.com/user-attachments/assets/694b475b-0418-427d-bd19-07e218a9cd64","sha":"f517280d92b8d970abcb827aa8eb7ea69c1378f5"}}]}] BACKPORT--> Co-authored-by: Paulina Shakirova <paulina.shakirova@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
May 26, 2025
…ceOver (#219615) (#221550) # Backport This will backport the following commits from `main` to `8.19`: - [[A11y] Fix Files Flyout incorrect label announcement using VoiceOver (#219615)](#219615) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Paulina Shakirova","email":"paulina.shakirova@elastic.co"},"sourceCommit":{"committedDate":"2025-05-26T17:47:00Z","message":"[A11y] Fix Files Flyout incorrect label announcement using VoiceOver (#219615)\n\n## Summary\n\nThis PR fixes [[Platform:StackManagement:Kibana:Files] File panel flyout\nnot announced\ncorrectly](#217695) issue.\n\n\n\nhttps://github.com/user-attachments/assets/694b475b-0418-427d-bd19-07e218a9cd64","sha":"f517280d92b8d970abcb827aa8eb7ea69c1378f5","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","Team:SharedUX","backport:all-open","a11y","v9.1.0"],"title":"[A11y] Fix Files Flyout incorrect label announcement using VoiceOver","number":219615,"url":"https://github.com/elastic/kibana/pull/219615","mergeCommit":{"message":"[A11y] Fix Files Flyout incorrect label announcement using VoiceOver (#219615)\n\n## Summary\n\nThis PR fixes [[Platform:StackManagement:Kibana:Files] File panel flyout\nnot announced\ncorrectly](#217695) issue.\n\n\n\nhttps://github.com/user-attachments/assets/694b475b-0418-427d-bd19-07e218a9cd64","sha":"f517280d92b8d970abcb827aa8eb7ea69c1378f5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219615","number":219615,"mergeCommit":{"message":"[A11y] Fix Files Flyout incorrect label announcement using VoiceOver (#219615)\n\n## Summary\n\nThis PR fixes [[Platform:StackManagement:Kibana:Files] File panel flyout\nnot announced\ncorrectly](#217695) issue.\n\n\n\nhttps://github.com/user-attachments/assets/694b475b-0418-427d-bd19-07e218a9cd64","sha":"f517280d92b8d970abcb827aa8eb7ea69c1378f5"}}]}] BACKPORT--> Co-authored-by: Paulina Shakirova <paulina.shakirova@elastic.co>
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
…lastic#219615) ## Summary This PR fixes [[Platform:StackManagement:Kibana:Files] File panel flyout not announced correctly](elastic#217695) issue. https://github.com/user-attachments/assets/694b475b-0418-427d-bd19-07e218a9cd64
Contributor
|
This PR didn't make it into the latest v8.17.7 BC. Updating the labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes [Platform:StackManagement:Kibana:Files] File panel flyout not announced correctly issue.
Screen.Recording.2025-04-29.at.19.01.40.mov