[AI4DSOC] Change rules details page capabilities#219260
[AI4DSOC] Change rules details page capabilities#219260tomsonpl merged 5 commits intoelastic:mainfrom
Conversation
|
/ci |
rylnd
left a comment
There was a problem hiding this comment.
No logic was changed in Detection Engine code; only the addition of a few constants.
I think @elastic/security-detection-rule-management should confirm whether these capabilities are correct; besides that, this LGTM.
xcrzx
left a comment
There was a problem hiding this comment.
Tested the navigation locally in both AI4SOC and Complete tiers. The rule details page is accessible as expected, and no regressions spotted in the Complete tier. LGTM 👍
stephmilovic
left a comment
There was a problem hiding this comment.
Code review only, LGTM!!
PhilippeOberti
left a comment
There was a problem hiding this comment.
Blocking the merge as allowing access to the rule details page in AI4DSOC might not be the right move right now.
As you can see in the video below, we have buttons which lead to pages not found (like the edit button), we have actions available that probably should not be (duplicate, delete...), we have the chart that has cell actions, we have the wrong table, access to all the non-AI4DSOC flyouts…
PhilippeOberti
left a comment
There was a problem hiding this comment.
So @jamesspi decided to go ahead and allow the page to be visible, despite all the UI inconsistencies and issues.
I'm then approving the PR. I will start working on cleaning up the UI for AI4DSOC, starting with the alerts table.
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
cc @tomsonpl |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
refs changes in elastic#219260
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
2 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
This approach was suggested by @semd , big thank you 👍
Summary
This PR enhances the navigation and access control for the Security Solution's rules management functionality.
It introduces a dedicated
rulesManagementpage name in the deep links system and updates the routing configuration to properly handle rule details pages while restricting access to editing capabilities and the landing page based on user permissions.It's a follow up to this PR: #219111
Changes
renderoverwrite to enable rule details linksTesting