[Console] Fix output when HTTP request to server fails#219073
Merged
ElenaStoeva merged 2 commits intoelastic:mainfrom Apr 25, 2025
Merged
[Console] Fix output when HTTP request to server fails#219073ElenaStoeva merged 2 commits intoelastic:mainfrom
ElenaStoeva merged 2 commits intoelastic:mainfrom
Conversation
ElenaStoeva
added
Feature:Console
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @ElenaStoeva |
sabarasaba
approved these changes
Apr 25, 2025
Member
sabarasaba
left a comment
sabarasaba
left a comment
There was a problem hiding this comment.
Changes lgtm, tested locally.
Nit: The status code and error is already shown in the status bar, perhaps just showing the error message is enough? 🤔
Contributor
Author
Do you mean that the status code badge is redundant? I think we still need it because in some situations we don't have the status code displayed in the error response body - for example, from Kibana requests. Edit: Merging the PR to fix the bug. @sabarasaba let me know if I misunderstood your suggestion - we could address this in a follow-up PR as an enhancement. |
Contributor
|
Starting backport for target branches: 8.18, 8.19, 9.0 https://github.com/elastic/kibana/actions/runs/14669813960 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 25, 2025
Follow-up to elastic#218104 (comment) ## Summary This PR fixes the Console output when the HTTP request to the server fails with a non-empty error body. In elastic#218104, we incorrectly set the output to be `Request failed to get to the server (status code: ' + statusCode + ')` even if there is an error body. In this PR, we make sure to display the error body if it's non-empty. **How to test:** Send a request that fails and verify that the error body is displayed: ``` POST kbn:/api/alerting/rule/3603c386-9102-4c74-800d-2242e52bec98 { "name": "Alert on status change", "rule_type_id": ".es-querya" } ``` <img width="1160" alt="Screenshot 2025-04-24 at 14 41 57" src="https://github.com/user-attachments/assets/ced78171-4924-477f-ba2f-d5812bff1678" /> (cherry picked from commit cb0acc1)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 25, 2025
… (#219295) # Backport This will backport the following commits from `main` to `8.19`: - [[Console] Fix output when HTTP request to server fails (#219073)](#219073) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Elena Stoeva","email":"59341489+ElenaStoeva@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-25T17:09:09Z","message":"[Console] Fix output when HTTP request to server fails (#219073)\n\nFollow-up to\nhttps://github.com//pull/218104#issuecomment-2824757130\n\n## Summary\n\nThis PR fixes the Console output when the HTTP request to the server\nfails with a non-empty error body. In\nhttps://github.com//pull/218104, we incorrectly set the\noutput to be `Request failed to get to the server (status code: ' +\nstatusCode + ')` even if there is an error body. In this PR, we make\nsure to display the error body if it's non-empty.\n\n**How to test:**\n\nSend a request that fails and verify that the error body is displayed:\n\n```\nPOST kbn:/api/alerting/rule/3603c386-9102-4c74-800d-2242e52bec98\n{\n \"name\": \"Alert on status change\",\n \"rule_type_id\": \".es-querya\"\n}\n```\n<img width=\"1160\" alt=\"Screenshot 2025-04-24 at 14 41 57\"\nsrc=\"https://github.com/user-attachments/assets/ced78171-4924-477f-ba2f-d5812bff1678\"\n/>","sha":"cb0acc16ee85e4dccc67dcb69dbbba3f328accad","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","backport:prev-minor","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"[Console] Fix output when HTTP request to server fails","number":219073,"url":"https://github.com/elastic/kibana/pull/219073","mergeCommit":{"message":"[Console] Fix output when HTTP request to server fails (#219073)\n\nFollow-up to\nhttps://github.com//pull/218104#issuecomment-2824757130\n\n## Summary\n\nThis PR fixes the Console output when the HTTP request to the server\nfails with a non-empty error body. In\nhttps://github.com//pull/218104, we incorrectly set the\noutput to be `Request failed to get to the server (status code: ' +\nstatusCode + ')` even if there is an error body. In this PR, we make\nsure to display the error body if it's non-empty.\n\n**How to test:**\n\nSend a request that fails and verify that the error body is displayed:\n\n```\nPOST kbn:/api/alerting/rule/3603c386-9102-4c74-800d-2242e52bec98\n{\n \"name\": \"Alert on status change\",\n \"rule_type_id\": \".es-querya\"\n}\n```\n<img width=\"1160\" alt=\"Screenshot 2025-04-24 at 14 41 57\"\nsrc=\"https://github.com/user-attachments/assets/ced78171-4924-477f-ba2f-d5812bff1678\"\n/>","sha":"cb0acc16ee85e4dccc67dcb69dbbba3f328accad"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","8.18","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219073","number":219073,"mergeCommit":{"message":"[Console] Fix output when HTTP request to server fails (#219073)\n\nFollow-up to\nhttps://github.com//pull/218104#issuecomment-2824757130\n\n## Summary\n\nThis PR fixes the Console output when the HTTP request to the server\nfails with a non-empty error body. In\nhttps://github.com//pull/218104, we incorrectly set the\noutput to be `Request failed to get to the server (status code: ' +\nstatusCode + ')` even if there is an error body. In this PR, we make\nsure to display the error body if it's non-empty.\n\n**How to test:**\n\nSend a request that fails and verify that the error body is displayed:\n\n```\nPOST kbn:/api/alerting/rule/3603c386-9102-4c74-800d-2242e52bec98\n{\n \"name\": \"Alert on status change\",\n \"rule_type_id\": \".es-querya\"\n}\n```\n<img width=\"1160\" alt=\"Screenshot 2025-04-24 at 14 41 57\"\nsrc=\"https://github.com/user-attachments/assets/ced78171-4924-477f-ba2f-d5812bff1678\"\n/>","sha":"cb0acc16ee85e4dccc67dcb69dbbba3f328accad"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Elena Stoeva <59341489+ElenaStoeva@users.noreply.github.com>
ElenaStoeva
added a commit
to ElenaStoeva/kibana
that referenced
this pull request
Apr 28, 2025
Follow-up to elastic#218104 (comment) ## Summary This PR fixes the Console output when the HTTP request to the server fails with a non-empty error body. In elastic#218104, we incorrectly set the output to be `Request failed to get to the server (status code: ' + statusCode + ')` even if there is an error body. In this PR, we make sure to display the error body if it's non-empty. **How to test:** Send a request that fails and verify that the error body is displayed: ``` POST kbn:/api/alerting/rule/3603c386-9102-4c74-800d-2242e52bec98 { "name": "Alert on status change", "rule_type_id": ".es-querya" } ``` <img width="1160" alt="Screenshot 2025-04-24 at 14 41 57" src="https://github.com/user-attachments/assets/ced78171-4924-477f-ba2f-d5812bff1678" /> (cherry picked from commit cb0acc1) # Conflicts: # src/platform/plugins/shared/console/public/application/hooks/use_send_current_request/send_request.ts
This was referenced Apr 28, 2025
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
ElenaStoeva
added a commit
to ElenaStoeva/kibana
that referenced
this pull request
Apr 28, 2025
Follow-up to elastic#218104 (comment) ## Summary This PR fixes the Console output when the HTTP request to the server fails with a non-empty error body. In elastic#218104, we incorrectly set the output to be `Request failed to get to the server (status code: ' + statusCode + ')` even if there is an error body. In this PR, we make sure to display the error body if it's non-empty. **How to test:** Send a request that fails and verify that the error body is displayed: ``` POST kbn:/api/alerting/rule/3603c386-9102-4c74-800d-2242e52bec98 { "name": "Alert on status change", "rule_type_id": ".es-querya" } ``` <img width="1160" alt="Screenshot 2025-04-24 at 14 41 57" src="https://github.com/user-attachments/assets/ced78171-4924-477f-ba2f-d5812bff1678" /> (cherry picked from commit cb0acc1) # Conflicts: # src/platform/plugins/shared/console/public/application/hooks/use_send_current_request/send_request.ts
ElenaStoeva
added a commit
to ElenaStoeva/kibana
that referenced
this pull request
Apr 28, 2025
Follow-up to elastic#218104 (comment) This PR fixes the Console output when the HTTP request to the server fails with a non-empty error body. In elastic#218104, we incorrectly set the output to be `Request failed to get to the server (status code: ' + statusCode + ')` even if there is an error body. In this PR, we make sure to display the error body if it's non-empty. **How to test:** Send a request that fails and verify that the error body is displayed: ``` POST kbn:/api/alerting/rule/3603c386-9102-4c74-800d-2242e52bec98 { "name": "Alert on status change", "rule_type_id": ".es-querya" } ``` <img width="1160" alt="Screenshot 2025-04-24 at 14 41 57" src="https://github.com/user-attachments/assets/ced78171-4924-477f-ba2f-d5812bff1678" /> (cherry picked from commit cb0acc1)
ElenaStoeva
added a commit
that referenced
this pull request
Apr 30, 2025
#219439) # Backport This will backport the following commits from `main` to `9.0`: - [[Console] Fix output when HTTP request to server fails (#219073)](#219073) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Elena Stoeva","email":"59341489+ElenaStoeva@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-25T17:09:09Z","message":"[Console] Fix output when HTTP request to server fails (#219073)\n\nFollow-up to\nhttps://github.com//pull/218104#issuecomment-2824757130\n\n## Summary\n\nThis PR fixes the Console output when the HTTP request to the server\nfails with a non-empty error body. In\nhttps://github.com//pull/218104, we incorrectly set the\noutput to be `Request failed to get to the server (status code: ' +\nstatusCode + ')` even if there is an error body. In this PR, we make\nsure to display the error body if it's non-empty.\n\n**How to test:**\n\nSend a request that fails and verify that the error body is displayed:\n\n```\nPOST kbn:/api/alerting/rule/3603c386-9102-4c74-800d-2242e52bec98\n{\n \"name\": \"Alert on status change\",\n \"rule_type_id\": \".es-querya\"\n}\n```\n<img width=\"1160\" alt=\"Screenshot 2025-04-24 at 14 41 57\"\nsrc=\"https://github.com/user-attachments/assets/ced78171-4924-477f-ba2f-d5812bff1678\"\n/>","sha":"cb0acc16ee85e4dccc67dcb69dbbba3f328accad","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","backport:prev-minor","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"[Console] Fix output when HTTP request to server fails","number":219073,"url":"https://github.com/elastic/kibana/pull/219073","mergeCommit":{"message":"[Console] Fix output when HTTP request to server fails (#219073)\n\nFollow-up to\nhttps://github.com//pull/218104#issuecomment-2824757130\n\n## Summary\n\nThis PR fixes the Console output when the HTTP request to the server\nfails with a non-empty error body. In\nhttps://github.com//pull/218104, we incorrectly set the\noutput to be `Request failed to get to the server (status code: ' +\nstatusCode + ')` even if there is an error body. In this PR, we make\nsure to display the error body if it's non-empty.\n\n**How to test:**\n\nSend a request that fails and verify that the error body is displayed:\n\n```\nPOST kbn:/api/alerting/rule/3603c386-9102-4c74-800d-2242e52bec98\n{\n \"name\": \"Alert on status change\",\n \"rule_type_id\": \".es-querya\"\n}\n```\n<img width=\"1160\" alt=\"Screenshot 2025-04-24 at 14 41 57\"\nsrc=\"https://github.com/user-attachments/assets/ced78171-4924-477f-ba2f-d5812bff1678\"\n/>","sha":"cb0acc16ee85e4dccc67dcb69dbbba3f328accad"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219073","number":219073,"mergeCommit":{"message":"[Console] Fix output when HTTP request to server fails (#219073)\n\nFollow-up to\nhttps://github.com//pull/218104#issuecomment-2824757130\n\n## Summary\n\nThis PR fixes the Console output when the HTTP request to the server\nfails with a non-empty error body. In\nhttps://github.com//pull/218104, we incorrectly set the\noutput to be `Request failed to get to the server (status code: ' +\nstatusCode + ')` even if there is an error body. In this PR, we make\nsure to display the error body if it's non-empty.\n\n**How to test:**\n\nSend a request that fails and verify that the error body is displayed:\n\n```\nPOST kbn:/api/alerting/rule/3603c386-9102-4c74-800d-2242e52bec98\n{\n \"name\": \"Alert on status change\",\n \"rule_type_id\": \".es-querya\"\n}\n```\n<img width=\"1160\" alt=\"Screenshot 2025-04-24 at 14 41 57\"\nsrc=\"https://github.com/user-attachments/assets/ced78171-4924-477f-ba2f-d5812bff1678\"\n/>","sha":"cb0acc16ee85e4dccc67dcb69dbbba3f328accad"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/219295","number":219295,"state":"MERGED","mergeCommit":{"sha":"cd3c92728e0e6792a2dcf8a39b3d8bf71589c929","message":"[8.19] [Console] Fix output when HTTP request to server fails (#219073) (#219295)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.19`:\n- [[Console] Fix output when HTTP request to server fails\n(#219073)](https://github.com/elastic/kibana/pull/219073)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Elena Stoeva <59341489+ElenaStoeva@users.noreply.github.com>"}},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
ElenaStoeva
added a commit
that referenced
this pull request
Apr 30, 2025
… (#219440) # Backport This will backport the following commits from `main` to `8.18`: - [[Console] Fix output when HTTP request to server fails (#219073)](#219073) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Elena Stoeva","email":"59341489+ElenaStoeva@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-25T17:09:09Z","message":"[Console] Fix output when HTTP request to server fails (#219073)\n\nFollow-up to\nhttps://github.com//pull/218104#issuecomment-2824757130\n\n## Summary\n\nThis PR fixes the Console output when the HTTP request to the server\nfails with a non-empty error body. In\nhttps://github.com//pull/218104, we incorrectly set the\noutput to be `Request failed to get to the server (status code: ' +\nstatusCode + ')` even if there is an error body. In this PR, we make\nsure to display the error body if it's non-empty.\n\n**How to test:**\n\nSend a request that fails and verify that the error body is displayed:\n\n```\nPOST kbn:/api/alerting/rule/3603c386-9102-4c74-800d-2242e52bec98\n{\n \"name\": \"Alert on status change\",\n \"rule_type_id\": \".es-querya\"\n}\n```\n<img width=\"1160\" alt=\"Screenshot 2025-04-24 at 14 41 57\"\nsrc=\"https://github.com/user-attachments/assets/ced78171-4924-477f-ba2f-d5812bff1678\"\n/>","sha":"cb0acc16ee85e4dccc67dcb69dbbba3f328accad","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","backport:prev-minor","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"[Console] Fix output when HTTP request to server fails","number":219073,"url":"https://github.com/elastic/kibana/pull/219073","mergeCommit":{"message":"[Console] Fix output when HTTP request to server fails (#219073)\n\nFollow-up to\nhttps://github.com//pull/218104#issuecomment-2824757130\n\n## Summary\n\nThis PR fixes the Console output when the HTTP request to the server\nfails with a non-empty error body. In\nhttps://github.com//pull/218104, we incorrectly set the\noutput to be `Request failed to get to the server (status code: ' +\nstatusCode + ')` even if there is an error body. In this PR, we make\nsure to display the error body if it's non-empty.\n\n**How to test:**\n\nSend a request that fails and verify that the error body is displayed:\n\n```\nPOST kbn:/api/alerting/rule/3603c386-9102-4c74-800d-2242e52bec98\n{\n \"name\": \"Alert on status change\",\n \"rule_type_id\": \".es-querya\"\n}\n```\n<img width=\"1160\" alt=\"Screenshot 2025-04-24 at 14 41 57\"\nsrc=\"https://github.com/user-attachments/assets/ced78171-4924-477f-ba2f-d5812bff1678\"\n/>","sha":"cb0acc16ee85e4dccc67dcb69dbbba3f328accad"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219073","number":219073,"mergeCommit":{"message":"[Console] Fix output when HTTP request to server fails (#219073)\n\nFollow-up to\nhttps://github.com//pull/218104#issuecomment-2824757130\n\n## Summary\n\nThis PR fixes the Console output when the HTTP request to the server\nfails with a non-empty error body. In\nhttps://github.com//pull/218104, we incorrectly set the\noutput to be `Request failed to get to the server (status code: ' +\nstatusCode + ')` even if there is an error body. In this PR, we make\nsure to display the error body if it's non-empty.\n\n**How to test:**\n\nSend a request that fails and verify that the error body is displayed:\n\n```\nPOST kbn:/api/alerting/rule/3603c386-9102-4c74-800d-2242e52bec98\n{\n \"name\": \"Alert on status change\",\n \"rule_type_id\": \".es-querya\"\n}\n```\n<img width=\"1160\" alt=\"Screenshot 2025-04-24 at 14 41 57\"\nsrc=\"https://github.com/user-attachments/assets/ced78171-4924-477f-ba2f-d5812bff1678\"\n/>","sha":"cb0acc16ee85e4dccc67dcb69dbbba3f328accad"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/219295","number":219295,"state":"MERGED","mergeCommit":{"sha":"cd3c92728e0e6792a2dcf8a39b3d8bf71589c929","message":"[8.19] [Console] Fix output when HTTP request to server fails (#219073) (#219295)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.19`:\n- [[Console] Fix output when HTTP request to server fails\n(#219073)](https://github.com/elastic/kibana/pull/219073)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Elena Stoeva <59341489+ElenaStoeva@users.noreply.github.com>"}},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
Follow-up to elastic#218104 (comment) ## Summary This PR fixes the Console output when the HTTP request to the server fails with a non-empty error body. In elastic#218104, we incorrectly set the output to be `Request failed to get to the server (status code: ' + statusCode + ')` even if there is an error body. In this PR, we make sure to display the error body if it's non-empty. **How to test:** Send a request that fails and verify that the error body is displayed: ``` POST kbn:/api/alerting/rule/3603c386-9102-4c74-800d-2242e52bec98 { "name": "Alert on status change", "rule_type_id": ".es-querya" } ``` <img width="1160" alt="Screenshot 2025-04-24 at 14 41 57" src="https://github.com/user-attachments/assets/ced78171-4924-477f-ba2f-d5812bff1678" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #218104 (comment)
Summary
This PR fixes the Console output when the HTTP request to the server fails with a non-empty error body. In #218104, we incorrectly set the output to be
Request failed to get to the server (status code: ' + statusCode + ')even if there is an error body. In this PR, we make sure to display the error body if it's non-empty.How to test:
Send a request that fails and verify that the error body is displayed: