[Console] Fix output for empty response body

[ElenaStoeva]

Fixes #217433

Summary

This PR fixes the Console output when the response body is an empty string.

In #199975, we made Console to display an OK output if the status code is 200 but response body is null. Previously, POST /_cluster/voting_config_exclusions?node_names=node returned null and so the output was correctly set to OK but now the response is an empty string and this case isn't covered correctly. In this PR, we make sure to perform the right check at the right point so that both null and empty strings are covered.

The test that covers this scenario and had failures:

kibana/src/platform/test/functional/apps/console/_console.ts

Line 258 in 7092e79

it('Shows OK when status code is 200 but body is empty', async () => {

To run the failing test with the new Es snapshots:

ES_SNAPSHOT_MANIFEST="https://storage.googleapis.com/kibana-ci-es-snapshots-daily/8.19.0/archives/20250414-022022_f16f4ce6/manifest.json" node scripts/functional_tests_server.js --config ./src/platform/test/functional/apps/console/config.ts

and

ES_SNAPSHOT_MANIFEST="https://storage.googleapis.com/kibana-ci-es-snapshots-daily/9.1.0/archives/20250414-021844_4ed1a000/manifest.json" node scripts/functional_test_runner.js  --config ./src/platform/test/functional/apps/console/config.ts --grep="Shows OK when status code is 200 but body is empty"

[elasticmachine]

Pinging @elastic/kibana-management (Team:Kibana Management)

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 932e71e

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
console	186.4KB	186.3KB	-28.0B

History

• 💔 Build #292733 failed eed32a4

cc @ElenaStoeva

[mattkime]

Changes are good and work well, thanks!

[kibanamachine]

Starting backport for target branches: 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/14456687640

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.x
✅	9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

[kibanamachine]

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

[nchaulet]

Hi @mattkime @ElenaStoeva looks like since that change we are not showing body for any errors even when there is a body it is expected? it seems to me there is still some value for users to get that body no?

[ElenaStoeva]

Hi @nchaulet, can you provide the request that caused this response?

[nchaulet]

Sure here it is, any non 200 seems to trigger that response even if there is a body

POST kbn:/api/alerting/rule/3603c386-9102-4c74-800d-2242e52bec98
{
  "name": "Alert on status change",
  "rule_type_id": ".es-querya",
    "consumer": "stackAlerts",
  "tags": [],
  "schedule": {
    "interval": "1m"
  },
  "params": {
    "searchType": "esqlQuery",
    "timeWindowSize": 5,
    "timeWindowUnit": "m",
    "threshold": [
      0
    ],
    "thresholdComparator": ">",
    "size": 100,
    "esqlQuery": {
      "esql": "FROM logs-elastic_agent.status_change-default \n | WHERE status ==   \"ONLINE\"\n  | STATS count = COUNT(*) BY agent.id  /* you can group by a field using the BY operator */"
    },
    "aggType": "count",
    "groupBy": "row",
    "termSize": 10000,
    "termField": "agent.id",
    "sourceFields": [],
    "timeField": "@timestamp",
    "excludeHitsFromPreviousRun": true
  },
  "actions": [],
  "alert_delay": {
    "active": 1
  }
}

[ElenaStoeva]

Thanks for reporting this @nchaulet! I created #219073 to fix this regression.